[ibm-acpi-devel] [PATCH v5] platform/x86: thinkpad_acpi: lap or desk mode interface

2020-07-02 Thread Mark Pearson
Newer Lenovo Thinkpad platforms have support to identify whether the system is on-lap or not using an ACPI DYTC event from the firmware. This patch provides the ability to retrieve the current mode via sysfs entrypoints and will be used by userspace for thermal mode and WWAN functionality Co-deve

Re: [ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid

2020-07-02 Thread Andy Shevchenko
On Thu, Jul 2, 2020 at 1:51 PM Aaron Ma wrote: > On 7/2/20 5:30 PM, Andy Shevchenko wrote: > > On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma wrote: > >> > >> When _BCL invalid, disable thinkpad_acpi backlight brightness control. > >> > >> brightness_enable is already checked at the beginning, > > > >>

Re: [ibm-acpi-devel] [External] Re: [PATCH v4] platform/x86: thinkpad_acpi: lap or desk mode interface

2020-07-02 Thread Andy Shevchenko
On Thu, Jul 2, 2020 at 1:45 PM Mark Pearson wrote: > On 7/2/2020 5:29 AM, Andy Shevchenko wrote: > > On Mon, Jun 29, 2020 at 10:23 PM Mark Pearson > > wrote: ... > > You specifically added a new ABI, where is documentation? It's a show > > stopper. > Ah - my apologies I didn't know that was a

Re: [ibm-acpi-devel] [External] Re: [PATCH v4] platform/x86: thinkpad_acpi: lap or desk mode interface

2020-07-02 Thread Mark Pearson
Thanks Andy On 7/2/2020 5:29 AM, Andy Shevchenko wrote: On Mon, Jun 29, 2020 at 10:23 PM Mark Pearson wrote: Thanks for the patch, my comments below. Newer Lenovo Thinkpad platforms have support to identify whether the system is on-lap or not using an ACPI DYTC event from the firmware.

Re: [ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid

2020-07-02 Thread Andy Shevchenko
On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma wrote: > > When _BCL invalid, disable thinkpad_acpi backlight brightness control. > > brightness_enable is already checked at the beginning, > Always print notice when enabled brightness control. Why? ... > + pr_notice("thinkpad_acpi native bright

Re: [ibm-acpi-devel] [PATCH v4] platform/x86: thinkpad_acpi: lap or desk mode interface

2020-07-02 Thread Andy Shevchenko
On Mon, Jun 29, 2020 at 10:23 PM Mark Pearson wrote: Thanks for the patch, my comments below. > Newer Lenovo Thinkpad platforms have support to identify whether the > system is on-lap or not using an ACPI DYTC event from the firmware. > > This patch provides the ability to retrieve the cur