Re: [ibm-acpi-devel] [External] [PATCH] platform/x86: thinkpad_acpi: Add support for dual fan control

2021-11-08 Thread Mark Pearson
Thanks Jimmy, On 2021-11-07 21:55, Jimmy Wang wrote: This adds dual fan control for P1 / X1 Extreme Gen4 Signed-off-by: Jimmy Wang --- drivers/platform/x86/thinkpad_acpi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/th

Re: [ibm-acpi-devel] [PATCH v3] Fix WWAN device disabled issue after S3 deep

2021-11-08 Thread Hans de Goede
Hi, On 11/8/21 07:06, Slark Xiao wrote: > When WWAN device wake from S3 deep, under thinkpad platform, > WWAN would be disabled. This disable status could be checked > by command 'nmcli r wwan' or 'rfkill list'. > > Issue analysis as below: > When host resume from S3 deep, thinkpad_acpi driver

Re: [ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: Add support for dual fan control

2021-11-08 Thread Hans de Goede
Hi, On 11/5/21 10:05, Jimmy Wang wrote: >This adds dual fan control for P1 / X1 Extreme Gen4 > > Signed-off-by: Jimmy Wang Thanks, patch looks good to me. I will merge this once 5.16-rc1 is out. Regards, Hans > --- > drivers/platform/x86/thinkpad_acpi.c | 1 + > 1 file changed, 1 inse

Re: [ibm-acpi-devel] [PATCH v2][next] platform/x86: thinkpad_acpi: Convert platform driver to use dev_groups

2021-11-08 Thread Hans de Goede
Hi, On 10/23/21 17:40, Len Baker wrote: > Platform drivers have the option of having the platform core create and > remove any needed sysfs attribute files. So take advantage of that and > refactor the attributes management to avoid to register them "by hand". > > Also, due to some attributes are