Re: [ibm-acpi-devel] [PATCH v1 1/5] ACPI: utils: Introduce acpi_match_video_device_handle() helper

2022-06-30 Thread Mika Westerberg
Hi Andy, On Fri, Jul 01, 2022 at 12:28:15AM +0300, Andy Shevchenko wrote: > extern long acpi_is_video_device(acpi_handle handle); > +extern bool acpi_match_video_device_handle(acpi_handle handle); I think we can do slightly better here. The only caller of acpi_is_video_device() is in drivers/acp

[ibm-acpi-devel] [PATCH v1 3/5] i2c: acpi: Convert to use acpi_match_video_device_handle() helper

2022-06-30 Thread Andy Shevchenko
Replace open coded variant of acpi_match_video_device_handle() helper. Signed-off-by: Andy Shevchenko --- drivers/i2c/i2c-core-acpi.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c index 08b561f0709d.

[ibm-acpi-devel] [PATCH v1 4/5] PCI/VGA: Convert to use acpi_match_video_device_handle() helper

2022-06-30 Thread Andy Shevchenko
Replace open coded variant of acpi_match_video_device_handle() helper. Signed-off-by: Andy Shevchenko --- drivers/pci/vgaarb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c index f80b6ec88dc3..47058f70c2c9 100644 --- a/drivers/

[ibm-acpi-devel] [PATCH v1 5/5] platform/x86: thinkpad_acpi: Convert to use acpi_match_video_device_handle() helper

2022-06-30 Thread Andy Shevchenko
Replace open coded variant of acpi_match_video_device_handle() helper. Signed-off-by: Andy Shevchenko --- drivers/platform/x86/thinkpad_acpi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index

[ibm-acpi-devel] [PATCH v1 2/5] ACPI: video: Convert to use acpi_match_video_device_handle() helper

2022-06-30 Thread Andy Shevchenko
Replace open coded variant of acpi_match_video_device_handle() helper. Signed-off-by: Andy Shevchenko --- drivers/acpi/video_detect.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index becc198e4c22..14ddbd821

[ibm-acpi-devel] [PATCH v1 1/5] ACPI: utils: Introduce acpi_match_video_device_handle() helper

2022-06-30 Thread Andy Shevchenko
There are a couple of users that open code functionality of matching a given handle against ACPI video device IDs. The current approach duplicates ID table along with the matching code. Consolidate it under the acpi_match_video_device_handle() helper's hood. Signed-off-by: Andy Shevchenko --- dr