Re: [ibm-acpi-devel] [PATCH][next] platform/x86: thinkpad_acpi: remove redundant assignment to variable i

2024-01-08 Thread Hans de Goede
Hi, On 1/6/24 16:47, Colin Ian King wrote: > The variable i is being initialized with the value 0 that is never > read, it is being re-assigned 0 again in a for-loop statement later > on. The initialization is redundant and can be removed. > > The initialization of variable n can also be deferred

Re: [ibm-acpi-devel] [PATCH RFC] platform/x86: Lenovo sub directory

2024-01-08 Thread Mark Pearson
Thanks for the review Hans, On Mon, Jan 8, 2024, at 9:17 AM, Hans de Goede wrote: > Hi Mark, > > On 1/4/24 01:37, Mark Pearson wrote: >> Looking for feedback if this is a good idea or not, and if I've missed >> anything important. >> >> Over the holidays it was raining and I was bored so I was to

Re: [ibm-acpi-devel] [PATCH RFC] platform/x86: Lenovo sub directory

2024-01-08 Thread Hans de Goede
Hi Mark, On 1/4/24 01:37, Mark Pearson wrote: > Looking for feedback if this is a good idea or not, and if I've missed > anything important. > > Over the holidays it was raining and I was bored so I was toying with the > idea of moving some of the thinkpad_acpi functionality out of the file > int