Re: [ibm-acpi-devel] [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes

2024-04-08 Thread Mark Pearson
Hi Dmitry On Mon, Apr 8, 2024, at 7:31 PM, Dmitry Torokhov wrote: > Hi Mark, > > On Sun, Mar 24, 2024 at 05:07:58PM -0400, Mark Pearson wrote: >> Add support for new input events on Lenovo laptops that need exporting to >> user space. >> >> Lenovo trackpoints are adding the ability to generate a

Re: [ibm-acpi-devel] [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes

2024-04-08 Thread Dmitry Torokhov
Hi Mark, On Sun, Mar 24, 2024 at 05:07:58PM -0400, Mark Pearson wrote: > Add support for new input events on Lenovo laptops that need exporting to > user space. > > Lenovo trackpoints are adding the ability to generate a doubletap event. > Add a new keycode to allow this to be used by userspace.

Re: [ibm-acpi-devel] [PATCH v5 1/3] ACPI: platform-profile: add platform_profile_cycle()

2024-04-08 Thread Rafael J. Wysocki
On Mon, Apr 8, 2024 at 6:41 PM Hans de Goede wrote: > > Hi Gergo, > > On 4/6/24 2:01 AM, Gergo Koteles wrote: > > Some laptops have a key to switch platform profiles. > > > > Add a platform_profile_cycle() function to cycle between the enabled > > profiles. > > > > Signed-off-by: Gergo Koteles >

Re: [ibm-acpi-devel] [PATCH v5 1/3] ACPI: platform-profile: add platform_profile_cycle()

2024-04-08 Thread Hans de Goede
Hi Gergo, On 4/6/24 2:01 AM, Gergo Koteles wrote: > Some laptops have a key to switch platform profiles. > > Add a platform_profile_cycle() function to cycle between the enabled > profiles. > > Signed-off-by: Gergo Koteles Thank you for your patch, 1 small remark below, otherwise this looks go

Re: [ibm-acpi-devel] [PATCH 3/4] platform/x86: thinkpad_acpi: Support for system debug info hotkey

2024-04-08 Thread Mark Pearson
Thanks Hans On Mon, Apr 8, 2024, at 9:11 AM, Hans de Goede wrote: > Hi, > > On 3/24/24 10:08 PM, Mark Pearson wrote: >> New Lenovo platforms are adding the FN+N key to generate system debug >> details that support can use for collecting important details on any >> customer cases for Windows. >> Ad

Re: [ibm-acpi-devel] [PATCH 2/4] platform/x86: thinkpad_acpi: Support for trackpoint doubletap

2024-04-08 Thread Mark Pearson
Hi Hans, Many thanks for the review. On Mon, Apr 8, 2024, at 9:04 AM, Hans de Goede wrote: > Hi Mark, > > On 3/24/24 10:07 PM, Mark Pearson wrote: >> Lenovo trackpoints are adding the ability to generate a doubletap event. >> This handles the doubletap event and sends the KEY_DOUBLECLICK event to

Re: [ibm-acpi-devel] [PATCH 4/4] platform/x86: thinkpad_acpi: Support hotkey to disable trackpoint doubletap

2024-04-08 Thread Hans de Goede
Hi, On 3/24/24 10:08 PM, Mark Pearson wrote: > The hotkey combination FN+G can be used to disable the trackpoint > doubletap feature on Windows. > Add matching functionality for Linux. > > Signed-off-by: Mark Pearson > Signed-off-by: Vishnu Sankar > --- > drivers/platform/x86/thinkpad_acpi.c |

Re: [ibm-acpi-devel] [PATCH 3/4] platform/x86: thinkpad_acpi: Support for system debug info hotkey

2024-04-08 Thread Hans de Goede
Hi, On 3/24/24 10:08 PM, Mark Pearson wrote: > New Lenovo platforms are adding the FN+N key to generate system debug > details that support can use for collecting important details on any > customer cases for Windows. > Add the infrastructure so we can do the same on Linux by generating a > SYS_DE

Re: [ibm-acpi-devel] [PATCH 2/4] platform/x86: thinkpad_acpi: Support for trackpoint doubletap

2024-04-08 Thread Hans de Goede
Hi Mark, On 3/24/24 10:07 PM, Mark Pearson wrote: > Lenovo trackpoints are adding the ability to generate a doubletap event. > This handles the doubletap event and sends the KEY_DOUBLECLICK event to > userspace. > > Signed-off-by: Mark Pearson > Signed-off-by: Vishnu Sankar > --- > drivers/pla

Re: [ibm-acpi-devel] [PATCH 1/4] Input: Add trackpoint doubletap and system debug info keycodes

2024-04-08 Thread Hans de Goede
Hi, On 3/24/24 10:07 PM, Mark Pearson wrote: > Add support for new input events on Lenovo laptops that need exporting to > user space. > > Lenovo trackpoints are adding the ability to generate a doubletap event. > Add a new keycode to allow this to be used by userspace. > > Lenovo support is usi