Hi Hans,
On Sun, Apr 21, 2024, at 11:45 AM, Hans de Goede wrote:
> Factor out the adaptive kbd non hotkey event handling into
> adaptive_keyboard_change_row() and adaptive_keyboard_s_quickview_row()
> helpers and move the handling of TP_HKEY_EV_DFR_CHANGE_ROW and
> TP_HKEY_EV_DFR_S_QUICKVIEW_ROW t
Hi,
On 4/20/24 10:00 PM, Lukas Wunner wrote:
> Deduplicate sysfs ->show() callbacks which expose a string at a static
> memory location. Use the newly introduced device_show_string() helper
> in the driver core instead by declaring those sysfs attributes with
> DEVICE_STRING_ATTR_RO().
>
> No fu
On Mon, Apr 22, 2024 at 11:29 AM Ilpo Järvinen
wrote:
> On Sun, 21 Apr 2024, Hans de Goede wrote:
...
> > + int mode = adaptive_keyboard_get_mode();
> > +
> > + if (mode < 0)
>
> Please try to keep call and it's error handling together, it costs one
> line but takes less effort to unders
On Mon, Apr 22, 2024 at 11:07 AM Ilpo Järvinen
wrote:
> On Sun, 21 Apr 2024, Hans de Goede wrote:
>
> > send_acpi_ev, ignore_acpi_ev are already initialized to true resp. false by
>
> Wording here is odd (but I'm not native so could be I just don't
> understand what "true resp. false" is supposed
