Some new Thinkpad has a mute button with led. This mute led can out-of-sync
with mute in user interface. This kernel parameter disables the hardware
mute and led to avoid confusion. The hotkey will only issue scancode to UI.
Signed-off-by: Alex Hung
---
drivers/platform/x86/thinkpad_acpi.c | 14
Newer Thinkpad models comes with a mute hotkey with a mute led. It also comes
with ACPI AML functions to control hardware mute + led. The patches add supports
to enable/disable and to change mute and its led via thinkpad-acpi.
Alex Hung (2):
thinkpad-acpi: add a kernel parameter to disable
Newer thinkpad models have a mute hotkey with a led to indicate
current mute states. Thinkpad BIOS provides ACPI interfaces for
getting and changing the hardware mute along with the led.
Signed-off-by: Alex Hung
---
drivers/platform/x86/thinkpad_acpi.c | 89
Added in David and Tim who also has some ideas to share.
On Wed, Aug 14, 2013 at 3:00 PM, Matthew Garrett
wrote:
> On Wed, 2013-08-14 at 14:41 +0800, Alex Hung wrote:
>> Hi Matthew,
>>
>> The problem is that thinkpad-acpi does not aware of mute is changed by
>>
Hi Mattew,
That sounds good. I will work on it.
Cheers,
Alex Hung
On Wed, Aug 14, 2013 at 3:00 PM, Matthew Garrett wrote:
> On Wed, 2013-08-14 at 14:41 +0800, Alex Hung wrote:
> > Hi Matthew,
> >
> > The problem is that thinkpad-acpi does not aware of mute is changed
Hi Matthew,
The problem is that thinkpad-acpi does not aware of mute is changed by
either hotkey presses or in desktop.
I believe Lenovo has an application to handle it Windows in similar ways,
and the design makes controlling by user-applications more feasible.
Cheers,
Alex Hung
On Wed, Aug
good idea. I will develop another patch.
Cheers,
Alex Hung
On Wed, Aug 14, 2013 at 1:42 PM, Matthew Garrett wrote:
> On Wed, 2013-08-14 at 13:40 +0800, Alex Hung wrote:
> > Newer Thinkpad models comes with a mute hotkey with a mute led. It also
> comes
> > with ACPI AML fu
On Wed, Aug 14, 2013 at 2:11 PM, Alex Hung wrote:
> We are seeing bugs that mute led is out-of-sync with OS's mute.
> Steps to duplicate:
> 1. Press mute hotkey - it generates scancode and turns on mute led
> 2. Unmute by desktop application.
>
> Expected result: System
ussed, but it will
need to have the sysfs nodes for mute/led controls.
On Wed, Aug 14, 2013 at 1:54 PM, Matthew Garrett wrote:
> On Wed, 2013-08-14 at 13:53 +0800, Alex Hung wrote:
> > Hi Matthew,
> >
> >
> > The scenario will be to have an user-application to listen to
Newer thinkpad models have a mute hotkey with a led to indicate
current mute states. Thinkpad BIOS provides ACPI interfaces for
getting and changing the hardware mute along with the led.
Signed-off-by: Alex Hung
---
drivers/platform/x86/thinkpad_acpi.c | 50
Newer Thinkpad models comes with a mute hotkey with a mute led. It also comes
with ACPI AML functions to control hardware mute + led. The patches add sysfs
nodes so it is possible to enable, disable and control from user-space.
Alex Hung (2):
thinkpad-acpi: add sysfs for getting and setting
user changes mute state by user application.
This patch gives a chance to disable hardware mute.
Signed-off-by: Alex Hung
---
drivers/platform/x86/thinkpad_acpi.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform
New thinkpad introduces new BIOS interfaces (aml methods) to control
hardware mute and its led. The patch checks whether new new methods
are present and provides new sysfs nodes to interfact with BIOS
aml methods.
Signed-off-by: Alex Hung
---
drivers/platform/x86/thinkpad_acpi.c | 113
ces only when the hardware is present. I have a x200 that
has no mute led, and I will also test patches on it to make sure the
original function does not break.
Thanks for highlighting the information to me. I will remember to check
systems with two different designs.
Best Regards,
Alex Hu
one including myself works out a more
comprehensive solution.
Best Regards,
Alex Hung
On 04/11/2012 07:42 PM, Henrique de Moraes Holschuh wrote:
> On Wed, 11 Apr 2012, Alex Hung wrote:
>> I am modifying thinkpad_acpi so it can support the mute led, and I
>> am looking for suggest
On 04/24/2012 04:40 PM, Alex Hung wrote:
> The tp_features.bright_acpimode will not be set correctly for brightness
> control because ACPI_VIDEO_HID will not be located in ACPI. As a result,
> a duplicated key event will always be sent. acpi_video_backlight_support()
> is sufficie
: Alex Hung
---
drivers/platform/x86/thinkpad_acpi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 7b82868..7d032d5 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86
cpi_lifecycle != TPACPI_LIFE_INIT)*.
3. However, the changes now will changes the original behaviors (i.e.
"up", "down" and so on) if BIOS supports new SSMS and SHDA methods.
Any feedbacks and suggestions are most appreciated.
Best Regards,
Alex Hung
On 04/11/2012 06:15 PM, Alex
Signed-off-by: Alex Hung
---
drivers/platform/x86/thinkpad_acpi.c | 115 +++---
1 files changed, 106 insertions(+), 9 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 7b82868..dc22a4c 100644
--- a/drivers
19 matches
Mail list logo
