Re: [ibm-acpi-devel] [PATCH] video: backlight: Remove backlight sysfs uevent

2013-12-16 Thread Andrew Morton
On Sun, 24 Nov 2013 01:53:11 -0200 Henrique de Moraes Holschuh wrote: > On Sun, 24 Nov 2013, Matthew Garrett wrote: > > On Sat, Nov 23, 2013 at 10:40:15PM -0200, Henrique de Moraes Holschuh wrote: > > > On Fri, 22 Nov 2013, Matthew Garrett wrote: > > > > We have userspace that relies on uevents

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: fix potential suspend blocking issue

2013-03-05 Thread Andrew Morton
On Tue, 5 Mar 2013 09:34:43 -0800 Mandeep Singh Baines wrote: > Fixes the following lockdep error: > > [ BUG: ktpacpi_nvramd/446 still has locks held! ] > > hotkey_kthread() calls set_freezable() after acquiring the > hotkey_kthread_mutex(). set_freezable() calls try_to_freeze(). > This could

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: moved hotkey_thread_mutex lock after set_freezable()

2013-02-25 Thread Andrew Morton
On Sun, 24 Feb 2013 13:22:02 +0400 Artem Savkov wrote: > set_freezable() checks freezing during which no locks should be held. > hotkey_thread_mutex lock should be moved closer to where it is actually > needed. > Thanks. When fixing a bug, we always like to see a full description of that bug

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: setup hotkey polling after changing hotkey_driver_mask

2010-02-08 Thread Andrew Morton
On Mon, 8 Feb 2010 22:08:10 -0200 Thadeu Lima de Souza Cascardo wrote: > > ... > > > --- > > a/drivers/platform/x86/thinkpad_acpi.c~thinkpad-acpi-setup-hotkey-polling-after-changing-hotkey_driver_mask-fix > > +++ a/drivers/platform/x86/thinkpad_acpi.c > > @@ -2597,6 +2597,10 @@ static void hotke

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: setup hotkey polling after changing hotkey_driver_mask

2010-02-08 Thread Andrew Morton
On Sun, 7 Feb 2010 16:32:07 -0200 Thadeu Lima de Souza Cascardo wrote: > Brightness notification does not work until the user writes to > hotkey_mask attribute. That's because the polling thread will only run > if hotkey_user_mask is set and someone is reading the input device or if > hotkey_dri