Re: [ibm-acpi-devel] [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys

2015-02-27 Thread Andy Lutomirski
On Mon, Feb 23, 2015 at 2:09 AM, Bastien Nocera wrote: > On Fri, 2015-02-20 at 11:27 -0800, Andy Lutomirski wrote: >> On 02/20/2015 06:44 AM, Bastien Nocera wrote: >> > + KEY_MICCANCEL_MODE, /* Microphone cancellation */ >> >> What's this? We

Re: [ibm-acpi-devel] [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys

2015-02-27 Thread Andy Lutomirski
On 02/20/2015 06:44 AM, Bastien Nocera wrote: > + KEY_MICCANCEL_MODE, /* Microphone cancellation */ What's this? We already have KEY_MICMUTE. Is this different? If so, can you improve the comment a bit? The answer may be obvious to anyone who has an awful X1 carbon gen 2 keyboar

Re: [ibm-acpi-devel] [PATCH 1/2] thinkpad-acpi: Try to use full software mute control

2014-11-23 Thread Andy Lutomirski
On Thu, Oct 16, 2014 at 11:54 AM, Henrique de Moraes Holschuh wrote: > On Thu, 16 Oct 2014, Andy Lutomirski wrote: >> > On IBM ThinkPads, the "generates KEY_foo" thing is controlable by the >> > driver. In fact, thinkpad_acpi defaults to NOT send these, all breakag

[ibm-acpi-devel] [PATCH] thinkpad-acpi: Enable microphone mute LED

2011-05-24 Thread Andy Lutomirski
I don't know exactly which models have this LED or how to identify them in the quirk table, so I just enabled it for all unquirked Lenovo models. Signed-off-by: Andy Lutomirski --- drivers/platform/x86/thinkpad_acpi.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --

[ibm-acpi-devel] [PATCH] Add KEY_MICMUTE and enable it on Lenovo X220

2011-05-24 Thread Andy Lutomirski
I suspect that this works on T410. Signed-off-by: Andy Lutomirski --- The Lenovo X220, T410, and probably other models have a "mute the microphone" button with a little picture of a crossed-out microphone on it. I'm not sure what the protocol for new buttons is, and we're

[ibm-acpi-devel] [PATCH] Remove ThinkPads from _OSI(Linux) blacklist

2011-05-23 Thread Andy Lutomirski
Now that thinkpad-acpi knows how to program the hardware mute button on recent ThinkPads, the _OSI(Linux) hack is unnecessary. Signed-off-by: Andy Lutomirski --- I don't have all of these machines to test, but at least the X220 and X200s don't need the blacklist anymore if the thi

[ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2011-05-19 Thread Andy Lutomirski
From: Andy Lutomirski ThinkPads have hardware volume controls and three buttons to control them. (These are separate from the standard mixer.) By default, the buttons are: - Mute: Mutes the hardware volume control and generates KEY_MUTE. - Up: Unmutes, generates KEY_VOLUMEUP, and increases

[ibm-acpi-devel] [PATCH v4] thinkpad-acpi: Improve hardware volume controls

2011-05-16 Thread Andy Lutomirski
hardware mute control doesn't generate an ALSA change notification on newer ThinkPads. Signed-off-by: Andy Lutomirski --- Changes from v3: - Emulate autocontrol instead of letting firmware do it. This is much better behaved on X200s and on X220 it lets us turn off typematic repeat of th

[ibm-acpi-devel] [PATCH v3] thinkpad-acpi: Improve hardware volume controls

2011-05-14 Thread Andy Lutomirski
mode through sysfs, and we don't generate KEY_MUTE in any mode other than "none". As an added bonus, we fix an old bug: the hardware mute control doesn't generate an ALSA change notification on newer ThinkPads. Signed-off-by: Andy Lutomirski --- Dmitry- This would IMO be p

[ibm-acpi-devel] [PATCH v2] thinkpad-acpi: Improve hardware volume controls

2011-05-10 Thread Andy Lutomirski
volume* control instead of just mute, I suspect. I don't own any such machines, though.) Signed-off-by: Andy Lutomirski --- Changes from v1: - Read HAUM on startup, which gives the correct default (toggle) on X220 and should preserve the "none" behavior on systems that set

[ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-09 Thread Andy Lutomirski
LSA change notification on newer ThinkPads. (If the ACPI method to control the mode isn't available or if the laptop has hardware *volume*, then we preserve the old behavior. The latter is because I don't have a machine to test on.) Signed-off-by: Andy Lutomirski --- This wants testing on

[ibm-acpi-devel] [PATCH] thinkpad-acpi: module autoloading for newer Lenovo ThinkPads.

2011-05-08 Thread Andy Lutomirski
...@kernel.org Signed-off-by: Manoj Iyer Signed-off-by: Andy Lutomirski --- Hi, mjg- Can you add this to your tree for 2.6.39 (or 2.6.40 if you think it's too late for a missing device ID)? This is needed on a bunch of new ThinkPad laptops (including mine). Henrique asked me to forward my pat

[ibm-acpi-devel] [PATCH] thinkpad_acpi: Add ACPI HID for ThinkPad X220

2011-05-08 Thread Andy Lutomirski
It looks like Lenovo is starting to remove old IBM references. Signed-off-by: Andy Lutomirski --- This patch is needed for thinkpad_acpi to load automatically on my ThinkPad X220. (It seems to *work* without the patch, though.) drivers/platform/x86/thinkpad_acpi.c |2 ++ 1 files changed