Re: [ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: add adaptive_kbd_modes parameter

2018-11-25 Thread Bjørn Mork
Eric Wong writes: > Bjørn Mork wrote: > >> And then I believe you have a busy loop here: >> >> > @@ -3815,20 +3838,20 @@ static int adaptive_keyboard_set_mode(int new_mode) >> > >> > static int adaptive_keyboard_get_next_mode(int mode) >

Re: [ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: add adaptive_kbd_modes parameter

2018-11-25 Thread Bjørn Mork
Eric Wong writes: > Eric Wong wrote: >> The above setting with this change and the following keymap >> preserves my sanity on the atrocious adaptive keyboard on >> the 2nd-gen X1 Carbon: > > Any comments on this patch? The Esc and F-keys on the keyboard > are still numb and I'll be getting rid o

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: support HKEY interface version 0x200

2016-04-19 Thread Bjørn Mork
Bastien Nocera writes: > From: Shuduo Sang > > The Thinkpad X1 Carbon 2nd generation (2014) ships with BIOS that will > return HKEY interface version 0x200. It needs thinkpad-acpi support > otherwise it will be routed to wrong branch and the hotkey mask will > be wrong. > > https://bugzilla.kern

Re: [ibm-acpi-devel] [ltp] Thinkpad keyboard backlight ACPI interface

2015-07-28 Thread Bjørn Mork
Pali Rohár writes: > Yes and for that I need output from as many Thinkpad machines, so I can > do some "statistic" output. Would love to help, but neither my ancient X301 nor my newer T420s have the MLCG and MLCS methods. Which makes sense, as they don't have backlit keyboards either... Bjør

Re: [ibm-acpi-devel] [ltp] Thinkpad keyboard backlight ACPI interface

2015-07-28 Thread Bjørn Mork
Pali Rohár writes: > On Tuesday 28 July 2015 13:17:58 Bjørn Mork wrote: >> Pali Rohár writes: >> >> > I would like to write kernel patch for thinkpad_acpi.c to support >> > keyboard backlight (like other modules in drivers/platform/x86/ tree), >> &

Re: [ibm-acpi-devel] [ltp] Thinkpad keyboard backlight ACPI interface

2015-07-28 Thread Bjørn Mork
Pali Rohár writes: > I would like to write kernel patch for thinkpad_acpi.c to support > keyboard backlight (like other modules in drivers/platform/x86/ tree), > but last missing information is how to detect current level of > brightness and check if backlight is supported... Based on the cod

[ibm-acpi-devel] [PATCH v2] thinkpad_acpi: revert unintentional device attribute renaming

2015-05-19 Thread Bjørn Mork
;) Cc: Bastien Nocera Cc: Henrique de Moraes Holschuh Signed-off-by: Bjørn Mork --- v2: kept the original function names, using the DEVICE_ATTR instead drivers/platform/x86/thinkpad_acpi.c | 37 ++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --g

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: revert unintentional device attribute renaming

2015-05-19 Thread Bjørn Mork
Henrique de Moraes Holschuh writes: > On Tue, May 19, 2015, at 11:13, Bjørn Mork wrote: >> The conversion to DEVICE_ATTR_* macros failed to fixup a few cases where >> the old attribute names didn't match the show/store function names. >> Instead of renaming the func

[ibm-acpi-devel] [PATCH] thinkpad_acpi: revert unintentional device attribute renaming

2015-05-19 Thread Bjørn Mork
were among the renamed attribute, causing libsensors to fail to detect the hwmon device at all. Fixes: b4dd04ac6ef8 ("thinkpad_acpi: use DEVICE_ATTR_* macros") Cc: Bastien Nocera Cc: Henrique de Moraes Holschuh Signed-off-by: Bjørn Mork --- drivers/platform

Re: [ibm-acpi-devel] [RFC PATCH] support Thinkpad X1 Carbon's adaptive keyboard

2014-03-03 Thread Bjørn Mork
Shuduo Sang writes: > Hi all, > > We are working together with Lenovo to enable thinkpad X1 Carbon's > fancy feature, Adaptive Keyboard[1] for Linux. Adaptive keyboard has > five modes on Windows including Home mode, Web browser mode, Web > conference mode, Function mode and Lay-flat mode. We ena

Re: [ibm-acpi-devel] ThinkPad T420 : 8 versus 16 brightness level steps

2014-02-28 Thread Bjørn Mork
Toralf Förster writes: > /'m wondering why under a 64 bit RedHat 6.4 Linux with kernel 2.6.32+X > I do have 16 levels in dimming the display brightness with Fn+Pos1/End > whereas under a 32 bit Gentoo Linux with recent 3.1x.y kernels I do > just have 8 steps from min to max. My guess would be th

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad_acpi: Add support for controlling charge thresholds

2013-11-05 Thread Bjørn Mork
Julian Andres Klode writes: > > +TPACPI_HANDLE(battery, root, "\\_SB.PCI0.LPC.EC.HKEY", > +"\\_SB.PCI0.LPCB.EC.HKEY", /* X121e, T430u */ > +"\\_SB.PCI0.LPCB.H_EC.HKEY", /* L430 */ > +"\\_SB.PCI0.LPCB.EC0.HKEY", /* Edge/S series */ > +);

Re: [ibm-acpi-devel] [PATCH 1/3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-20 Thread Bjørn Mork
Adam Lee writes: > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -5401,9 +5401,12 @@ static int led_write(char *buf) > return -ENODEV; > > while ((cmd = next_cmd(&buf))) { > - if (sscanf(cmd, "%d", &led) != 1 || led

Re: [ibm-acpi-devel] Patch for thinkpad-acpi.c

2013-06-20 Thread Bjørn Mork
Bruce writes: > +struct blacklist lenovo_blacklist[] = { > + { > +.model_s = "Lenovo LM490s", > +.nummodel_s = "814YG01", > + }, The driver already has a list of LED support per model in the static const struct tpacpi_quirk led_useful_qtable[] __initconst = {} array. Why do you