[ibm-acpi-devel] [PATCH 08/11] driver: thinkpad_acpi: replace printk with pr_debug

2014-05-09 Thread Konrad Zapalowicz
This commit fixes the "Prefer [subsystem eg: netdev]_dbg([subsystem] dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG" checkpath warning. Signed-off-by: Konrad Zapalowicz --- drivers/platform/x86/thinkpad_acpi.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[ibm-acpi-devel] [PATCH 04/11] driver: thinkpad_acpi: replace seq_printf with seq_puts

2014-05-09 Thread Konrad Zapalowicz
This commit fixes the "Prefer seq_puts to seq_printf" checkpath warning plus it also fixes a few occurences of this issue not noticed by the script. Signed-off-by: Konrad Zapalowicz --- drivers/platform/x86/thinkpad_acpi.c | 84 ++-- 1 file changed, 42

[ibm-acpi-devel] [PATCH 07/11] driver: thinkpad_acpi: remove not necessary {} braces

2014-05-09 Thread Konrad Zapalowicz
This commit fixes the "braces {} are not necessary for any arm of this statement" checkpatch warning. Signed-off-by: Konrad Zapalowicz --- drivers/platform/x86/thinkpad_acpi.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/pl

[ibm-acpi-devel] [PATCH 09/11] driver: thinkpad_acpi: replace simple_strtoul with kstrtoul

2014-05-09 Thread Konrad Zapalowicz
This commit fixes the "simple_strtoul is obsolete, use kstrtoul instead" checkpatch warning. Signed-off-by: Konrad Zapalowicz --- drivers/platform/x86/thinkpad_acpi.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/thinkpad

[ibm-acpi-devel] [PATCH 06/11] driver: thinkpad_acpi: remove unnecessary spaces

2014-05-09 Thread Konrad Zapalowicz
This commit fixes the "Unnecessary space before function pointer arguments" checkpatch warnings. Signed-off-by: Konrad Zapalowicz --- drivers/platform/x86/thinkpad_acpi.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/platform/x86/thinkpad

[ibm-acpi-devel] [PATCH 00/11] driver: thikpad_acpi: deal with checkpatch issues

2014-05-09 Thread Konrad Zapalowicz
carefully. The linux-next tree (36efbdf) has been used as a base for this work. Konrad Zapalowicz (11): driver: thinkpad_acpi: add spaces around ? driver: thinkpad_acpi: add parenthesis around complex macro driver: thinkpad_acpi: fix minor checkpatch errors driver: thinkpad_acpi: r

[ibm-acpi-devel] [PATCH 02/11] driver: thinkpad_acpi: add parenthesis around complex macro

2014-05-09 Thread Konrad Zapalowicz
This commit fixes the "Macros with complex values should be enclosed in parenthesis" checkpatch error. Signed-off-by: Konrad Zapalowicz --- drivers/platform/x86/thinkpad_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c

[ibm-acpi-devel] [PATCH 01/11] driver: thinkpad_acpi: add spaces around ?

2014-05-09 Thread Konrad Zapalowicz
This commit fixes the "spaces required around that '?' (ctx:VxW)" checkpatch errors in ./drivers/platform/x86/thinkpad_acpi.c file Signed-off-by: Konrad Zapalowicz --- drivers/platform/x86/thinkpad_acpi.c | 42 ++-- 1 file changed, 21 inserti

[ibm-acpi-devel] [PATCH 05/11] driver: thinkpad_acpi: add blank line after declaration

2014-05-09 Thread Konrad Zapalowicz
This commit fixes the "Missing a blank line after declarations" checkpatch warning. Signed-off-by: Konrad Zapalowicz --- drivers/platform/x86/thinkpad_acpi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/think

[ibm-acpi-devel] [PATCH 10/11] driver: thinkpad_acpi: fix minor checkpatch warnings

2014-05-09 Thread Konrad Zapalowicz
This commit fixes the following checkpatch warnings: - Use #include instead of - __packed is preferred over __attribute__((packed)) - static const char * array should probably be static const char * const Signed-off-by: Konrad Zapalowicz --- drivers/platform/x86

[ibm-acpi-devel] [PATCH 03/11] driver: thinkpad_acpi: fix minor checkpatch errors

2014-05-09 Thread Konrad Zapalowicz
This commit fixes the following checkpatch errors: - inline keyword should sit between storage class and type - "foo* const bar" should be "foo * const bar" Signed-off-by: Konrad Zapalowicz --- drivers/platform/x86/thinkpad_acpi.c | 4 ++-- 1 file changed, 2 insert

[ibm-acpi-devel] [PATCH 11/11] driver: thinkpad_acpi: remove spaces at the beginning

2014-05-09 Thread Konrad Zapalowicz
This commit fixes the "please, no spaces at the start of a line" checkpatch warning. Signed-off-by: Konrad Zapalowicz --- drivers/platform/x86/thinkpad_acpi.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/platform/x86/thinkpad