Some answers/comments down below
On Fri, 2022-04-29 at 21:25 -0400, Mark Pearson wrote:
> Hi Lyude
>
> On 4/29/22 17:14, Lyude Paul wrote:
> > The new method of probing dual fan support introduced in:
> >
> > bf779aaf56ea ("platform/x86: thinkpad_acpi: Add dual
Some recent changes broke detection of the second fan on the X1 Carbon
9th generation, so here's some patches to fix it.
Lyude Paul (2):
platform/x86: thinkpad_acpi: Restore X1 Carbon 9th Gen dual fan quirk
platform/x86: thinkpad_acpi: Don't probe 2nd fan if enabled by quirk
nto a single group of if/else
statements. This is because there's no situations where there's more then
one quirk on a device.
Signed-off-by: Lyude Paul
Fixes: bf779aaf56ea ("platform/x86: thinkpad_acpi: Add dual fan probe")
Cc: Mark Pearson
Cc: Hans de Goede
Cc: Henrique de
re this machine powers on quite often without either of the
two fans spinning.
So let's fix this by adding back the dual fan quirk for the X1 Carbon 9th
Gen.
Signed-off-by: Lyude Paul
Fixes: bf779aaf56ea ("platform/x86: thinkpad_acpi: Add dual fan probe")
Cc: Mark Pearson
Cc:
lgtm.
Reviewed-by: Lyude Paul
On Tue, 2017-11-14 at 17:14 +0100, Benjamin Berg wrote:
> On the X1 Yoga 2nd Generation and most likely other notebooks the FLAT
> mode is reported. Decode it correctly rather than warning about an
> unexpected multi mode status to be reported.
>
>
Looks good to me
Reviewed-by: Lyude Paul
On Tue, 2017-10-10 at 11:12 +0200, Benjamin Berg wrote:
> Many thinkpad laptops and convertibles provide the GMMS method to
> resolve how far the laptop has been opened and whether it has been
> converted into tablet mode. This allows reporti
Reviewed-by: Lyude Paul
On Fri, 2017-09-15 at 15:20 +0200, Benjamin Berg wrote:
> Many thinkpad laptops and convertibles provide the GMMS method to
> resolve how far the laptop has been opened and whether it has been
> converted into tablet mode. This allows reporting a more preci
Signed-off-by: Lyude
---
So HOPEFULLY I actually did this right. There was some discussion here
previously about supporting this, and it was previously mentioned that the IOST
method was responsible for holding the current tablet status. However, it
really doesn't seem like this is the ca
of
tablet mode reporting the machine supports.
Suggested by Daniel Martin
Signed-off-by: Lyude
Cc: Daniel Martin
Acked-by: Henrique de Moraes Holschuh
---
Changes since v3:
- Fix style nitpick
drivers/platform/x86/thinkpad_acpi.c | 52 +---
1 file changed
Tested-by: Daniel Martin
Signed-off-by: Lyude
---
Changes since v4:
- Get rid of patch #2
- Add BIOS model
- Update documentation
Documentation/laptops/thinkpad-acpi.txt | 1 +
drivers/platform/x86/thinkpad_acpi.c| 39 +
2 files changed, 36 insert
of
tablet mode reporting the machine supports.
Suggested by Daniel Martin
Signed-off-by: Lyude
Cc: Daniel Martin
---
Changes since v1:
- Don't use bool for in_tablet_mode (fixes complaints from kbuild test
robot)
Changes since v2:
- Move changes out of git message
- Fix commit message
- F
Cc: Daniel Martin
Signed-off-by: Lyude
---
Changes since v1:
- Clarify kernel output when finding the tablet mode switch
Changes since v2:
- Rebase on top of previous patch
- Use an enum for hotkey_tablet. This does make a bit more sense then
just adding another fl
There's no need to have multiple copies of the logic we use for checking
whether or not we're in tablet mode, so just use
hotkey_get_tablet_mode() when checking the initial state in
hotkey_init_tablet_mode().
Cc: Daniel Martin
Signed-off-by: Lyude
---
drivers/platform/x86/thinkpad_
of
tablet mode reporting the machine supports.
Suggested by Daniel Martin
Signed-off-by: Lyude
Cc: Daniel Martin
Signed-off-by: Lyude
---
Changes since v1:
- Don't use bool for in_tablet_mode (fixes complaints from kbuild test
robot)
Changes since v2:
- Move changes out of git message
Got in touch with a friend who happened to have a X201 and had them
test the patches, so I've confirmed this doesn't break anything with
older ThinkPad tablets.
On Mon, 2016-10-31 at 18:55 -0400, Lyude wrote:
> Updated patchset for adding support for detecting tablet mode on the
>
ode reporting the machine supports.
Changes since v1:
- Don't use bool for in_tablet_mode (fixes complaints from kbuild test
robot)
Signed-off-by: Lyude
Cc: Daniel Martin
---
drivers/platform/x86/thinkpad_acpi.c | 50 +++-
1 file changed, 38 insertions(+),
event.
Cc: Daniel Martin
Signed-off-by: Lyude
---
drivers/platform/x86/thinkpad_acpi.c | 37
1 file changed, 33 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 92e8986..4df4153 10
There's no need to have multiple copies of the logic we use for checking
whether or not we're in tablet mode, so just use
hotkey_get_tablet_mode() when checking the initial state in
hotkey_init_tablet_mode().
Cc: Daniel Martin
Signed-off-by: Lyude
---
drivers/platform/x86/thinkpad_
,
otherwise I'll test it out when I get to the office on Thursday.
Signed-off-by: Lyude
Cc: Daniel Martin
Lyude (3):
thinkpad_acpi: Move tablet detection into separate function
thinkpad_acpi: Don't repeat ourselves in hotkey_init_tablet_mode()
thinkpad_acpi: Add support for X1 Yoga (20
ode reporting the machine supports.
Signed-off-by: Lyude
Cc: Daniel Martin
---
drivers/platform/x86/thinkpad_acpi.c | 50 +++-
1 file changed, 38 insertions(+), 12 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thin
.
Changes since v1:
- Clarify kernel output when finding the tablet mode switch
Signed-off-by: Lyude
---
drivers/platform/x86/thinkpad_acpi.c | 36 +---
1 file changed, 33 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/pl
Signed-off-by: Lyude
---
(Resending since I just confirmed this didn't make it to the mailing list the
first time.)
So HOPEFULLY I actually did this right. There was some discussion here
previously about supporting this, and it was previously mentioned that the IOST
method was responsible
as well, can someone confirm this patch made it to the ibm-acpi-devel
list? When I originally sent this I realized I wasn't subscribed to the
list, so I'm guessing I might need to resend.
On Tue, 2016-10-25 at 18:12 -0400, Lyude wrote:
> For whatever reason, the X1 Yoga doesn't
). Passing parameter value 2 to
MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in
that case there is no adaptive keyboard available.
Signed-off-by: Dennis Wassenberg
Signed-off-by: Lyude
Tested-by: Lyude
Tested-by: Marco Trevisan
Acked-by: Henrique de Moraes Holschuh
Managed to find someone in the office with one of these laptops and it looks
like the adaptive keyboard works perfectly with this patch, so I can give my t-
b:
Tested-by: Lyude Paul
Cheers,
Lyude
On Tue, 2016-06-07 at 13:02 -0400, Lyude Paul wrote:
> Since nothing'
gt; + * MHKV 0x200 in X1, T460s, X260, T560, X1 Tablet (2016)
> + */
> +
> + /* Paranoia check AND init hotkey_all_mask */
> + if (!acpi_evalf(hkey_handle, &hot
with getting this merged? I've
got a few laptops with this (T560, T460s, P50, and if I look hard
enough a X260) and the capability to do any testing needed for this to
get merged upstream.
--
Cheers,
Lyude
Desktop Engineer
emember to
> unplug the display when (re)booting.
>
> regards,
> Jol.
>
Hello! Again, I'm one of those guys :). I'd type a response here but I
already typed one just a minute ago, so I'll link you to that. There's
an explanation of the issue and a couple solutions
emember to
> unplug the display when (re)booting.
>
> regards,
> Jol.
>
Hello! Again, I'm one of those guys :). I'd type a response here but I
already typed one just a minute ago, so I'll link you to that. There's
an explanation of the issue and a couple solutions
pecify
an acpi OSI is generally considered a bug (ACPI should be the same
across operating systems).
The original bug discussing this issue can be found here:
https://bugzilla.kernel.org/show_bug.cgi?id=51231 let me know if you
have any questions.
Cheers,
Lyude
signature.asc
Description:
30 matches
Mail list logo
