Some answers/comments down below
On Fri, 2022-04-29 at 21:25 -0400, Mark Pearson wrote:
> Hi Lyude
>
> On 4/29/22 17:14, Lyude Paul wrote:
> > The new method of probing dual fan support introduced in:
> >
> > bf779aaf56ea ("platform/x86: thinkpad_acpi: Add dual
Some recent changes broke detection of the second fan on the X1 Carbon
9th generation, so here's some patches to fix it.
Lyude Paul (2):
platform/x86: thinkpad_acpi: Restore X1 Carbon 9th Gen dual fan quirk
platform/x86: thinkpad_acpi: Don't probe 2nd fan if enabled by quirk
nto a single group of if/else
statements. This is because there's no situations where there's more then
one quirk on a device.
Signed-off-by: Lyude Paul
Fixes: bf779aaf56ea ("platform/x86: thinkpad_acpi: Add dual fan probe")
Cc: Mark Pearson
Cc: Hans de Goede
Cc: Henrique de
re this machine powers on quite often without either of the
two fans spinning.
So let's fix this by adding back the dual fan quirk for the X1 Carbon 9th
Gen.
Signed-off-by: Lyude Paul
Fixes: bf779aaf56ea ("platform/x86: thinkpad_acpi: Add dual fan probe")
Cc: Mark Pearson
Cc:
lgtm.
Reviewed-by: Lyude Paul
On Tue, 2017-11-14 at 17:14 +0100, Benjamin Berg wrote:
> On the X1 Yoga 2nd Generation and most likely other notebooks the FLAT
> mode is reported. Decode it correctly rather than warning about an
> unexpected multi mode status to be reported.
>
>
Looks good to me
Reviewed-by: Lyude Paul
On Tue, 2017-10-10 at 11:12 +0200, Benjamin Berg wrote:
> Many thinkpad laptops and convertibles provide the GMMS method to
> resolve how far the laptop has been opened and whether it has been
> converted into tablet mode. This allows reporti
Reviewed-by: Lyude Paul
On Fri, 2017-09-15 at 15:20 +0200, Benjamin Berg wrote:
> Many thinkpad laptops and convertibles provide the GMMS method to
> resolve how far the laptop has been opened and whether it has been
> converted into tablet mode. This allows reporting a more preci
Got in touch with a friend who happened to have a X201 and had them
test the patches, so I've confirmed this doesn't break anything with
older ThinkPad tablets.
On Mon, 2016-10-31 at 18:55 -0400, Lyude wrote:
> Updated patchset for adding support for detecting tablet mode on the
> X1 Yoga
> 2016 m
as well, can someone confirm this patch made it to the ibm-acpi-devel
list? When I originally sent this I realized I wasn't subscribed to the
list, so I'm guessing I might need to resend.
On Tue, 2016-10-25 at 18:12 -0400, Lyude wrote:
> For whatever reason, the X1 Yoga doesn't support the normal
Managed to find someone in the office with one of these laptops and it looks
like the adaptive keyboard works perfectly with this patch, so I can give my t-
b:
Tested-by: Lyude Paul
Cheers,
Lyude
On Tue, 2016-06-07 at 13:02 -0400, Lyude Paul wrote:
> Since nothing'
Since nothing's really happened with this patch for a while I figured I'd take
over trying to get this upstream.
Regarding testing: This seems to work fine on the 60 series laptops, and works
fine on previous generations. The one thing I haven't been able to test is an X1
carbon with an adaptive k
11 matches
Mail list logo
