Re: [ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: fix kernel-doc warnings

Hi Mark, On 12/6/23 07:30, Mark Pearson wrote: > Hi Randy > > On Wed, Dec 6, 2023, at 1:01 AM, Randy Dunlap wrote: >> Add a function's return description and don't misuse "/**" for >> non-kernel-doc comments to prevent warnings from scripts/kernel-doc. >

[ibm-acpi-devel] [PATCH] platform/x86: thinkpad_acpi: fix kernel-doc warnings

ent starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst thinkpad_acpi.c:9307: warning: missing initial short description on line: * This evaluates a ACPI method call specific to the battery Signed-off-by: Randy Dunlap Cc: Henrique de Moraes Holschuh Cc: Hans de Goede

[ibm-acpi-devel] [PATCH] Documentation: laptops: thinkpad-acpi: fix underline length build warning

From: Randy Dunlap Fix underline length build warning in thinkpad-acpi.rst documentation: Documentation/admin-guide/laptops/thinkpad-acpi.rst:1437: WARNING: Title underline too short. DYTC Lapmode sensor -- Fixes: acf7f4a59114 ("platform/x86: thinkpad_acpi: lap or desk

Re: [ibm-acpi-devel] [PATCH v2] Input: document inhibiting

lose() > +means for the device in question, not opening() it before going to sleep > might make it > +impossible to provide any wakeup events. The device is going to sleep anyway. > + > Basic event types > ~ > > Reviewed-by: Randy Dunlap Thanks. -- ~Randy ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

Re: [ibm-acpi-devel] [PATCH] Input: document inhibiting

On 6/16/20 10:29 AM, Andrzej Pietrasiewicz wrote: > Document inhibiting input devices and its relation to being > a wakeup source. > > Signed-off-by: Andrzej Pietrasiewicz > --- Hi, I have some editorial comments. Please see below. > @Hans, @Dmitry, > > My fist attempt at documenting

Re: [ibm-acpi-devel] [PATCH 0/1] Use checkpatch.pl to make thinkpad_acpi.c error free: octal permissions

On 11/14/2017 03:14 PM, Simranjit Singh wrote: > From: Simranjit Singh > > Using the checkpatch.pl script, there were 8 errors in thinkpad_acpi.c. I > fixed them by changing permissions to octal, > and by adding parenthesis. > On the current tree, if you use

Re: [ibm-acpi-devel] [Patch] thinkpad_acpi: fix a build error

On Mon, 21 Dec 2009 14:38:56 -0800 Marcel Holtmann wrote: Hi Henrique, The patch isn't correct (I guess the upstream fix is same?). CONFIG_SOUND is a global config for sound subsystem. The relevant functions are ALSA core part, which is CONFIG_SND. So, the fix should be:

Re: [ibm-acpi-devel] [PATCH 10/14] ACPI: thinkpad-acpi: use uppercase for LED on user documentation

Henrique de Moraes Holschuh wrote: Change all occourences of the led word to full uppercase in user documentation. Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED] Cc: Randy Dunlap [EMAIL PROTECTED] Thank you. Acked-by: Randy Dunlap [EMAIL PROTECTED] --- Documentation

Re: [ibm-acpi-devel] [PATCH 09/13] ACPI: thinkpad-acpi: add sysfs led class support to thinkpad leds (v3.1)

On Thu, 10 Apr 2008 00:53:01 -0300 Henrique de Moraes Holschuh wrote: Add a sysfs led class interface to the led subdriver. Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED] Cc: Richard Purdie [EMAIL PROTECTED] --- Documentation/laptops/thinkpad-acpi.txt | 47 +--

Re: [ibm-acpi-devel] [PATCH 08/13] ACPI: thinkpad-acpi: add sysfs led class support for thinklight (v3.1)

On Thu, 10 Apr 2008 00:53:00 -0300 Henrique de Moraes Holschuh wrote: Add a sysfs led class interface to the thinklight (light subdriver). Signed-off-by: Henrique de Moraes Holschuh [EMAIL PROTECTED] Cc: Richard Purdie [EMAIL PROTECTED] --- Documentation/laptops/thinkpad-acpi.txt | 25

Re: [ibm-acpi-devel] [PATCH 01/13] ACPI: thinkpad-acpi: BIOS backlight mode helper (v2)

On Thu, 10 Apr 2008 00:52:53 -0300 Henrique de Moraes Holschuh wrote: Documentation/laptops/thinkpad-acpi.txt | 49 +++ drivers/misc/thinkpad_acpi.c| 238 +-- 2 files changed, 182 insertions(+), 105 deletions(-) diff --git