Re: [ibm-acpi-devel] Duplicate key press events

2011-08-15 Thread Richard Hughes
On 7 August 2011 15:39, Henrique de Moraes Holschuh wrote: > If it is an EC bug or an ACPI firmware bug we cannot work around, we add an > event filter.  Otherwise, we can try to fix it in a better way. Right, makes sense. I'm back from the conference now, and apologies for the delay. > Ok.  Let

Re: [ibm-acpi-devel] Duplicate key press events

2011-08-07 Thread Richard Hughes
On 7 August 2011 13:30, Yves-Alexis Perez wrote: > Most non-geeky people use windows and have bios upgrade in thinkvantage, > I guess. Updating bios is *not* hard and Henrique said numerous time how > critical it was to have up to date ones. Point taken. I'll give the new BIOS a go when I get bac

Re: [ibm-acpi-devel] Duplicate key press events

2011-08-07 Thread Richard Hughes
On 5 August 2011 12:38, Henrique de Moraes Holschuh wrote: > Force it to zero on driver load (modprobe thinkpad_acpi > brightness_enable=0).  What does the driver says in dmesg/kernel log ? [ 5079.277852] thinkpad_acpi: ThinkPad ACPI Extras v0.24 [ 5079.277858] thinkpad_acpi: http://ibm-acpi.sf.n

Re: [ibm-acpi-devel] Duplicate key press events

2011-08-05 Thread Richard Hughes
On 5 August 2011 07:11, Yves-Alexis Perez wrote: > On jeu., 2011-08-04 at 22:30 +0100, Richard Hughes wrote: >> After talking to Matthew Garrett, he tells me the thinkpad-acpi driver >> event shouldn't be emitted if the computer has ACPI video support. >> > Chec

[ibm-acpi-devel] Duplicate key press events

2011-08-04 Thread Richard Hughes
When pressing the brightness up and brightness down buttons on my T510 I get two events per-keypress from X, with the exact same timestamp. After using evtest I get one event from "Video Bus" and another from "ThinkPad Extra Buttons": Event: time 1312492437.841546, type 4 (Misc), code 4 (ScanCode

Re: [ibm-acpi-devel] [ltp] Head's up: KEY_SLEEP/SUSPEND/HIBERNATE changes

2009-03-05 Thread Richard Hughes
On Wed, 2009-03-04 at 22:32 -0300, Henrique de Moraes Holschuh wrote: > so it depends on whatever userspace has been configured to do. Commenting further on this, all we're doing is standardising what the key with a specific decal emits to userspace. In your session policy you can quite easily map

Re: [ibm-acpi-devel] Collecting keymaps

2007-07-10 Thread Richard Hughes
On Tue, 2007-07-10 at 08:51 -0300, Henrique de Moraes Holschuh wrote: > > Please use the following page as a database, keep it up-to-date, and > it will > serve well both HAL and thinkpad-acpi needs ;-) Cool! I'll grab some data from the table and add it to the XML file. Thanks. I'll yell at peo

[ibm-acpi-devel] Collecting keymaps

2007-07-10 Thread Richard Hughes
ou can. The whole process is pretty straightforward, but please email me off list if you get stuck and I'll add more explanation where needed. With a little help, we can make Linux on a ThinkPad seriously rock. Thanks, Richard Hughes [1] http://people.freedesktop.org/~hughsient/quirk/ [2

Re: [ibm-acpi-devel] CALL FOR TESTING: thinkpad-acpi BETA release 0.14-20070708

2007-07-09 Thread Richard Hughes
On Sun, 2007-07-08 at 23:55 +, Darren Albers wrote: > Is there any chance we can see a patch for 2.6.22? I would love to test > this out. On a related note, what branch should I be using for the most bleeding edge version? input-hotkeys? Richard --

Re: [ibm-acpi-devel] thinkpad-acpi release 0.14-20070701 available in sf.net

2007-07-06 Thread Richard Hughes
On Thu, 2007-07-05 at 16:43 -0300, Henrique de Moraes Holschuh wrote: > On Thu, 05 Jul 2007, Richard Hughes wrote: > > On Wed, 2007-07-04 at 14:35 +0200, Timo Hoenig wrote: > > > Handling brightness events for ThinkPads is another story. The events > > > will reach u

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Richard Hughes
On Wed, 2007-07-04 at 23:26 -0300, Henrique de Moraes Holschuh wrote: > If it does nothing, that means the end of thinkpad-acpi brightness > support for these thinkpads. Your only hope will be that the standard > ACPI brightness interface works, or that someone reverse engineers > whichever new in

Re: [ibm-acpi-devel] thinkpad-acpi release 0.14-20070701 available in sf.net

2007-07-05 Thread Richard Hughes
On Wed, 2007-07-04 at 14:35 +0200, Timo Hoenig wrote: > Handling brightness events for ThinkPads is another story. The events > will reach user space but user space is not ought to do anything as they > are handled in hardware (c.f. [1]). But thinkpad-keys did not do > anything about this anyway.

Re: [ibm-acpi-devel] thinkpad-acpi release 0.14-20070701 available in sf.net

2007-07-03 Thread Richard Hughes
On Tue, 2007-07-03 at 09:43 -0300, Henrique de Moraes Holschuh wrote: > Still, his request is sane, and now that I am almost done implementing > what you guys asked for and two days away from submitting what is > already being tested to upstream, I'd appreciate if a friendly HAL > guru (hint! hint!

Re: [ibm-acpi-devel] thinkpad-acpi release 0.14-20070701 available in sf.net

2007-07-03 Thread Richard Hughes
On Tue, 2007-07-03 at 08:03 -0400, Theodore Tso wrote: > > Is there a wiki or FAQ or some other place that describes the > userspace configuration changes that I would have to make to say, an > Ubuntu/Feisty system such that it would be able deal with the new way > of dealing with the hot keys? I

Re: [ibm-acpi-devel] Hotkey events

2007-06-25 Thread Richard Hughes
On Mon, 2007-06-25 at 10:33 -0300, Henrique de Moraes Holschuh wrote: > I trust HAL can map switch edge events to launch scripts or > an application? If it does not, it needs to, now :-) Isn't NetworkManager going to handle this? Richard. --

Re: [ibm-acpi-devel] Hotkey events

2007-06-25 Thread Richard Hughes
On Sun, 2007-06-24 at 10:46 -0300, Henrique de Moraes Holschuh wrote: > On Sun, 24 Jun 2007, Richard Hughes wrote: > > > 1. Activate hot key handling and input device handling, with most > > > keys already mapped by default in thinkpad-acpi. > > > > Mapped

Re: [ibm-acpi-devel] Hotkey events

2007-06-24 Thread Richard Hughes
On Sun, 2007-06-24 at 09:45 -0300, Henrique de Moraes Holschuh wrote: > Currently, thinkpad-acpi defaults to most hot keys disabled, AND the hot key > system disabled. This is the firmware default, for obvious reasons > (DOS/unknown O.S. support using the BIOS). This is also true for all > versio

Re: [ibm-acpi-devel] nvram polling for hardware mixer

2007-06-15 Thread Richard Hughes
On Fri, 2007-06-15 at 11:46 -0300, Henrique de Moraes Holschuh wrote: > On Fri, 15 Jun 2007, Richard Hughes wrote: > > I'm going on a rampage of killing system daemons that talk to one type > > of hardware. Leave those to me. > > Ok, but please make sure to use a sp

Re: [ibm-acpi-devel] nvram polling for hardware mixer

2007-06-15 Thread Richard Hughes
On Fri, 2007-06-15 at 15:09 +0100, Matthew Garrett wrote: > > You can, but then you need to track what the source of it was. You > don't > want to draw a volume notification on screen just because somebody's > dragged a slider in the mixer window. I think tracking the keypresses > is probably a

Re: [ibm-acpi-devel] nvram polling for hardware mixer

2007-06-15 Thread Richard Hughes
On Fri, 2007-06-15 at 11:05 -0300, Henrique de Moraes Holschuh wrote: > > Note that I still intend to push for a ALSA hardware mixer interface > to control the built-in mixer. Totally, it's insanity any other way. This isn't a keyboard press, this is a genuine mixer device. Richard.

Re: [ibm-acpi-devel] nvram polling for hardware mixer

2007-06-15 Thread Richard Hughes
On Fri, 2007-06-15 at 14:58 +0100, Matthew Garrett wrote: > > No, I think the buttons should generate KEY_VOLUMEUP, KEY_VOLUMEDOWN > and > KEY_MUTE. Hal can then be given an fdi file that tells it that the > Thinkpad mixer works independently of userspace (like we already do > for > brightness)

Re: [ibm-acpi-devel] nvram polling for hardware mixer

2007-06-15 Thread Richard Hughes
On Fri, 2007-06-15 at 10:05 -0300, Henrique de Moraes Holschuh wrote: > On Fri, 15 Jun 2007, Richard Hughes wrote: > > > I have a patch that fixes and documents the whole stuff almost ready, it > > > will be pushed to the git tree soon. > > > > So, we still use a

Re: [ibm-acpi-devel] nvram polling for hardware mixer

2007-06-15 Thread Richard Hughes
On Fri, 2007-06-15 at 01:06 -0300, Henrique de Moraes Holschuh wrote: > On Tue, 29 May 2007, Matthew Garrett wrote: > > On Mon, May 28, 2007 at 11:58:24PM +0100, Richard Hughes wrote: > > > I've been hacking to make the nvram hardware buttons on thinkpad exposed > >

Re: [ibm-acpi-devel] Hotkey events

2007-06-13 Thread Richard Hughes
On Wed, 2007-06-13 at 11:05 -0300, Henrique de Moraes Holschuh wrote: > On Sun, 10 Jun 2007, Richard Hughes wrote: > > On Sat, 2007-06-09 at 16:41 -0300, Henrique de Moraes Holschuh wrote: > > > Now that KEY_UNKNOWN as the top choice is gone, and that HAL seems to want > >

Re: [ibm-acpi-devel] Hotkey events

2007-06-12 Thread Richard Hughes
On Sat, 2007-06-09 at 16:41 -0300, Henrique de Moraes Holschuh wrote: > Now that KEY_UNKNOWN as the top choice is gone, and that HAL seems to want > to map keys by default, the solution I used to not generate hotkey input > events and ACPI events in duplicate is busted. Why busted? Legacy systems

Re: [ibm-acpi-devel] Making KEY_UNKNOWN really useful to userland

2007-05-31 Thread Richard Hughes
On Wed, 2007-05-30 at 21:53 -0300, Henrique de Moraes Holschuh wrote: > Maybe we can add that requirement and driver changes (if any, for all > I know most drivers might already be generating such events) for > 2.6.23? I bet Richard would like that one a lot. Richard? To be honest, I've got lost

Re: [ibm-acpi-devel] nvram polling for hardware mixer

2007-05-29 Thread Richard Hughes
On Tue, 2007-05-29 at 22:11 +0100, Bastien Nocera wrote: > > Please review, and make sure I'm on the right lines. I also can't > see > > the input patches in the ibm-acpi-2.6 tree, so I've done this > against > > linus. This isn't for merging, it's just a preview for comments. > Why is defining a _

Re: [ibm-acpi-devel] nvram polling for hardware mixer

2007-05-29 Thread Richard Hughes
On Mon, 2007-05-28 at 20:28 -0300, Henrique de Moraes Holschuh wrote: > On Mon, 28 May 2007, Richard Hughes wrote: > > I've been hacking to make the nvram hardware buttons on thinkpad exposed > > as a hardware mixer device. This requires the nvram to be polled in > &

[ibm-acpi-devel] nvram polling for hardware mixer

2007-05-28 Thread Richard Hughes
d_sem); + kernel_thread(thinkpad_nvram_thread, NULL, CLONE_KERNEL); + down(&thread_sem); + } + return 0; } @@ -4293,6 +4453,12 @@ static void thinkpad_acpi_module_exit(vo dbg_printk(TPACPI_DBG_INIT, "finished subdriver exit path...\n"); + /* unload nvram thread */ + if (u

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: add DMI-based modalias

2007-05-24 Thread Richard Hughes
On Wed, 2007-05-23 at 20:25 -0300, Henrique de Moraes Holschuh wrote: > +/* Non-ancient thinkpads */ > +MODULE_ALIAS("dmi:bvnIBM:*:svnIBM:*:pvrThinkPad*:rvnIBM:*"); > +MODULE_ALIAS("dmi:bvnLENOVO:*:svnLENOVO:*:pvrThinkPad*:rvnLENOVO:*"); This is great - as we can now do this properly in the kernel

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Richard Hughes
On Tue, 2007-05-22 at 09:41 -0300, Henrique de Moraes Holschuh wrote: > > How about polling twice a second? That should cause no appreciable > load > > increase and give userspace a chance to do something clever. > > How about polling twice a second, PLUS a notification from rfkill > every time >

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-22 Thread Richard Hughes
On Mon, 2007-05-21 at 14:03 -0300, Henrique de Moraes Holschuh wrote: > On Mon, 21 May 2007, Richard Hughes wrote: > > On Mon, 2007-05-21 at 10:05 -0300, Henrique de Moraes Holschuh wrote: > > > There is no way around that. It is how these things work. You are > > > a

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-22 Thread Richard Hughes
On Mon, 2007-05-21 at 14:11 -0300, Henrique de Moraes Holschuh wrote: > On Mon, 21 May 2007, Bastien Nocera wrote: > > On Mon, 2007-05-21 at 13:37 +0100, Richard Hughes wrote: > > > On Mon, 2007-05-21 at 09:26 -0300, Henrique de Moraes Holschuh wrote: > > > > On Mo

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Richard Hughes
On Mon, 2007-05-21 at 23:29 -0400, Dmitry Torokhov wrote: > And once you implement a polling input device for your slider that > should > work too. I know you don't like polling. But what you seem to be > missing > is that you still need to notify userspace that your radio state is > changed > so y

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-21 Thread Richard Hughes
On Mon, 2007-05-21 at 10:05 -0300, Henrique de Moraes Holschuh wrote: > On Mon, 21 May 2007, Richard Hughes wrote: > > > > One comment I was about to make, are the INPUT events emitted even > > > > without a "echo enable,0x >/proc/acpi/ibm/hotkey"? >

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-21 Thread Richard Hughes
On Mon, 2007-05-21 at 09:32 -0300, Henrique de Moraes Holschuh wrote: > On Mon, 21 May 2007, Richard Hughes wrote: > > Has there been any work on implementing rfkill for thinkpad_acpi? If > > there is nobody working on this I am offering to add support into > > thinkpad_acpi t

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-21 Thread Richard Hughes
On Mon, 2007-05-21 at 09:26 -0300, Henrique de Moraes Holschuh wrote: > On Mon, 21 May 2007, Richard Hughes wrote: > > > You get full credits, of course, and I will wait an ACK from you before I > > > push it anywhere. It was your idea, and your patch probably is just fine

[ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-21 Thread Richard Hughes
All, Has there been any work on implementing rfkill for thinkpad_acpi? If there is nobody working on this I am offering to add support into thinkpad_acpi this week. Please yell if you've done some work on this, or have any patches floating around. Thanks, Richard H

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-21 Thread Richard Hughes
On Sun, 2007-05-20 at 17:12 -0300, Henrique de Moraes Holschuh wrote: > NAK (patch rejected), but idea and mostly of the code accepted. > > The patch *is* good as far as I can see, but I decided to respin it to use a > global input device for the entire thinkpad-acpi driver, for now. If we > have

[ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-16 Thread Richard Hughes
userspace uevent schemes and allows us to assign the correct keys using keymaps. Comments please. Richard Hughes. --- origin/thinkpad_acpi.h 2007-05-16 16:03:53.0 +0100 +++ thinkpad_acpi.h 2007-05-16 22:59:41.0 +0100 @@ -31,6 +31,7 @@ #include #include #include +#include

Re: [ibm-acpi-devel] nvram keys to userspace

2007-05-16 Thread Richard Hughes
On Wed, 2007-05-16 at 17:06 +0100, Bastien Nocera wrote: > On Wed, 2007-05-16 at 16:36 +0100, Richard Hughes wrote: > > On Wed, 2007-05-16 at 11:58 -0300, Henrique de Moraes Holschuh wrote: > > > > It may be the only choice. Adding new keys to input is frowned upon... >

Re: [ibm-acpi-devel] nvram keys to userspace

2007-05-16 Thread Richard Hughes
On Wed, 2007-05-16 at 11:58 -0300, Henrique de Moraes Holschuh wrote: > On Wed, 16 May 2007, Richard Hughes wrote: > > On Wed, 2007-05-16 at 10:10 -0300, Henrique de Moraes Holschuh wrote: > > > The plan is to get all hotkeys sent to userspace through INPUT, using a > > &g

Re: [ibm-acpi-devel] nvram keys to userspace

2007-05-16 Thread Richard Hughes
On Wed, 2007-05-16 at 10:10 -0300, Henrique de Moraes Holschuh wrote: > The plan is to get all hotkeys sent to userspace through INPUT, using a > "hotkey fX" or something equally generic. I can't translate from fn+f3 to > fn+battery, as that's model specific knowledge. So you don't want to do any

Re: [ibm-acpi-devel] nvram keys to userspace

2007-05-16 Thread Richard Hughes
On Wed, 2007-05-16 at 00:12 -0300, Henrique de Moraes Holschuh wrote: > On Tue, 15 May 2007, Richard Hughes wrote: > > Hi, sorry for the direct mail, please feel free to CC this message to > > the revelant lists. > > That would be [EMAIL PROTECTED] CC added. Cheers. >