[ibm-acpi-devel] [PATCH] thinkpad_acpi: Fix old style declaration GCC warning

2016-11-25 Thread Tobias Klauser
Fix an [-Wold-style-declaration] GCC warning by moving the inline keyword before the return type. Signed-off-by: Tobias Klauser --- drivers/platform/x86/thinkpad_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform

Re: [ibm-acpi-devel] [PATCH V2] support Thinkpad X1 Carbon's adaptive keyboard

2014-03-15 Thread Tobias Klauser
On 2014-03-03 at 17:31:08 +0100, Shuduo Sang wrote: [...] > +/* press Fn key a while second, it will switch to Function Mode. Then > + * release Fn key, previous mode be restored. > + */ > +bool adaptive_keyboard_mode_is_saved; > +int adaptive_keybarod_prev_mode; These should probably be made sta

Re: [ibm-acpi-devel] [PATCH V3] support Thinkpad X1 Carbon 2nd generation's adaptive keyboard

2014-03-15 Thread Tobias Klauser
On 2014-03-04 at 12:13:54 +0100, Shuduo Sang wrote: > > Submit patch V3 to support Adaptive Keyboard on Thinkpad X1 Carbon 2nd > generation according to Tobias's comments. It seems like I missed one in the previous comment, sorry. Also one of the previous comments was only partially addressed in