Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: Enable microphone mute LED

2011-05-27 Thread Matthew Garrett
On Fri, May 27, 2011 at 02:22:26PM -0400, Andrew Lutomirski wrote: > On Fri, May 27, 2011 at 12:48 PM, Matthew Garrett wrote: > > Hm. That makes things kind of tricky. While it's easy to just expose the > > LED, really we want to do it in such a way that userspace knows which > > LEDs it should be

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: Enable microphone mute LED

2011-05-27 Thread Andrew Lutomirski
On Fri, May 27, 2011 at 12:48 PM, Matthew Garrett wrote: > On Fri, May 27, 2011 at 12:39:10PM -0400, Andrew Lutomirski wrote: > >> I don't have docs so I don't really know.  But the mute LED does not >> appear to be controllable from the LED interface and when mute is lit >> there's no sound regar

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: Enable microphone mute LED

2011-05-27 Thread Matthew Garrett
On Fri, May 27, 2011 at 12:39:10PM -0400, Andrew Lutomirski wrote: > I don't have docs so I don't really know. But the mute LED does not > appear to be controllable from the LED interface and when mute is lit > there's no sound regardless of what ALSA thinks. When I light the > micmute light, I

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: Enable microphone mute LED

2011-05-27 Thread Andrew Lutomirski
On Fri, May 27, 2011 at 12:28 PM, Matthew Garrett wrote: > On Tue, May 24, 2011 at 03:41:02PM -0400, Andy Lutomirski wrote: >> I don't know exactly which models have this LED or how to identify >> them in the quirk table, so I just enabled it for all unquirked >> Lenovo models. > > Is there any ch

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: Enable microphone mute LED

2011-05-27 Thread Matthew Garrett
On Tue, May 24, 2011 at 03:41:02PM -0400, Andy Lutomirski wrote: > I don't know exactly which models have this LED or how to identify > them in the quirk table, so I just enabled it for all unquirked > Lenovo models. Is there any chance that this is meant to be controlled via ALSA, in a similar w

[ibm-acpi-devel] [PATCH] thinkpad-acpi: Enable microphone mute LED

2011-05-24 Thread Andy Lutomirski
I don't know exactly which models have this LED or how to identify them in the quirk table, so I just enabled it for all unquirked Lenovo models. Signed-off-by: Andy Lutomirski --- drivers/platform/x86/thinkpad_acpi.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/