Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Always report scancodes for hotkeys

2011-02-21 Thread Matthew Garrett
Applied, thanks. -- Matthew Garrett | mj...@srcf.ucam.org -- Index, Search & Analyze Logs and other IT data in Real-Time with Splunk Collect, index and harness all the fast moving IT data generated by your applications

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Always report scancodes for hotkeys

2011-01-22 Thread Seth Forshee
On Fri, Jan 14, 2011 at 08:25:17PM -0200, Henrique de Moraes Holschuh wrote: > On Fri, 14 Jan 2011, Seth Forshee wrote: > > Some thinkpad hotkeys report key codes like KEY_FN_F8 when something > > like KEY_VOLUMEDOWN is desired. Always provide the scan codes in > > addition to the key codes to assi

[ibm-acpi-devel] [PATCH] thinkpad_acpi: Always report scancodes for hotkeys

2011-01-22 Thread Seth Forshee
Some thinkpad hotkeys report key codes like KEY_FN_F8 when something like KEY_VOLUMEDOWN is desired. Always provide the scan codes in addition to the key codes to assist with debugging these issues. Also send the scan code before the key code to match what other drivers do, as some userspace utilit

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Always report scancodes for hotkeys

2011-01-14 Thread Henrique de Moraes Holschuh
On Fri, 14 Jan 2011, Seth Forshee wrote: > > Do I have your word of honour that canonical is not going to start using > > scancodes instead of keycodes in Ubuntu to trigger actions? > > That would be silly. The reason for this change is to aid in collecting ... > the data to update udev's keymap

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Always report scancodes for hotkeys

2011-01-14 Thread Henrique de Moraes Holschuh
On Fri, 14 Jan 2011, Seth Forshee wrote: > Some thinkpad hotkeys report key codes like KEY_FN_F8 when something > like KEY_VOLUMEDOWN is desired. Always provide the scan codes in > addition to the key codes to assist with debugging these issues. Also > send the scan code before the key code to matc