Re: [ibm-acpi-devel] [PATCH] x86: thinkpad_acpi.c: fix sparse warning

2015-02-17 Thread Darren Hart
On Thu, Feb 05, 2015 at 02:45:38PM +, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch fixes following sparse warning: Please use the imperative, command form, in the future: "Fix the following sparse warning:" For the subject, just the module name is sufficient, no need to pre

[ibm-acpi-devel] [PATCH] x86: thinkpad_acpi.c: fix sparse warning

2015-02-17 Thread Lad Prabhakar
From: "Lad, Prabhakar" this patch fixes following sparse warning: thinkpad_acpi.c:3459:11: warning: symbol 'adaptive_keyboard_modes' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar --- Found this issue on linux-next (gcc version 4.9.2, sparse version 0.4.5-rc1) and ap

Re: [ibm-acpi-devel] [PATCH] x86: thinkpad_acpi.c: fix sparse warning

2015-02-05 Thread Henrique de Moraes Holschuh
On Thu, Feb 5, 2015, at 12:45, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch fixes following sparse warning: > > thinkpad_acpi.c:3459:11: warning: symbol 'adaptive_keyboard_modes' was > not declared. Should it be static? > > Signed-off-by: Lad, Prabhakar Acked-by: Henrique de M