Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Henrique de Moraes Holschuh
On Wed, 14 Aug 2013, Alex Hung wrote: > That sounds good. I will work on it. AND that sounds like what I've asked people to do the last time the "user privacy" LEDs (MIC mute, sound mute) topic was raised, so I am also all for it. I don't know if we should allow anything but the alsa layer to tog

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Matthew Garrett
On Wed, 2013-08-14 at 22:59 +0200, David Henningsson wrote: > On 08/14/2013 10:38 PM, Matthew Garrett wrote: > > The user hit the mute key. Why would they expect *anything* to be > > unmuted? > > > > Why should the userspace application, who just wants to lit a LED, have > to care about a lot of

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Matthew Garrett
On Wed, 2013-08-14 at 22:36 +0200, David Henningsson wrote: > Imagine you're a non-technical user, who has never heard the words > "compromised userspace". You connect your headset where it fits (or > cordless), and then select the headset in sound settings (if it didn't > get selected for you whe

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Matthew Garrett
On Wed, 2013-08-14 at 21:53 +0200, David Henningsson wrote: > On 08/14/2013 04:57 PM, Matthew Garrett wrote: > > On Wed, 2013-08-14 at 11:27 +0200, David Henningsson wrote: > > > >> The privacy issue is interesting, but I don't see a practical way of > >> implementing things that would protect us

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Matthew Garrett
On Wed, 2013-08-14 at 11:27 +0200, David Henningsson wrote: > The privacy issue is interesting, but I don't see a practical way of > implementing things that would protect us against compromised userspaces. That's pretty easy - just tie the LED control to the HDA device in-kernel. -- Matthew Ga

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Matthew Garrett
On Wed, 2013-08-14 at 09:43 +0200, David Henningsson wrote: > First, the hardware mute. Because this is directly connected to the > internal speaker (and headphones?), it needs to turn into a ALSA > kcontrol on the sound card that controls speaker and/or headphones. And > it needs to named accordi

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Alex Hung
Added in David and Tim who also has some ideas to share. On Wed, Aug 14, 2013 at 3:00 PM, Matthew Garrett wrote: > On Wed, 2013-08-14 at 14:41 +0800, Alex Hung wrote: >> Hi Matthew, >> >> The problem is that thinkpad-acpi does not aware of mute is changed by >> either hotkey presses or in desktop

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Alex Hung
Hi Mattew, That sounds good. I will work on it. Cheers, Alex Hung On Wed, Aug 14, 2013 at 3:00 PM, Matthew Garrett wrote: > On Wed, 2013-08-14 at 14:41 +0800, Alex Hung wrote: > > Hi Matthew, > > > > The problem is that thinkpad-acpi does not aware of mute is changed by > > either hotkey pres

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-14 Thread Matthew Garrett
On Wed, 2013-08-14 at 14:41 +0800, Alex Hung wrote: > Hi Matthew, > > The problem is that thinkpad-acpi does not aware of mute is changed by > either hotkey presses or in desktop. Ok, how about this. Register the LED with the kernel LED subsystem. Add a new LED trigger for volume-mute. Have the

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-13 Thread Alex Hung
Hi Matthew, The problem is that thinkpad-acpi does not aware of mute is changed by either hotkey presses or in desktop. I believe Lenovo has an application to handle it Windows in similar ways, and the design makes controlling by user-applications more feasible. Cheers, Alex Hung On Wed, Aug 1

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-13 Thread Alex Hung
Hi Matthew, The scenario will be to have an user-application to listen to the mute key event, compare to hardware mute against OS mute, and sync both mute. When the application is loaded, it can use this interface to enable it; when it is unloaded it can disable it. A config option is also a good

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-13 Thread Alex Hung
On Wed, Aug 14, 2013 at 2:11 PM, Alex Hung wrote: > We are seeing bugs that mute led is out-of-sync with OS's mute. > Steps to duplicate: > 1. Press mute hotkey - it generates scancode and turns on mute led > 2. Unmute by desktop application. > > Expected result: System is un-muted and led is tur

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-13 Thread Matthew Garrett
On Wed, 2013-08-14 at 14:11 +0800, Alex Hung wrote: > One solution to the problem is to disable hardware mute. Mute hotkey > will only generate scancode but led will not be toggled. So this works, but muting doesn't control the LED? It seems like this is something that ought to be fixed in-kernel

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-13 Thread Alex Hung
We are seeing bugs that mute led is out-of-sync with OS's mute. Steps to duplicate: 1. Press mute hotkey - it generates scancode and turns on mute led 2. Unmute by desktop application. Expected result: System is un-muted and led is turned off Actual result: System, depending on models, can be mute

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-13 Thread Matthew Garrett
On Wed, 2013-08-14 at 13:53 +0800, Alex Hung wrote: > Hi Matthew, > > > The scenario will be to have an user-application to listen to the mute > key event, compare to hardware mute against OS mute, and sync both > mute. When the application is loaded, it can use this interface to > enable it; whe

Re: [ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-13 Thread Matthew Garrett
On Wed, 2013-08-14 at 13:40 +0800, Alex Hung wrote: > Newer Thinkpad models comes with a mute hotkey with a mute led. It also comes > with ACPI AML functions to control hardware mute + led. The patches add sysfs > nodes so it is possible to enable, disable and control from user-space. What's expec

[ibm-acpi-devel] [PATCH 0/2] add sysfs for acpi interfaces of thinkpad hardware mute

2013-08-13 Thread Alex Hung
Newer Thinkpad models comes with a mute hotkey with a mute led. It also comes with ACPI AML functions to control hardware mute + led. The patches add sysfs nodes so it is possible to enable, disable and control from user-space. Alex Hung (2): thinkpad-acpi: add sysfs for getting and setting har