On Tue, 09 Oct 2007, Thomas Renninger wrote:
> On Tue, 2007-10-09 at 10:47 -0300, Henrique de Moraes Holschuh wrote:
> > On Tue, 09 Oct 2007, Thomas Renninger wrote:
> > > No, all the _BCL poking should vanish.
> >
> > I need to *somehow* find out if the thinkpad supports the video extensions.
>
On Tue, 2007-10-09 at 10:47 -0300, Henrique de Moraes Holschuh wrote:
> On Tue, 09 Oct 2007, Thomas Renninger wrote:
> > > Error prone how? Please expand, because right now I am not inclined to
> > > remove that variable. It is optional, and disabled by default. Distros
> > > are
> > > not goin
On Tue, Oct 09, 2007 at 03:47:06PM +0200, Thomas Renninger wrote:
> Yep, I just realized that :(
> Maybe all required funcs (_BCM,_BCL,...) should get checked, but must
> not be invoked or I am pretty sure brightness switch through buttons
> won't work because the notify handler isn't used.
I'm n
On Tue, 2007-10-09 at 14:34 +0100, Matthew Garrett wrote:
> On Tue, Oct 09, 2007 at 03:29:12PM +0200, Thomas Renninger wrote:
> > static const struct acpi_device_id dummy_vid_device_ids[] = {
> > {"LNXVIDEO", 0},
> > {"", 0},
> > };
>
> No. This will match if any of the video extension is
On Tue, 09 Oct 2007, Thomas Renninger wrote:
> > Error prone how? Please expand, because right now I am not inclined to
> > remove that variable. It is optional, and disabled by default. Distros are
> > not going to enable it unless they have a damn good reason to, and it is not
> > even somethi
On Tue, Oct 09, 2007 at 03:29:12PM +0200, Thomas Renninger wrote:
> static const struct acpi_device_id dummy_vid_device_ids[] = {
> {"LNXVIDEO", 0},
> {"", 0},
> };
No. This will match if any of the video extension is implemented. We
only want it to match if backlight control is imple
On Tue, 2007-10-09 at 08:14 -0300, Henrique de Moraes Holschuh wrote:
> On Tue, 09 Oct 2007, Matthew Garrett wrote:
> > On Tue, Oct 09, 2007 at 11:46:48AM +0200, Thomas Renninger wrote:
> >
> > > More important: CONFIG_THINKPAD_ACPI_BACKLIGHT_DESIRED variable is error
> > > prone and should not ge
On Tue, 09 Oct 2007, Matthew Garrett wrote:
> On Tue, Oct 09, 2007 at 11:46:48AM +0200, Thomas Renninger wrote:
>
> > More important: CONFIG_THINKPAD_ACPI_BACKLIGHT_DESIRED variable is error
> > prone and should not get introduced, right?
Error prone how? Please expand, because right now I am no
On Tue, 2007-10-09 at 10:43 +0200, Christian Birchinger wrote:
> On Tue, Oct 09, 2007 at 08:59:14AM +0100, Matthew Garrett wrote:
> > On Tue, Oct 09, 2007 at 08:21:14AM +0200, Thomas Renninger wrote:
> >
> > > IMO a config variable that compiles out brightness control totally makes
> > > more sens
On Tue, Oct 09, 2007 at 11:46:48AM +0200, Thomas Renninger wrote:
> More important: CONFIG_THINKPAD_ACPI_BACKLIGHT_DESIRED variable is error
> prone and should not get introduced, right?
I agree that I can't see any reason to ever want to use the thinkpad
backlight functionality if it can be con
On Tue, 2007-10-09 at 09:33 +0100, Matthew Garrett wrote:
> On Tue, Oct 09, 2007 at 10:25:51AM +0200, Thomas Renninger wrote:
> > On Tue, 2007-10-09 at 08:59 +0100, Matthew Garrett wrote:
> > > On Tue, Oct 09, 2007 at 08:21:14AM +0200, Thomas Renninger wrote:
> > >
> > > > IMO a config variable th
On Tue, Oct 09, 2007 at 08:59:14AM +0100, Matthew Garrett wrote:
> On Tue, Oct 09, 2007 at 08:21:14AM +0200, Thomas Renninger wrote:
>
> > IMO a config variable that compiles out brightness control totally makes
> > more sense (and video, is there any functionality in ThinkPad acpi
> > driver that
On Tue, Oct 09, 2007 at 10:25:51AM +0200, Thomas Renninger wrote:
> On Tue, 2007-10-09 at 08:59 +0100, Matthew Garrett wrote:
> > On Tue, Oct 09, 2007 at 08:21:14AM +0200, Thomas Renninger wrote:
> >
> > > IMO a config variable that compiles out brightness control totally makes
> > > more sense (a
On Tue, 2007-10-09 at 08:59 +0100, Matthew Garrett wrote:
> On Tue, Oct 09, 2007 at 08:21:14AM +0200, Thomas Renninger wrote:
>
> > IMO a config variable that compiles out brightness control totally makes
> > more sense (and video, is there any functionality in ThinkPad acpi
> > driver that does n
On Tue, Oct 09, 2007 at 08:21:14AM +0200, Thomas Renninger wrote:
> IMO a config variable that compiles out brightness control totally makes
> more sense (and video, is there any functionality in ThinkPad acpi
> driver that does not get supported by the video driver?).
No, older Thinkpads don't i
On Mon, 2007-10-08 at 10:12 -0300, Henrique de Moraes Holschuh wrote:
> If we detect the presence of _BCL on a Lenovo ThinkPad, it means there is
> support for ACPI standard backlight brightness control. In that case, it
> is probably best to not make the ThinkPad-specific backlight interface
> av
If we detect the presence of _BCL on a Lenovo ThinkPad, it means there is
support for ACPI standard backlight brightness control. In that case, it
is probably best to not make the ThinkPad-specific backlight interface
available.
Provide a Kconfig option (default disabled) to make the ThinkPad-spe
17 matches
Mail list logo
