Re: [ibm-acpi-devel] [PATCH 4/4] Revert "thinkpad_acpi: Use acpi_video_handles_brightness_key_presses()"

2016-02-04 Thread Rafael J. Wysocki
On Thursday, January 14, 2016 03:18:56 PM Darren Hart wrote: > On Thu, Jan 14, 2016 at 09:41:48AM +0100, Hans de Goede wrote: > > acpi_video_handles_brightness_key_presses()'s may return false if the i915 > > driver is not loaded yet when thinkpad_acpi loads, and then return true > > after the

[ibm-acpi-devel] [PATCH 4/4] Revert "thinkpad_acpi: Use acpi_video_handles_brightness_key_presses()"

2016-01-14 Thread Hans de Goede
acpi_video_handles_brightness_key_presses()'s may return false if the i915 driver is not loaded yet when thinkpad_acpi loads, and then return true after the i915 driver has loaded. This means that thinkpad_acpi cannot use it as is since thinkpad_acpi caches the return value. This reverts commit

Re: [ibm-acpi-devel] [PATCH 4/4] Revert "thinkpad_acpi: Use acpi_video_handles_brightness_key_presses()"

2016-01-14 Thread Darren Hart
On Thu, Jan 14, 2016 at 09:41:48AM +0100, Hans de Goede wrote: > acpi_video_handles_brightness_key_presses()'s may return false if the i915 > driver is not loaded yet when thinkpad_acpi loads, and then return true > after the i915 driver has loaded. This means that thinkpad_acpi cannot > use it as

Re: [ibm-acpi-devel] [PATCH 4/4] Revert "thinkpad_acpi: Use acpi_video_handles_brightness_key_presses()"

2016-01-14 Thread Henrique de Moraes Holschuh
On Thu, Jan 14, 2016, at 21:18, Darren Hart wrote: > On Thu, Jan 14, 2016 at 09:41:48AM +0100, Hans de Goede wrote: > > acpi_video_handles_brightness_key_presses()'s may return false if the i915 > > driver is not loaded yet when thinkpad_acpi loads, and then return true > > after the i915 driver