Re: [ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2014-09-13 Thread Henrique de Moraes Holschuh
On Sat, 13 Sep 2014, Andrew Lutomirski wrote: > I remain unconvinced that the latch and toggle modes are very useful > given the state of existing userspace code. PulseAudio, at least, > appears to be entirely unable to understand that, if the "ThinkPad Let's not go there. > If we were to try to

Re: [ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2014-09-13 Thread Andrew Lutomirski
On Fri, Sep 12, 2014 at 4:32 PM, Henrique de Moraes Holschuh wrote: > On Fri, 12 Sep 2014, Andrew Lutomirski wrote: >> I think that v5 doesn't change behavior anywhere except for fixing >> broken things. I could easily be wrong, though. > > Well, I can test it on a T43 (old-style hardware mixer),

Re: [ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2014-09-12 Thread Andrew Lutomirski
On Fri, Sep 12, 2014 at 4:32 PM, Henrique de Moraes Holschuh wrote: > On Fri, 12 Sep 2014, Andrew Lutomirski wrote: >> I think that v5 doesn't change behavior anywhere except for fixing >> broken things. I could easily be wrong, though. > > Well, I can test it on a T43 (old-style hardware mixer),

Re: [ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2014-09-12 Thread Henrique de Moraes Holschuh
On Fri, 12 Sep 2014, Andrew Lutomirski wrote: > I think that v5 doesn't change behavior anywhere except for fixing > broken things. I could easily be wrong, though. Well, I can test it on a T43 (old-style hardware mixer), but not on anything else. I'll need to port the patch to 3.10 for that, th

Re: [ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2014-09-12 Thread Henrique de Moraes Holschuh
On Fri, 12 Sep 2014, Andrew Lutomirski wrote: > > This behavior is unfortunate, since modern userspace will also > > handle the hotkeys and change the other mixer. If the software > > mixer is muted and the hardware mixer is unmuted and you push mute, > > hilarity ensues as they both switch state.

Re: [ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2014-09-12 Thread Andrew Lutomirski
On Fri, Sep 12, 2014 at 4:03 PM, Henrique de Moraes Holschuh wrote: > On Fri, 12 Sep 2014, Andrew Lutomirski wrote: >> > This behavior is unfortunate, since modern userspace will also >> > handle the hotkeys and change the other mixer. If the software >> > mixer is muted and the hardware mixer is

Re: [ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2014-09-12 Thread Andrew Lutomirski
On Thu, May 19, 2011 at 1:41 PM, Andy Lutomirski wrote: > From: Andy Lutomirski > > ThinkPads have hardware volume controls and three buttons to control > them. (These are separate from the standard mixer.) By default, > the buttons are: > > - Mute: Mutes the hardware volume control and genera

Re: [ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2012-10-23 Thread Andrew Lutomirski
On Tue, Aug 2, 2011 at 8:30 PM, Henrique de Moraes Holschuh wrote: > The patch breaks the driver on IBM thinkpads. I have updated it for the > pr_foo macros, and I will fix it to do the right thing on older thinkpads so > that it won't cause the driver to abort probing :-) > > Then, I will test i

Re: [ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2011-08-03 Thread Andrew Lutomirski
Thanks! Before the patch or something like it hits mainline, it might pay to make THINKPAD_ACPI_ALSA_SUPPORT non-optional or to tweak the volume setup a bit. It currently doesn't work if THINKPAD_ACPI_ALSA_SUPPORT=n, even if ALSA is really present. --Andy On Tue, Aug 2, 2011 at 11:30 PM, Henriq

Re: [ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2011-08-02 Thread Henrique de Moraes Holschuh
The patch breaks the driver on IBM thinkpads. I have updated it for the pr_foo macros, and I will fix it to do the right thing on older thinkpads so that it won't cause the driver to abort probing :-) Then, I will test it further. -- "One disk to rule them all, One disk to find them. One disk

Re: [ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2011-07-23 Thread Henrique de Moraes Holschuh
On Mon, 13 Jun 2011, Andrew Lutomirski wrote: > On Mon, Jun 13, 2011 at 9:58 PM, Henrique de Moraes Holschuh > wrote: > > I have not been ignoring you.  My thinkpad broke down, and it is > > currently in the ICU waiting for a fan+heatsink repair, so I have not > > been able to make good on my prom

Re: [ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2011-06-13 Thread Andrew Lutomirski
On Mon, Jun 13, 2011 at 9:58 PM, Henrique de Moraes Holschuh wrote: > Andy, > > I have not been ignoring you.  My thinkpad broke down, and it is > currently in the ICU waiting for a fan+heatsink repair, so I have not > been able to make good on my promise of a faster answer. > > I hope to have it

Re: [ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2011-06-13 Thread Henrique de Moraes Holschuh
Andy, I have not been ignoring you. My thinkpad broke down, and it is currently in the ICU waiting for a fan+heatsink repair, so I have not been able to make good on my promise of a faster answer. I hope to have it repaired in the next 10 days, but it looks like I will have to refurbish its fan

[ibm-acpi-devel] [PATCH v5] thinkpad-acpi: Improve hardware volume controls

2011-05-19 Thread Andy Lutomirski
From: Andy Lutomirski ThinkPads have hardware volume controls and three buttons to control them. (These are separate from the standard mixer.) By default, the buttons are: - Mute: Mutes the hardware volume control and generates KEY_MUTE. - Up: Unmutes, generates KEY_VOLUMEUP, and increases v