Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-06-04 Thread Dmitry Torokhov
Hi Hans, Andrzej, On Wed, Jun 03, 2020 at 09:37:10PM +0200, Hans de Goede wrote: > Hi, > > On 6/3/20 7:54 PM, Andrzej Pietrasiewicz wrote: > > W dniu 03.06.2020 o 19:38, Hans de Goede pisze: > > > Hi, > > > > > > On 6/3/20 3:07 PM, Andrzej Pietrasiewicz wrote: > > > > Hi Hans, hi Dmitry, > > >

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-06-03 Thread Hans de Goede
Hi, On 6/3/20 7:54 PM, Andrzej Pietrasiewicz wrote: W dniu 03.06.2020 o 19:38, Hans de Goede pisze: Hi, On 6/3/20 3:07 PM, Andrzej Pietrasiewicz wrote: Hi Hans, hi Dmitry, I'm taking one step back and looking at the ->open() and ->close() driver callbacks. They are called from input_open

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-06-03 Thread Hans de Goede
Hi, On 6/3/20 3:07 PM, Andrzej Pietrasiewicz wrote: Hi Hans, hi Dmitry, I'm taking one step back and looking at the ->open() and ->close() driver callbacks. They are called from input_open_device() and input_close_device(), respectively: input_open_device(): "This function should be called

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-06-02 Thread Hans de Goede
Hi, On 6/2/20 8:50 PM, Andrzej Pietrasiewicz wrote: Hi Dmitry, W dniu 02.06.2020 o 19:52, Dmitry Torokhov pisze: Hi Andrzej, On Tue, Jun 02, 2020 at 06:56:40PM +0200, Andrzej Pietrasiewicz wrote: Hi Dmitry, W dniu 27.05.2020 o 08:34, Dmitry Torokhov pisze: That said, I think the way we sho

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-06-02 Thread Dmitry Torokhov
Hi Andrzej, On Tue, Jun 02, 2020 at 06:56:40PM +0200, Andrzej Pietrasiewicz wrote: > Hi Dmitry, > > W dniu 27.05.2020 o 08:34, Dmitry Torokhov pisze: > > That said, I think the way we should handle inhibit/uninhibit, is that > > if we have the callback defined, then we call it, and only call open

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-05-26 Thread Dmitry Torokhov
On Tue, May 19, 2020 at 11:36:34AM +0200, Hans de Goede wrote: > Hi, > > On 5/19/20 11:02 AM, Andrzej Pietrasiewicz wrote: > > Hi Hans, Hi Dmitry, > > > > W dniu 18.05.2020 o 16:23, Hans de Goede pisze: > > > Hi, > > > > > > > > > > > > > > > > > > > > So I wonder what this series actually ad

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-05-19 Thread Hans de Goede
Hi, On 5/19/20 11:02 AM, Andrzej Pietrasiewicz wrote: Hi Hans, Hi Dmitry, W dniu 18.05.2020 o 16:23, Hans de Goede pisze: Hi, So I wonder what this series actually adds for functionality for userspace which can not already be achieved this way? I also noticed that you keep the device op

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-05-18 Thread Hans de Goede
Hi, On 5/18/20 3:49 PM, Andrzej Pietrasiewicz wrote: Hi Hans, W dniu 18.05.2020 o 14:24, Hans de Goede pisze: Hi, On 5/18/20 12:48 PM, Andrzej Pietrasiewicz wrote: Hi Hans, W dniu 15.05.2020 o 20:19, Hans de Goede pisze: Hi Andrezj, On 5/15/20 6:49 PM, Andrzej Pietrasiewicz wrote: Usersp

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-05-18 Thread Hans de Goede
Hi, On 5/18/20 12:48 PM, Andrzej Pietrasiewicz wrote: Hi Hans, W dniu 15.05.2020 o 20:19, Hans de Goede pisze: Hi Andrezj, On 5/15/20 6:49 PM, Andrzej Pietrasiewicz wrote: Userspace might want to implement a policy to temporarily disregard input from certain devices, including not treating t

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-05-18 Thread Hans de Goede
Hi, On 5/18/20 4:40 AM, Dmitry Torokhov wrote: Hi Hans, Peter, On Mon, May 18, 2020 at 08:55:10AM +1000, Peter Hutterer wrote: On Fri, May 15, 2020 at 08:19:10PM +0200, Hans de Goede wrote: Hi Andrezj, On 5/15/20 6:49 PM, Andrzej Pietrasiewicz wrote: Userspace might want to implement a poli

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-05-17 Thread Dmitry Torokhov
Hi Hans, Peter, On Mon, May 18, 2020 at 08:55:10AM +1000, Peter Hutterer wrote: > On Fri, May 15, 2020 at 08:19:10PM +0200, Hans de Goede wrote: > > Hi Andrezj, > > > > On 5/15/20 6:49 PM, Andrzej Pietrasiewicz wrote: > > > Userspace might want to implement a policy to temporarily disregard input

Re: [ibm-acpi-devel] [PATCHv2 0/7] Support inhibiting input devices

2020-05-15 Thread Hans de Goede
Hi Andrezj, On 5/15/20 6:49 PM, Andrzej Pietrasiewicz wrote: Userspace might want to implement a policy to temporarily disregard input from certain devices, including not treating them as wakeup sources. An example use case is a laptop, whose keyboard can be folded under the screen to create ta