Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-22 Thread Henrique de Moraes Holschuh
On Tue, 22 May 2007, Richard Hughes wrote: > > > Ick indeed. It should really be automatic (ie. no need to poke anywhere > > > to get the events back to user-space). > > > > No way, no how. The firmware often does better at it. > > Does better than userspace? By taking control of the backlight

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-22 Thread Richard Hughes
On Mon, 2007-05-21 at 14:03 -0300, Henrique de Moraes Holschuh wrote: > On Mon, 21 May 2007, Richard Hughes wrote: > > On Mon, 2007-05-21 at 10:05 -0300, Henrique de Moraes Holschuh wrote: > > > There is no way around that. It is how these things work. You are > > > actually > > > requesting to

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-22 Thread Richard Hughes
On Mon, 2007-05-21 at 14:11 -0300, Henrique de Moraes Holschuh wrote: > On Mon, 21 May 2007, Bastien Nocera wrote: > > On Mon, 2007-05-21 at 13:37 +0100, Richard Hughes wrote: > > > On Mon, 2007-05-21 at 09:26 -0300, Henrique de Moraes Holschuh wrote: > > > > On Mon, 21 May 2007, Richard Hughes wro

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-21 Thread Henrique de Moraes Holschuh
On Mon, 21 May 2007, Bastien Nocera wrote: > On Mon, 2007-05-21 at 13:37 +0100, Richard Hughes wrote: > > On Mon, 2007-05-21 at 09:26 -0300, Henrique de Moraes Holschuh wrote: > > > On Mon, 21 May 2007, Richard Hughes wrote: > > > > > You get full credits, of course, and I will wait an ACK from you

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-21 Thread Bastien Nocera
On Mon, 2007-05-21 at 13:37 +0100, Richard Hughes wrote: > On Mon, 2007-05-21 at 09:26 -0300, Henrique de Moraes Holschuh wrote: > > On Mon, 21 May 2007, Richard Hughes wrote: > > > > You get full credits, of course, and I will wait an ACK from you before > > > > I > > > > push it anywhere. It wa

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-21 Thread Henrique de Moraes Holschuh
On Mon, 21 May 2007, Richard Hughes wrote: > On Mon, 2007-05-21 at 10:05 -0300, Henrique de Moraes Holschuh wrote: > > There is no way around that. It is how these things work. You are actually > > requesting to the firmware that "OSI will handle these hotkeys". > > On all models? When I enable

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-21 Thread Richard Hughes
On Mon, 2007-05-21 at 10:05 -0300, Henrique de Moraes Holschuh wrote: > On Mon, 21 May 2007, Richard Hughes wrote: > > > > One comment I was about to make, are the INPUT events emitted even > > > > without a "echo enable,0x >/proc/acpi/ibm/hotkey"? > > > > > > No, they are not. > > > > Ick.

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-21 Thread Henrique de Moraes Holschuh
On Mon, 21 May 2007, Richard Hughes wrote: > > > One comment I was about to make, are the INPUT events emitted even > > > without a "echo enable,0x >/proc/acpi/ibm/hotkey"? > > > > No, they are not. > > Ick. There is no way around that. It is how these things work. You are actually reques

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-21 Thread Richard Hughes
On Mon, 2007-05-21 at 09:26 -0300, Henrique de Moraes Holschuh wrote: > On Mon, 21 May 2007, Richard Hughes wrote: > > > You get full credits, of course, and I will wait an ACK from you before I > > > push it anywhere. It was your idea, and your patch probably is just fine > > > as > > > far as "

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-21 Thread Henrique de Moraes Holschuh
On Mon, 21 May 2007, Richard Hughes wrote: > > You get full credits, of course, and I will wait an ACK from you before I > > push it anywhere. It was your idea, and your patch probably is just fine as > > far as "it works" goes, so you get to comment and offer suggestions before I > > merge it. >

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-21 Thread Richard Hughes
On Sun, 2007-05-20 at 17:12 -0300, Henrique de Moraes Holschuh wrote: > NAK (patch rejected), but idea and mostly of the code accepted. > > The patch *is* good as far as I can see, but I decided to respin it to use a > global input device for the entire thinkpad-acpi driver, for now. If we > have

Re: [ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-20 Thread Henrique de Moraes Holschuh
NAK (patch rejected), but idea and mostly of the code accepted. The patch *is* good as far as I can see, but I decided to respin it to use a global input device for the entire thinkpad-acpi driver, for now. If we have a strong reason to register multiple input devices later, we can change that.

[ibm-acpi-devel] [patch] add INPUT key reporting to thinkpad_acpi

2007-05-16 Thread Richard Hughes
Attached patch adds input keyboard reporting to the thinkpad_acpi driver. This works for me using evtest /dev/input/event7, although the events do not get to X for some reason. KEY_POWER does get to X but not KEY_FN_F1, so I assume X is filtering the keys at some stage. This removes ugly userspac