Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-22 Thread Kevin Locke
On Sun, 2007-07-15 at 23:49 +0100, Matthew Garrett wrote: > On Sun, Jul 15, 2007 at 07:08:01PM -0300, Henrique de Moraes Holschuh wrote: >> Here's my view on things: >> >> Non-bleeding-edge userspace screws up volume control if I send events. And >> so does bleeding-edge userspace for that matter

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-16 Thread Henrique de Moraes Holschuh
On Mon, 16 Jul 2007, Dmitry Torokhov wrote: > I will add a comment to input.h to the effect that KEY_SWITCHVIDEOMODE > is to switch between available outputs (LCD/Monitor/TV-Out/Whatnot). > Right now couple of RCs are using it for different purposes (cycling > through inputs I think) so we should d

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-16 Thread Dmitry Torokhov
On 7/15/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Mon, 16 Jul 2007, Matthew Garrett wrote: > > > > Having checked other drivers, it looks like KEY_SWITCHVIDEOMODE is the > > one used for video toggling. If that's not actually how people are using > > it, we need to fix that -

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Henrique de Moraes Holschuh
On Mon, 16 Jul 2007, Matthew Garrett wrote: > On Sun, Jul 15, 2007 at 09:12:40PM -0300, Henrique de Moraes Holschuh wrote: > > On Sun, 15 Jul 2007, Matthew Garrett wrote: > > > No, it doesn't. It interacts in a way that you may not consider to be > > > ideal - the vast majority of our users appear

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 09:12:40PM -0300, Henrique de Moraes Holschuh wrote: > On Sun, 15 Jul 2007, Matthew Garrett wrote: > > No, it doesn't. It interacts in a way that you may not consider to be > > ideal - the vast majority of our users appear to prefer it to the > > previous behaviour, so it'

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Henrique de Moraes Holschuh
On Sun, 15 Jul 2007, Matthew Garrett wrote: > On Sun, Jul 15, 2007 at 07:08:01PM -0300, Henrique de Moraes Holschuh wrote: > > On Sun, 15 Jul 2007, Matthew Garrett wrote: > > > Right now, the hotkey functionality of the driver is not terribly useful > > > without (bleeding-edge) userspace. This is

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 07:08:01PM -0300, Henrique de Moraes Holschuh wrote: > On Sun, 15 Jul 2007, Matthew Garrett wrote: > > Right now, the hotkey functionality of the driver is not terribly useful > > without (bleeding-edge) userspace. This is inconsistent with the > > majority of input driver

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Henrique de Moraes Holschuh
On Sun, 15 Jul 2007, Matthew Garrett wrote: > On Sun, Jul 15, 2007 at 06:14:21PM -0300, Henrique de Moraes Holschuh wrote: > > On Sun, 15 Jul 2007, Matthew Garrett wrote: > > > We already have in-kernel drivers that do this properly, so I'd suspect > > > that whoever told you that was wrong. > >

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 06:14:21PM -0300, Henrique de Moraes Holschuh wrote: > On Sun, 15 Jul 2007, Matthew Garrett wrote: > > We already have in-kernel drivers that do this properly, so I'd suspect > > that whoever told you that was wrong. > > I got tired of being told one way or the other, alre

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Henrique de Moraes Holschuh
On Sun, 15 Jul 2007, Matthew Garrett wrote: > On Sun, Jul 15, 2007 at 05:09:48PM -0300, Henrique de Moraes Holschuh wrote: > > On Sun, 15 Jul 2007, Matthew Garrett wrote: > > > But we're able to differentiate between the models. > > > > Yes. And I was told to not do it in the kernel when possible,

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 05:09:48PM -0300, Henrique de Moraes Holschuh wrote: > On Sun, 15 Jul 2007, Matthew Garrett wrote: > > But we're able to differentiate between the models. > > Yes. And I was told to not do it in the kernel when possible, so I will map > by default only what is marked and wo

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Henrique de Moraes Holschuh
On Sun, 15 Jul 2007, Matthew Garrett wrote: > On Sun, Jul 15, 2007 at 03:05:29PM -0300, Henrique de Moraes Holschuh wrote: > > On Sat, 14 Jul 2007, Matthew Garrett wrote: > > > Again, we have keycodes for most of these and we have the ability to > > > make the driver choose the correct one by defa

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 03:05:29PM -0300, Henrique de Moraes Holschuh wrote: > On Sat, 14 Jul 2007, Matthew Garrett wrote: > > Again, we have keycodes for most of these and we have the ability to > > make the driver choose the correct one by default. Why make things more > > difficult? > > Becau

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-15 Thread Henrique de Moraes Holschuh
On Sat, 14 Jul 2007, Matthew Garrett wrote: > On Sat, Jul 14, 2007 at 11:12:00AM -0300, Henrique de Moraes Holschuh wrote: > > - KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, > > - KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, > > - KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNO

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-14 Thread Matthew Garrett
On Sat, Jul 14, 2007 at 11:12:00AM -0300, Henrique de Moraes Holschuh wrote: > - KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, > - KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, > - KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, KEY_UNKNOWN, > + KEY_FN_F1, KEY_FN_F2, KE

[ibm-acpi-devel] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-14 Thread Henrique de Moraes Holschuh
Make the input layer the default way to deal with thinkpad-acpi hot keys, but add a kernel config option to retain the old way of doing things. This means we map a lot more keys to useful stuff by default, and also that we enable hot key handling by default on driver load (like Windows does). The