Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 05:17:12PM -0300, Henrique de Moraes Holschuh wrote: > Life would be significantly easier if I could convey that information in the > kernel. Since I cannot, I effectively consider these keys to be "defective" > as far as the regular input device events are supposed to mea

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key

2007-07-15 Thread Henrique de Moraes Holschuh
Hi Matthew! On Sun, 15 Jul 2007, Matthew Garrett wrote: > On Sun, Jul 15, 2007 at 02:59:22PM -0300, Henrique de Moraes Holschuh wrote: > > On Sat, 14 Jul 2007, Matthew Garrett wrote: > > > > > On Sat, Jul 14, 2007 at 11:12:09AM -0300, Henrique de Moraes Holschuh > > > wrote: > > > > > > Ah, I

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key

2007-07-15 Thread Matthew Garrett
On Sun, Jul 15, 2007 at 02:59:22PM -0300, Henrique de Moraes Holschuh wrote: > On Sat, 14 Jul 2007, Matthew Garrett wrote: > > > On Sat, Jul 14, 2007 at 11:12:09AM -0300, Henrique de Moraes Holschuh wrote: > > > > Ah, I see this one fixes some of my comments. However: > > > > > + KEY_RES

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key

2007-07-15 Thread Henrique de Moraes Holschuh
Hi Matthew! On Sat, 14 Jul 2007, Matthew Garrett wrote: > On Sat, Jul 14, 2007 at 11:12:09AM -0300, Henrique de Moraes Holschuh wrote: > > Ah, I see this one fixes some of my comments. However: > > > + KEY_RESERVED, /* 0x0F: FN+HOME (brightness up) */ > > + /* Scan codes 0

Re: [ibm-acpi-devel] ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key

2007-07-14 Thread Matthew Garrett
On Sat, Jul 14, 2007 at 11:12:09AM -0300, Henrique de Moraes Holschuh wrote: Ah, I see this one fixes some of my comments. However: > + KEY_RESERVED, /* 0x0F: FN+HOME (brightness up) */ > + /* Scan codes 0x10 to 0x1F: Extended ACPI HKEY hot keys */ > + KEY_RE

[ibm-acpi-devel] ACPI: thinkpad-acpi: react to Lenovo ThinkPad differences in hot key

2007-07-14 Thread Henrique de Moraes Holschuh
Lenovo ThinkPads have a slightly different key map layout from IBM ThinkPads (fn+f2 and fn+f3 are swapped). Knowing which one we are dealing with, we can properly set a few more hot keys up by default. Also, export the correct vendor in the input device, as that information might be useful to use