Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Henrique de Moraes Holschuh
On Tue, 22 May 2007, Dmitry Torokhov wrote: > [Sorry, cut away too much in original reply...] > On 5/22/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > > On Tue, 22 May 2007, Dmitry Torokhov wrote: > > > > > > Notification to where? The driver? Userspace? Does delay in status > > > rea

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Henrique de Moraes Holschuh
On Tue, 22 May 2007, Dmitry Torokhov wrote: > > It was beaten into my heads that rfkill has two parts and that one is not to > > try to use one without the other: The sysfs class, and the input layer > > stuff. > > I am sorry if I come out too strong sometimes. No problem, I am sure I come out t

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Henrique de Moraes Holschuh
On Tue, 22 May 2007, Dmitry Torokhov wrote: > > 1. I have nothing against polling when it is the only way to do something, > > as long as it can be kept at a reasonable rate to not waste too many > > resources (ACPI access is *expensive*). But I really don't take kindly to > > doing it with any hi

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Dmitry Torokhov
[Sorry, cut away too much in original reply...] On 5/22/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Tue, 22 May 2007, Dmitry Torokhov wrote: > > > > Notification to where? The driver? Userspace? Does delay in status > > reading of ~0.5 sec matter? You are concerned with the loa

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Dmitry Torokhov
On 5/22/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Tue, 22 May 2007, Dmitry Torokhov wrote: > > On 5/22/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > > > I can work with that, yes. In fact I have nothing against it, but current > > > rfkill does not allow for th

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Henrique de Moraes Holschuh
On Tue, 22 May 2007, Lennart Poettering wrote: > AFAIK the Windows Thinkpad utils show a nice OSD when the rfkill button > is switched. Has anybody checked how they get the event? Not that I know of, and that knowledge would be welcome, indeed... -- "One disk to rule them all, One disk to fin

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Lennart Poettering
On Tue, 22.05.07 09:41, Henrique de Moraes Holschuh ([EMAIL PROTECTED]) wrote: > > On Tue, 22 May 2007, Richard Hughes wrote: > > Yes, if there is no event on kill switch, I agree. We need a way so > > AFAIK one can poll it, but since it is in the EC space, it is a "we don't > have events" thing

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Dmitry Torokhov
On 5/22/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Mon, 21 May 2007, Dmitry Torokhov wrote: > > On Monday 21 May 2007 13:22, Henrique de Moraes Holschuh wrote: > > > On Mon, 21 May 2007, Dmitry Torokhov wrote: > > > > RFkill is not only about "please disable radios", it _does_

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Henrique de Moraes Holschuh
On Tue, 22 May 2007, Dmitry Torokhov wrote: > On 5/22/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > > I can work with that, yes. In fact I have nothing against it, but current > > rfkill does not allow for the above. > > RFKill sure does not. Rfkill does not support buttons, slider

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Henrique de Moraes Holschuh
On Tue, 22 May 2007, Richard Hughes wrote: > > How about polling twice a second, PLUS a notification from rfkill > > every time > > something wants to read an attribute, so that we nearly close the > > window of > > opportunity where the status is incorrect? That's what I am asking of > > rfkill,

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Henrique de Moraes Holschuh
On Mon, 21 May 2007, Dmitry Torokhov wrote: > On Monday 21 May 2007 13:22, Henrique de Moraes Holschuh wrote: > > On Mon, 21 May 2007, Dmitry Torokhov wrote: > > > RFkill is not only about "please disable radios", it _does_ provide > > > the standard sysfs interface to control the radios as well. >

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Dmitry Torokhov
On 5/22/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Tue, 22 May 2007, Richard Hughes wrote: > > Yes, if there is no event on kill switch, I agree. We need a way so > > AFAIK one can poll it, but since it is in the EC space, it is a "we don't > have events" thing. If someone fin

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Richard Hughes
On Tue, 2007-05-22 at 09:41 -0300, Henrique de Moraes Holschuh wrote: > > How about polling twice a second? That should cause no appreciable > load > > increase and give userspace a chance to do something clever. > > How about polling twice a second, PLUS a notification from rfkill > every time >

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Henrique de Moraes Holschuh
On Tue, 22 May 2007, Richard Hughes wrote: > Yes, if there is no event on kill switch, I agree. We need a way so AFAIK one can poll it, but since it is in the EC space, it is a "we don't have events" thing. If someone finds a QXX DSDT method or somesuch we can trap, then we will have events for i

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Dmitry Torokhov
On Monday 21 May 2007 13:22, Henrique de Moraes Holschuh wrote: > On Mon, 21 May 2007, Dmitry Torokhov wrote: > > RFkill is not only about "please disable radios", it _does_ provide > > the standard sysfs interface to control the radios as well. > > To control? Fine, if it was really controlling

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-22 Thread Richard Hughes
On Mon, 2007-05-21 at 23:29 -0400, Dmitry Torokhov wrote: > And once you implement a polling input device for your slider that > should > work too. I know you don't like polling. But what you seem to be > missing > is that you still need to notify userspace that your radio state is > changed > so y

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-21 Thread Henrique de Moraes Holschuh
On Mon, 21 May 2007, Dmitry Torokhov wrote: > RFkill is not only about "please disable radios", it _does_ provide > the standard sysfs interface to control the radios as well. To control? Fine, if it was really controlling them. The problem is that thinkpad-acpi needs it to *interface* with the

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-21 Thread Dmitry Torokhov
Hi, On 5/21/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: On Mon, 21 May 2007, Richard Hughes wrote: > Has there been any work on implementing rfkill for thinkpad_acpi? If > there is nobody working on this I am offering to add support into > thinkpad_acpi this week. Yes, I have bee

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-21 Thread Alex Deucher
On 5/21/07, Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Mon, 21 May 2007, Richard Hughes wrote: > > Has there been any work on implementing rfkill for thinkpad_acpi? If > > there is nobody working on this I am offering to add support into > > thinkpad_acpi this week. > > Yes, I have

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-21 Thread Henrique de Moraes Holschuh
On Mon, 21 May 2007, Richard Hughes wrote: > > I might even find out that we are better off not using rfkill in > > thinkpad-acpi itself, and letting the bluetooth and wwan drivers process it. > > We shall see. > > Less than ideal from a userspace POV, as I really just wanted to write > one bit of

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-21 Thread Richard Hughes
On Mon, 2007-05-21 at 09:32 -0300, Henrique de Moraes Holschuh wrote: > On Mon, 21 May 2007, Richard Hughes wrote: > > Has there been any work on implementing rfkill for thinkpad_acpi? If > > there is nobody working on this I am offering to add support into > > thinkpad_acpi this week. > > Yes, I

Re: [ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-21 Thread Henrique de Moraes Holschuh
On Mon, 21 May 2007, Richard Hughes wrote: > Has there been any work on implementing rfkill for thinkpad_acpi? If > there is nobody working on this I am offering to add support into > thinkpad_acpi this week. Yes, I have been talking to the rfkill people, but we had some disagreements on how to be

[ibm-acpi-devel] Adding rfkill support to thinkpad_acpi

2007-05-21 Thread Richard Hughes
All, Has there been any work on implementing rfkill for thinkpad_acpi? If there is nobody working on this I am offering to add support into thinkpad_acpi this week. Please yell if you've done some work on this, or have any patches floating around. Thanks, Richard Hughes -