Re: [ibm-acpi-devel] How to distinguish between general ACPI video driver module and brightness/display providing vendor specific ACPI modules

2007-10-10 Thread Henrique de Moraes Holschuh
On Wed, 10 Oct 2007, Henrique de Moraes Holschuh wrote: > > 3) > > I think I found a bug in thinkpad_acpi: > > if (!*ibm->acpi->handle) > > return 0; > > in setup_acpi_notify(..) probably should be: > > if (!ibm->acpi->handle) > > return 0; > > I will check that. N

Re: [ibm-acpi-devel] How to distinguish between general ACPI video driver module and brightness/display providing vendor specific ACPI modules

2007-10-10 Thread Henrique de Moraes Holschuh
On Wed, 10 Oct 2007, Thomas Renninger wrote: > IMO this should work. Like that there is no need in Thinkpad to fiddle > with hardcoded "\\_SB.../_BCL" paths to find out whether brightness is > supported. Just check for a global variable video_funcs_supported -> > take hands off display switching an

Re: [ibm-acpi-devel] How to distinguish between general ACPI video driver module and brightness/display providing vendor specific ACPI modules

2007-10-10 Thread Thomas Renninger
On Tue, 2007-10-09 at 22:53 +0200, Thomas Renninger wrote: > On Tue, 2007-10-09 at 11:29 -0300, Henrique de Moraes Holschuh wrote: > > On Tue, 09 Oct 2007, Thomas Renninger wrote: > > > On Tue, 2007-10-09 at 10:47 -0300, Henrique de Moraes Holschuh wrote: > > > > On Tue, 09 Oct 2007, Thomas Renning

[ibm-acpi-devel] How to distinguish between general ACPI video driver module and brightness/display providing vendor specific ACPI modules

2007-10-09 Thread Thomas Renninger
On Tue, 2007-10-09 at 11:29 -0300, Henrique de Moraes Holschuh wrote: > On Tue, 09 Oct 2007, Thomas Renninger wrote: > > On Tue, 2007-10-09 at 10:47 -0300, Henrique de Moraes Holschuh wrote: > > > On Tue, 09 Oct 2007, Thomas Renninger wrote: > > > > No, all the _BCL poking should vanish. > > > > >