Re: [infinispan-dev] Test failures

2014-06-11 Thread Dan Berindei
I'll skip straight to the conclusions in the paper: • Keep regression tests around for up to a year — but most of those will be system-level tests rather than unit tests. I would say most of our tests qualify as regression tests, and they are system-level (they start a full cache manager, with

Re: [infinispan-dev] Leaking ThreadLocal

2014-06-11 Thread Galder Zamarreño
On 10 Jun 2014, at 10:31, Sanne Grinovero sa...@infinispan.org wrote: Hi all, as spotted by the testsuite - which was rightfully complaining - the CHMv8 which we backported from the JDK has a static ThreadLocal that it uses internally. Our copy is having the same, and so Dan enhanced the

Re: [infinispan-dev] Leaking ThreadLocal

2014-06-11 Thread Sanne Grinovero
On 11 June 2014 11:38, Galder Zamarreño gal...@redhat.com wrote: On 10 Jun 2014, at 10:31, Sanne Grinovero sa...@infinispan.org wrote: Hi all, as spotted by the testsuite - which was rightfully complaining - the CHMv8 which we backported from the JDK has a static ThreadLocal that it uses

[infinispan-dev] More commits, or squashing?

2014-06-11 Thread Sanne Grinovero
A discussion which could interest more of you: https://github.com/infinispan/infinispan/pull/2613#issuecomment-45760469 There is no golden rule, but I believe it's highly desirable to give the sequence a logical flow which makes sense. In this specific situation, it also helped myself as I've

Re: [infinispan-dev] Query integration tests performance and JGroups

2014-06-11 Thread Dennis Reed
Can you double check that you're interpreting the profiler data correctly (specifically with respect to where threads are spending time versus where they are using CPU)? The spot you pointed out *should* show up as a place where threads spend lots of time, as these threads just sit waiting in

Re: [infinispan-dev] More commits, or squashing?

2014-06-11 Thread Mircea Markus
On Jun 11, 2014, at 17:45, Adrian Nistor anis...@redhat.com wrote: I think the journey is at least as important as the destination and documenting each major step along the way by leaving a clear mark in version history is a good thing. +1 for splitting commits whenever it makes sense.

Re: [infinispan-dev] Query integration tests performance and JGroups

2014-06-11 Thread Gustavo Fernandes
Hi, sorry for the confusion. The profiler was configured to measure wall time for all the methods rather than CPU time. During the test, CPU usage was pretty low ( 10%). Btw, Ion Savin suggested trying to change the tcp_nodelay setting to true: it made a big difference, tests went down from 6min