Re: [infinispan-dev] ApplyDeltaCommand: question about affected keys

2013-01-28 Thread Vladimir Blagojevic
On 13-01-25 6:09 AM, Adrian Nistor wrote: Hi Vladimir, I think Pedro's initial question remained unanswered. Would be good to clarify this so we can fix the TODO in ApplyDeltaCommand constructor. Thanks, Adrian Adrian&Pedro, Yes, good catch. It should be passed to super as you noted. But al

Re: [infinispan-dev] ApplyDeltaCommand: question about affected keys

2013-01-28 Thread Vladimir Blagojevic
On 13-01-23 2:01 PM, Pedro Ruivo wrote: > Hi all, > > I was looking in the ApplyDeltaCommand code and I found something > strange. Why is the method getAffectedKeys() returning a singleton > collection with a null key inside? Yes, this is a bug. It should return s single key where delta map is sto

Re: [infinispan-dev] ApplyDeltaCommand: question about affected keys

2013-01-25 Thread Adrian Nistor
Hi Vladimir, I think Pedro's initial question remained unanswered. Would be good to clarify this so we can fix the TODO in ApplyDeltaCommand constructor. Thanks, Adrian On 01/24/2013 07:57 PM, Vladimir Blagojevic wrote: On 13-01-24 12:52 PM, Randall Hauch wrote: Actually, it is both, depend

Re: [infinispan-dev] ApplyDeltaCommand: question about affected keys

2013-01-24 Thread Vladimir Blagojevic
On 13-01-24 12:52 PM, Randall Hauch wrote: Actually, it is both, depending upon the situation. When a new process is started and joins the cluster, the new process will via state transfer receive its entries as externalized whole values, not deltas. However, from that point forward, I believe

Re: [infinispan-dev] ApplyDeltaCommand: question about affected keys

2013-01-24 Thread Randall Hauch
Actually, it is both, depending upon the situation. When a new process is started and joins the cluster, the new process will via state transfer receive its entries as externalized whole values, not deltas. However, from that point forward, I believe that all changes to a DeltaAware entry will

Re: [infinispan-dev] ApplyDeltaCommand: question about affected keys

2013-01-24 Thread Vladimir Blagojevic
Should be just the deltas. That was the whole point after all :-) Regards, Vladimir On 13-01-24 12:19 PM, Ray Tsang wrote: Ah that explains it! Btw - after the delta, in replicated/distributed cache, does it send over the whole object or just the deltas? I'm assuming the former. Thanks! On

Re: [infinispan-dev] ApplyDeltaCommand: question about affected keys

2013-01-24 Thread Ray Tsang
Ah that explains it! Btw - after the delta, in replicated/distributed cache, does it send over the whole object or just the deltas? I'm assuming the former. Thanks! On Thu, Jan 24, 2013 at 4:04 AM, Manik Surtani wrote: > Sorry, I misread the question - the link below shows how Deltas are > ap

Re: [infinispan-dev] ApplyDeltaCommand: question about affected keys

2013-01-24 Thread Manik Surtani
Sorry, I misread the question - the link below shows how Deltas are applied when a delta is shipped around as a part of a put(). If you are explicitly using the ApplyDeltaCommand, this is Vlad's code and he should know. I could trace through usage in my IDE but then so could anybody - Vlad, d

Re: [infinispan-dev] ApplyDeltaCommand: question about affected keys

2013-01-24 Thread Manik Surtani
I believe this is what you guys are looking for. https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/commands/write/PutKeyValueCommand.java#L100 On 23 Jan 2013, at 21:02, Vladimir Blagojevic wrote: > On 13-01-23 3:36 PM, Ray Tsang wrote: >> speaking of ApplyD

Re: [infinispan-dev] ApplyDeltaCommand: question about affected keys

2013-01-23 Thread Vladimir Blagojevic
On 13-01-23 3:36 PM, Ray Tsang wrote: > speaking of ApplyDeltaCommand - where does it actually perform the > delta operation? perform() simply returns null. Any pointers? > > Thanks, Look for use of ApplyDeltaCommand class in IDE (in Eclipse highlight class name + right click + References->Work

Re: [infinispan-dev] ApplyDeltaCommand: question about affected keys

2013-01-23 Thread Ray Tsang
speaking of ApplyDeltaCommand - where does it actually perform the delta operation? perform() simply returns null. Any pointers? Thanks, On Wed, Jan 23, 2013 at 12:07 PM, Adrian Nistor wrote: > Hi Pedro, > > I found this odd too a few months ago while working on state transfer > and added a T

Re: [infinispan-dev] ApplyDeltaCommand: question about affected keys

2013-01-23 Thread Adrian Nistor
Hi Pedro, I found this odd too a few months ago while working on state transfer and added a TODO in the constructor (which should pass the deltaAwareValueKey to super) planning to ask and fix it later, but this never happened. Maybe Vladimir knows more about this? Cheers! On 01/23/2013 09:01

[infinispan-dev] ApplyDeltaCommand: question about affected keys

2013-01-23 Thread Pedro Ruivo
Hi all, I was looking in the ApplyDeltaCommand code and I found something strange. Why is the method getAffectedKeys() returning a singleton collection with a null key inside? Shouldn't be supposed to return a singleton collection with deltaAwareValueKey or the keys collection? Thanks! Cheer