Re: [infinispan-dev] FindBugs on infinispan

2015-03-20 Thread Alan Field
code should be formatted by a tool when checked into the repo. > > That way individuals can apply whatever formatting they prefer in their > > IDEs, but the source code in the repo is stored in a specific way. > > > > Thanks, > > Alan > > > > ----- Origina

Re: [infinispan-dev] FindBugs on infinispan

2015-03-20 Thread Dan Berindei
checked into the repo. That way > individuals can apply whatever formatting they prefer in their IDEs, but the > source code in the repo is stored in a specific way. > > Thanks, > Alan > > - Original Message - >> From: "Sanne Grinovero" >> To: "inf

Re: [infinispan-dev] FindBugs on infinispan

2015-03-20 Thread Alan Field
their IDEs, but the source code in the repo is stored in a specific way. Thanks, Alan - Original Message - > From: "Sanne Grinovero" > To: "infinispan -Dev List" > Sent: Friday, March 20, 2015 7:57:14 AM > Subject: Re: [infinispan-dev] FindBugs on infinisp

Re: [infinispan-dev] FindBugs on infinispan

2015-03-20 Thread Sanne Grinovero
Same for Eclipse. I run it occasionally, but only the modules I'm working on. If everyone could do the same, that helps ;-) There is an option to get Maven to fail the build on specific selectable categories; I've played with that in the past but I had the impression that the annoyance level and m

Re: [infinispan-dev] FindBugs on infinispan

2015-03-20 Thread Pedro Ruivo
Hi, There is a findbugs pluging for IntelliJ. I run it against the classes I modified in the PR and solve the existing problems and avoid creating new ones. Pedro On 03/19/2015 04:16 PM, Jakub Markos wrote: > Hi, > > out of curiosity, I ran FindBugs [1] (java static analysis tool) on > infini

Re: [infinispan-dev] FindBugs on infinispan

2015-03-20 Thread Radim Vansa
Setting up analysis tool is rather easy, the hard part is to get people look into the results and fix what's wrong. And if noone does it, even setting it up is wasted time. my 2c Radim On 03/20/2015 10:48 AM, Sebastian Łaskawiec wrote: > Hey! > > I'm thinking about some other approach for stat

Re: [infinispan-dev] FindBugs on infinispan

2015-03-20 Thread Sebastian Łaskawiec
Hey! I'm thinking about some other approach for static code analysis - SonarQube [1]. Apart from FindBugs it performs also PMD and visualizes test coverage (typically measured by Jacoco). Sonar analysis could be performed once day in separate TeamCity job. This way we would have an insight how th