Re: [infinispan-dev] Improving the performance of index writers

2014-10-20 Thread Emmanuel Bernard
HSEARCH-1699 looks good. A few comments. Maybe from a user point of you we want to expose the number of ms the user is ok to delay a commit due to indexing. Which would mean that you can wait up to that number before calling it a day and emptying the queue. The big question I have which you

Re: [infinispan-dev] Improving the performance of index writers

2014-10-20 Thread Sanne Grinovero
On 20 October 2014 12:59, Emmanuel Bernard emman...@hibernate.org wrote: HSEARCH-1699 looks good. A few comments. Maybe from a user point of you we want to expose the number of ms the user is ok to delay a commit due to indexing. Which would mean that you can wait up to that number before

Re: [infinispan-dev] Improving the performance of index writers

2014-10-20 Thread Gustavo Fernandes
On Mon, Oct 20, 2014 at 1:10 PM, Sanne Grinovero sa...@infinispan.org wrote: On 20 October 2014 12:59, Emmanuel Bernard emman...@hibernate.org wrote: HSEARCH-1699 looks good. A few comments. Maybe from a user point of you we want to expose the number of ms the user is ok to delay a commit

Re: [infinispan-dev] Improving the performance of index writers

2014-10-20 Thread Emmanuel Bernard
On 20 Oct 2014, at 14:10, Sanne Grinovero sa...@infinispan.org wrote: On 20 October 2014 12:59, Emmanuel Bernard emman...@hibernate.org wrote: HSEARCH-1699 looks good. A few comments. Maybe from a user point of you we want to expose the number of ms the user is ok to delay a commit due to

Re: [infinispan-dev] Improving the performance of index writers

2014-10-20 Thread Sanne Grinovero
On 20 October 2014 14:55, Emmanuel Bernard emman...@hibernate.org wrote: On 20 Oct 2014, at 14:10, Sanne Grinovero sa...@infinispan.org wrote: On 20 October 2014 12:59, Emmanuel Bernard emman...@hibernate.org wrote: HSEARCH-1699 looks good. A few comments. Maybe from a user point of you we

Re: [infinispan-dev] Improving the performance of index writers

2014-10-20 Thread Emmanuel Bernard
So assuming an idle index loop, the first commit would lead to the execution of the indexing work and flush. If two or more commits come during that flush time, then the queue would be 1 and “batching” would occur. Correct? On 20 Oct 2014, at 16:57, Sanne Grinovero sa...@infinispan.org