[infinispan-dev] More commits, or squashing?

2014-06-11 Thread Sanne Grinovero
A discussion which could interest more of you: https://github.com/infinispan/infinispan/pull/2613#issuecomment-45760469 There is no golden rule, but I believe it's highly desirable to give the sequence a logical flow which makes sense. In this specific situation, it also helped myself as I've

Re: [infinispan-dev] More commits, or squashing?

2014-06-11 Thread Mircea Markus
On Jun 11, 2014, at 17:45, Adrian Nistor anis...@redhat.com wrote: I think the journey is at least as important as the destination and documenting each major step along the way by leaving a clear mark in version history is a good thing. +1 for splitting commits whenever it makes sense.