Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-11 Thread Mircea Markus
I've added my comments there - from my experience the mailing list is a better fit for this kind conversation though. On 11 Apr 2012, at 12:34, Manik Surtani wrote: > I've started playing around with the redesigned interfaces here: > > https://github.com/maniksurtani/infinispan-cachestore-propo

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-11 Thread Manik Surtani
I've started playing around with the redesigned interfaces here: https://github.com/maniksurtani/infinispan-cachestore-proposal Please have a look and comment on the wiki. On 11 Apr 2012, at 11:12, Manik Surtani wrote: > > On 10 Apr 2012, at 15:54, Galder Zamarreño wrote: > >> ^ What kind of

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-11 Thread Manik Surtani
On 10 Apr 2012, at 15:54, Galder Zamarreño wrote: > ^ What kind of timeline do you have for that? I've been having a fair few > issues withhttps://issues.jboss.org/browse/ISPN-1924 due to cache stores been > mainly configured the old way (i.e. they expect an old config object in the > interfac

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-11 Thread Manik Surtani
On 10 Apr 2012, at 19:34, Dan Berindei wrote: > > In CacheStore, the toStream and fromStream methods aren't even used > any more (used to be called by state transfer). Good, pls capture this on the design wiki. -- Manik Surtani ma...@jboss.org twitter.com/maniksurtani Lead, Infinispan http:/

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-10 Thread Dan Berindei
Seems pretty much the same as the Coherence one: https://github.com/jsr107/jsr107spec/blob/master/src/main/java/javax/cache/CacheLoader.java https://github.com/jsr107/jsr107spec/blob/master/src/main/java/javax/cache/CacheWriter.java I'm not sure where you're supposed the keys from in order to do a

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-10 Thread Galder Zamarreño
Btw, a few months back I saw this forum post: https://community.jboss.org/thread/171515 The guy's considering implementing cache loader and it's a bit confused with all methods that need to implement, and points to Coherence's cache loader interface which simply has 2 methods: http://download.o

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-10 Thread Galder Zamarreño
On Apr 2, 2012, at 3:17 PM, Mircea Markus wrote: > On 2 Apr 2012, at 14:02, Tristan Tarrant wrote: > >> I dislike the current way of configuring stores via . As part of >> my work for ISPN-1821 I will also introduce the ability for stores to >> provide their own configuration parsers so that w

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-10 Thread Galder Zamarreño
On Apr 2, 2012, at 3:02 PM, Tristan Tarrant wrote: > I dislike the current way of configuring stores via . As part of my > work for ISPN-1821 I will also introduce the ability for stores to provide > their own configuration parsers so that we can have more readable schemas. ^ What kind of time

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-05 Thread Manik Surtani
Captured in https://community.jboss.org/wiki/CacheLoaderAndCacheStoreSPIRedesign Please add any further thoughts to the wiki. On 2 Apr 2012, at 15:17, Sanne Grinovero wrote: > On 2 April 2012 14:57, Mircea Markus wrote: >> >> On 2 Apr 2012, at 14:45, Sanne Grinovero wrote: >> >>> On 2 April

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-02 Thread Sanne Grinovero
On 2 April 2012 14:57, Mircea Markus wrote: > > On 2 Apr 2012, at 14:45, Sanne Grinovero wrote: > >> On 2 April 2012 14:31, Tristan Tarrant wrote: >>> On 04/02/2012 03:17 PM, Mircea Markus wrote: On 2 Apr 2012, at 14:02, Tristan Tarrant wrote: > I dislike the current way of configur

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-02 Thread Mircea Markus
On 2 Apr 2012, at 15:06, Manik Surtani wrote: > > On 2 Apr 2012, at 14:57, Mircea Markus wrote: > >> >> On 2 Apr 2012, at 14:45, Sanne Grinovero wrote: >> >>> On 2 April 2012 14:31, Tristan Tarrant wrote: On 04/02/2012 03:17 PM, Mircea Markus wrote: > On 2 Apr 2012, at 14:02, Trista

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-02 Thread Sanne Grinovero
On 2 April 2012 15:06, Manik Surtani wrote: > > On 2 Apr 2012, at 14:45, Sanne Grinovero wrote: > > - doesn't have a "remove expired" function, needs to load all values > to check them > > > https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/loaders/CacheStore.j

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-02 Thread Manik Surtani
On 2 Apr 2012, at 14:45, Sanne Grinovero wrote: > - doesn't have a "remove expired" function, needs to load all values > to check them https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/loaders/CacheStore.java#L125 -- Manik Surtani ma...@jboss.org twitter.com

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-02 Thread Manik Surtani
On 2 Apr 2012, at 14:57, Mircea Markus wrote: > > On 2 Apr 2012, at 14:45, Sanne Grinovero wrote: > >> On 2 April 2012 14:31, Tristan Tarrant wrote: >>> On 04/02/2012 03:17 PM, Mircea Markus wrote: On 2 Apr 2012, at 14:02, Tristan Tarrant wrote: > I dislike the current way of co

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-02 Thread Mircea Markus
On 2 Apr 2012, at 14:45, Sanne Grinovero wrote: > On 2 April 2012 14:31, Tristan Tarrant wrote: >> On 04/02/2012 03:17 PM, Mircea Markus wrote: >>> On 2 Apr 2012, at 14:02, Tristan Tarrant wrote: >>> I dislike the current way of configuring stores via. As part of my work for ISPN-182

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-02 Thread Sanne Grinovero
On 2 April 2012 14:31, Tristan Tarrant wrote: > On 04/02/2012 03:17 PM, Mircea Markus wrote: >> On 2 Apr 2012, at 14:02, Tristan Tarrant wrote: >> >>> I dislike the current way of configuring stores via. As part of >>> my work for ISPN-1821 I will also introduce the ability for stores to >>> pro

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-02 Thread Tristan Tarrant
On 04/02/2012 03:17 PM, Mircea Markus wrote: > On 2 Apr 2012, at 14:02, Tristan Tarrant wrote: > >> I dislike the current way of configuring stores via. As part of my >> work for ISPN-1821 I will also introduce the ability for stores to provide >> their own configuration parsers so that we can ha

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-02 Thread Mircea Markus
On 2 Apr 2012, at 14:02, Tristan Tarrant wrote: > I dislike the current way of configuring stores via . As part of my > work for ISPN-1821 I will also introduce the ability for stores to provide > their own configuration parsers so that we can have more readable schemas. That would be quite nice

Re: [infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-02 Thread Tristan Tarrant
I dislike the current way of configuring stores via . As part of my work for ISPN-1821 I will also introduce the ability for stores to provide their own configuration parsers so that we can have more readable schemas. Participating in JTA is obviously high on the desired list, and I'd also ex

[infinispan-dev] Redesigning CacheStore and CacheLoader SPIs

2012-04-02 Thread Manik Surtani
I know this is much needed, and perhaps 6.0 may be the time to do this. Do we have a list of things we want to change here? On the back of https://community.jboss.org/message/726337#726337 it would seem that we need the ability to pass in the ConsistentHash to the CacheLoader when loading entr