Re: [infinispan-dev] broken lazy query iteration

2012-10-29 Thread Emmanuel Bernard
Correct, the DocumentExtractor contract expects the absolute index. It looks like a bug in how ISPN's Query module use it. Emmanuel On Fri 2012-10-26 16:09, Ales Justin wrote: After searching for the needed in haystack, I finally found the problem. (not to mention complete lack of tests for

Re: [infinispan-dev] broken lazy query iteration

2012-10-29 Thread Ales Justin
What's the design decision behind this? As DE has all the info, it could easily hide the offset (and max) into impl details. -Ales On Oct 29, 2012, at 11:14 AM, Emmanuel Bernard emman...@hibernate.org wrote: Correct, the DocumentExtractor contract expects the absolute index. It looks like a

Re: [infinispan-dev] broken lazy query iteration

2012-10-29 Thread Emmanuel Bernard
Made sense to me at the time. Still does for what it's worth. Plus the code using DocumentExtractor sill has to compute and deal with first and max anyways. Emmanuel On Mon 2012-10-29 14:09, Ales Justin wrote: What's the design decision behind this? As DE has all the info, it could easily

[infinispan-dev] broken lazy query iteration

2012-10-26 Thread Ales Justin
After searching for the needed in haystack, I finally found the problem. (not to mention complete lack of tests for this *basic* feature ...) The problem is with queries with offset when you iterate over them -- offset is never taken into account. There are two possible fixes -- as I see them.