Re: [PATCH][saslauthd] cyrus-sasl-2.1.10/saslauthd credential caching

2003-01-15 Thread Rob Siemborski
On Wed, 15 Jan 2003, Jeremy Rumpf wrote: > Round 3 now has: > > cache_lookup() > cache_commit() > cache_discard() I'm guessing a failure to call cache_discard() just results in a memory leak and nothing worse (since you are preserving state from cache_lookup to cache_commit)? > > Wasn't this

Re: [PATCH][saslauthd] cyrus-sasl-2.1.10/saslauthd credential caching

2003-01-15 Thread Jeremy Rumpf
Thanks, excellent feedback. I've been busy coding away all day. I'm not quite ready for another realease, but I thought I'd drop a line with some of the mods I'm making (they're pretty major). > The biggie: > > cache_lookup() writes the user-provided password hash into the hash table > BEFORE it

Re: [PATCH][saslauthd] cyrus-sasl-2.1.10/saslauthd credential caching

2003-01-15 Thread Igor Brezac
On Wed, 15 Jan 2003, Jeremy Rumpf wrote: > On Tuesday 14 January 2003 23:36 pm, Igor Brezac wrote: > > Jeremy, > > > > This stuff looks great and with a limited user sample (10) the performance > > improvement was almost 100 fold. Keep in mind, this is my first crack at > > it. I am using Solar

Re: [PATCH][saslauthd] cyrus-sasl-2.1.10/saslauthd credential caching

2003-01-15 Thread Paul M Fleming
_My_ original plan was to use libmm.. Jeremy already had a similiar solution that he modified. libmm does have the advantage that it is platform neutral -- no need for fancy autoconf tricks to figure out what kinda of shm we have. not to mention it can do the locking in a platform neutral format.

Re: [PATCH][saslauthd] cyrus-sasl-2.1.10/saslauthd credential caching

2003-01-15 Thread Rob Siemborski
On Wed, 15 Jan 2003, Jeremy Rumpf wrote: > Ok, I've set things up on a Solaris 8 machine for testing. After a few tweaks, > things appear to be working ok. One thing though, it seems that the maximum > shared memory segment size on Solaris is 1M by default. Solaris users will > have to tweak their

Re: [PATCH][saslauthd] cyrus-sasl-2.1.10/saslauthd credential caching

2003-01-15 Thread Paul M Fleming
I have a comment. From the readme: 1) The entry was not found, but was created for future lookups. 2) The entry was found, but the password in the cache didn't match the supplied password. In this case, the password in the cache is updated with the supplied password for future lookups.

Re: [PATCH][saslauthd] cyrus-sasl-2.1.10/saslauthd credential caching

2003-01-15 Thread marc . bigler
[PATCH][saslauthd] cyrus-sasl-2.1.10/saslauthd credential caching [EMAIL PROTECTED]

Re: [PATCH][saslauthd] cyrus-sasl-2.1.10/saslauthd credential caching

2003-01-15 Thread Jeremy Rumpf
On Tuesday 14 January 2003 23:36 pm, Igor Brezac wrote: > Jeremy, > > This stuff looks great and with a limited user sample (10) the performance > improvement was almost 100 fold. Keep in mind, this is my first crack at > it. I am using Solaris 9. I am getting the following error > > # ./saslcac

Re: [PATCH][saslauthd] cyrus-sasl-2.1.10/saslauthd credential caching

2003-01-14 Thread Igor Brezac
Jeremy, This stuff looks great and with a limited user sample (10) the performance improvement was almost 100 fold. Keep in mind, this is my first crack at it. I am using Solaris 9. I am getting the following error # ./saslcache -s could not attach shared memory segment: 1200 shmat: Invalid a

[PATCH][saslauthd] cyrus-sasl-2.1.10/saslauthd credential caching

2003-01-14 Thread Jeremy Rumpf
All, I've been working on combining some of the ideas for a credential caching layer into saslauthd. This is the first release for review/comments/testing. Changes: Three files have been added to the saslauthd package: cache.c cache.h README.cache saslcache.c Four files have been modifie