Re: [ovirt-devel] [VDSM] build-artifacts failing on master

2016-09-15 Thread Barak Korren
> > I'm not sure I understand your point. RPM spec files have %check section > for pre-build tests. Should we, or should we not, strive to use them? AFAIK the %check section is only relevant for DS builds, as in US we have many other places to run tests from (e.g check_patch.sh). AFAIK by its

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

2016-09-15 Thread Dan Kenigsberg
On Thu, Sep 15, 2016 at 01:15:29PM +0300, Barak Korren wrote: > > > > I love running tests on the build systems - its gives another layer of > > assurance that we are going to build a good package for the relevant > > system/architecture. > > > > However, the offending patch makes it impossible on

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

2016-09-15 Thread Barak Korren
> > I love running tests on the build systems - its gives another layer of > assurance that we are going to build a good package for the relevant > system/architecture. > > However, the offending patch makes it impossible on el7-based build > system. Can we instead skip the test (on such systems)

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

2016-09-15 Thread Dan Kenigsberg
On Wed, Sep 14, 2016 at 11:28:05PM +0300, Nir Soffer wrote: > On Wed, Sep 14, 2016 at 10:43 PM, Nir Soffer wrote: > > On Wed, Sep 14, 2016 at 10:40 PM, Irit Goihman wrote: > >> I think that what's missing in build-artifacts.sh is the following commands >

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

2016-09-14 Thread Nir Soffer
On Wed, Sep 14, 2016 at 10:43 PM, Nir Soffer wrote: > On Wed, Sep 14, 2016 at 10:40 PM, Irit Goihman wrote: >> I think that what's missing in build-artifacts.sh is the following commands >> that exist in check-patch.sh: >> >> easy_install pip >> pip

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

2016-09-14 Thread Nir Soffer
On Wed, Sep 14, 2016 at 10:40 PM, Irit Goihman wrote: > I think that what's missing in build-artifacts.sh is the following commands > that exist in check-patch.sh: > > easy_install pip > pip install -U nose==1.3.7 We cannot do this in brew/koji, you can use only packages

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

2016-09-14 Thread Irit Goihman
I think that what's missing in build-artifacts.sh is the following commands that exist in check-patch.sh: easy_install pip pip install -U nose==1.3.7 This should install the right version for nose (that doesn't exist in rhel yum repos) On Wed, Sep 14, 2016 at 10:31 PM, Eyal Edri