Re: [vdsm] pylint in make check-local

2014-02-17 Thread Dan Kenigsberg
On Thu, Feb 13, 2014 at 03:00:21AM -0500, Francesco Romani wrote: Recently, we've had a bugs http://gerrit.ovirt.org/#/c/24242/ that could have been avoided had we used pylint to check our code before its usage. Two other bugs-in-waiting can be quickly removed

Re: [vdsm] pylint in make check-local

2014-02-17 Thread Ewoud Kohl van Wijngaarden
On Mon, Feb 17, 2014 at 11:44:37AM +, Dan Kenigsberg wrote: While I'm waiting for more acks/nacks, could infra add pylint to our Jenkins slaves? Is the version in EL6 recent enough or do we have to ship our own version? (EL6 is 0.21.1) Please review http://gerrit.ovirt.org/24556

Re: [vdsm] pylint in make check-local

2014-02-17 Thread Dan Kenigsberg
On Mon, Feb 17, 2014 at 01:21:11PM +0100, Ewoud Kohl van Wijngaarden wrote: On Mon, Feb 17, 2014 at 11:44:37AM +, Dan Kenigsberg wrote: While I'm waiting for more acks/nacks, could infra add pylint to our Jenkins slaves? Is the version in EL6 recent enough or do we have to ship our own

Re: [vdsm] pylint in make check-local

2014-02-17 Thread Ewoud Kohl van Wijngaarden
On Mon, Feb 17, 2014 at 01:11:41PM +, Dan Kenigsberg wrote: On Mon, Feb 17, 2014 at 01:21:11PM +0100, Ewoud Kohl van Wijngaarden wrote: On Mon, Feb 17, 2014 at 11:44:37AM +, Dan Kenigsberg wrote: While I'm waiting for more acks/nacks, could infra add pylint to our Jenkins slaves?