Re: Findbugs job didn't run on a broken patch

2016-05-09 Thread Tal Nisan
You can see that Jenkins gave +1 in patchset 2 (which is identical to patchset 4 aside for the commit message, you can also see that those jobs started: Build Started (1/2) -> http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-el7-x86_64/598/ Build Started (2/2) -> http://jenkins.ovirt.o

Re: Findbugs job didn't run on a broken patch

2016-05-09 Thread Shlomo Ben David
Hi Nisan, 1. The findbugs job run at May 5 1:50 PM and returned with the following msg: 'The patch does not pass the findbugs' 2. The resource consuming DAO test run because there was a change in the following file in the patch: backend/manager/modules/common/src/main/java/org/ovirt/engine/core/co

Re: Findbugs job didn't run on a broken patch

2016-05-09 Thread Shlomo Ben David
sure, checking... Best Regards, Shlomi Ben-David | Software Engineer | Red Hat ISRAEL Phone: +972-54-8008858 IRC: sbendavi OPEN SOURCE - 1 4 011 && 011 4 1 On Mon, May 9, 2016 at 2:45 PM, Eyal Edri wrote: > Shlomi, > Can you have a look? > > On Sun, May 8, 2016 at 10:34 PM, Tal Nisan wrote:

Re: Findbugs job didn't run on a broken patch

2016-05-09 Thread Eyal Edri
Shlomi, Can you have a look? On Sun, May 8, 2016 at 10:34 PM, Tal Nisan wrote: > Upon looking at another patch I saw that there's a new findbugs issue: > > http://jenkins-old.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/45217/findbugsResult/new/ > > I've fixed the issue in this patch - htt

Findbugs job didn't run on a broken patch

2016-05-08 Thread Tal Nisan
Upon looking at another patch I saw that there's a new findbugs issue: http://jenkins-old.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/45217/findbugsResult/new/ I've fixed the issue in this patch - https://gerrit.ovirt.org/57209 so it's all good now but I'm wondering why the findbugs job did