Re: Running arquillian tests on gerrit reviews

2016-06-15 Thread Roman Mohr
On Wed, Jun 15, 2016 at 3:27 PM, Eyal Edri wrote: > see https://gerrit.ovirt.org/#/c/58663/ > > On Wed, Jun 15, 2016 at 3:56 PM, Barak Korren wrote: >> >> >> >> >> Would be glad to get some feedback on how to integrate them in our CI >> >> flows. >> > >> > To do so you just have to add that comma

Re: Running arquillian tests on gerrit reviews

2016-06-15 Thread Eyal Edri
see https://gerrit.ovirt.org/#/c/58663/ On Wed, Jun 15, 2016 at 3:56 PM, Barak Korren wrote: > >> > >> Would be glad to get some feedback on how to integrate them in our CI > flows. > > > > To do so you just have to add that command to the > automation/check-patch.sh > > script in the ovirt-engi

Re: Running arquillian tests on gerrit reviews

2016-06-15 Thread Barak Korren
>> >> Would be glad to get some feedback on how to integrate them in our CI flows. > > To do so you just have to add that command to the automation/check-patch.sh > script in the ovirt-engine git repo (you should also fail if it fails and > such) You should probably also make sure to integrate th

Re: Running arquillian tests on gerrit reviews

2016-06-15 Thread David Caro Estevez
On 06/15 14:36, Roman Mohr wrote: > Hi, > > Recently we merged some patches which can run arquillian unit tests > with a database (this means running ovirt commands without mocking and > working injections). They do a commit rollback after each test in the > db like th DAO tests: > > https://gerr

Running arquillian tests on gerrit reviews

2016-06-15 Thread Roman Mohr
Hi, Recently we merged some patches which can run arquillian unit tests with a database (this means running ovirt commands without mocking and working injections). They do a commit rollback after each test in the db like th DAO tests: https://gerrit.ovirt.org/#/q/status:merged+project:ovirt-engin