This was applied and closed.
On Thu, 30 Aug 2018 at 19:17, Stephen John Smoogen wrote:
>
> On Thu, 30 Aug 2018 at 17:27, Mikolaj Izdebski wrote:
> >
> > This change is for staging only, so I'm not convinced a FBR is needed.
> > But here is my review anyway.
> >
> > 1. you added host vars for
> >
On Thu, 30 Aug 2018 at 17:27, Mikolaj Izdebski wrote:
>
> This change is for staging only, so I'm not convinced a FBR is needed.
> But here is my review anyway.
>
> 1. you added host vars for
> osbs-aarch64-node01.stg.arm.fedoraproject.org, but this host is not in
> inventory
>
I had already stag
This change is for staging only, so I'm not convinced a FBR is needed.
But here is my review anyway.
1. you added host vars for
osbs-aarch64-node01.stg.arm.fedoraproject.org, but this host is not in
inventory
2. kickstart file kvm-fedora-aarch64-28-osbs does not exist
3. You set osbs_odcs_enable
Third time is supposedly the charm they say
On Thu, 30 Aug 2018 at 16:42, Dennis Gilmore wrote:
>
> +1 also thanks
> El jue, 30-08-2018 a las 16:23 -0400, Stephen John Smoogen escribió:
> > Talked with cverna on IRC and made changes from that. Please review
> > this one.
> > On Thu, 30 Aug 2018 at
+1 also thanks
El jue, 30-08-2018 a las 16:23 -0400, Stephen John Smoogen escribió:
> Talked with cverna on IRC and made changes from that. Please review
> this one.
> On Thu, 30 Aug 2018 at 14:48, Stephen John Smoogen
> wrote:
> >
> > This needs review by both infrastructure and people who are
>
On Thu, 30 Aug 2018 at 20:54, Stephen John Smoogen wrote:
> This needs review by both infrastructure and people who are familiar
> with osbs. I am mostly copya pasta editing here so it may or may not
> work. It is also not clear if we need both a master and a node or just
> a master.
>
> Looks go
Talked with cverna on IRC and made changes from that. Please review this one.
On Thu, 30 Aug 2018 at 14:48, Stephen John Smoogen wrote:
>
> This needs review by both infrastructure and people who are familiar
> with osbs. I am mostly copya pasta editing here so it may or may not
> work. It is also
+1 it looks good to me.
El jue, 30-08-2018 a las 14:48 -0400, Stephen John Smoogen escribió:
> This needs review by both infrastructure and people who are familiar
> with osbs. I am mostly copya pasta editing here so it may or may not
> work. It is also not clear if we need both a master and a nod
This needs review by both infrastructure and people who are familiar
with osbs. I am mostly copya pasta editing here so it may or may not
work. It is also not clear if we need both a master and a node or just
a master.
--
Stephen J Smoogen.
ansible-patch-2018-08-30T18:47+
Description: Bina
