Re: [Intel-gfx] [PATCH 2/2] drm/i915: Refactor panel fitting on the LVDS.

On Sat, 17 Jul 2010 13:38:44 +0100 Chris Wilson wrote: > Move the common routines into separate functions to not only increase > readability, but also throwaway surplus code. > > In doing so, we review the calculation of the aspect preserving > scaling and avoid the use of fixed-point until we n

Re: [Intel-gfx] [PATCH] drm/i915: Fix panel fitting regression since 734b4157

On Sat, 17 Jul 2010 12:46:08 +0100 Chris Wilson wrote: > The crtc mode fixup is run after the encoders adjust the mode to fit > on their output, so don't reset the mode! > > Fixes: > > Bug 29057 - display corruption under 800x600 on netbook > (1024x600) with 'Full Aspect' scalin

Re: [Intel-gfx] [PATCH 1/2] drm: Return EBUSY if the framebuffer is unbound when flipping.

On Sat, 17 Jul 2010 20:23:26 +0100 Chris Wilson wrote: > It looks like there is a race condition between unbinding a > framebuffer on a hotplug event and user space trying to flip: > Nice, yeah that would definitely be a problem. Alternately we could solder everyone's configuration into someth

Re: [Intel-gfx] 4500MHD driver crash

On July 17, 2010, Thomas Fjellstrom wrote: > On July 16, 2010, Thomas Fjellstrom wrote: > > On July 16, 2010, Thomas Fjellstrom wrote: > > > On July 16, 2010, Paul Menzel wrote: > > > > Am Freitag, den 16.07.2010, 01:50 -0600 schrieb Thomas Fjellstrom: > > > > > I've been having this little problem

Re: [Intel-gfx] [PATCH] drm/i915: Selectively enable self-reclaim

On Sat, Jul 17, 2010 at 11:58 AM, M. Vefa Bicakci wrote: > > The kernel with d8e0902806c0bd2ccc4f6a267ff52565a3ec933b reverted > was able to hibernate/thaw at least 40 times in one go, while > the one with your fix applied was able to hibernate/thaw at most > 17 times (in two separate trials) afte

[Intel-gfx] [PATCH 2/2] drm/i915: Remove extraneous variables from intel_crtc_page_flip()

Reduce the number of variables used and improve readability by scoping. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_display.c | 31 +++ 1 files changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gp

[Intel-gfx] [PATCH 1/2] drm: Return EBUSY if the framebuffer is unbound when flipping.

It looks like there is a race condition between unbinding a framebuffer on a hotplug event and user space trying to flip: BUG: unable to handle kernel NULL pointer dereference at 0058 IP: [] intel_crtc_page_flip+0xc9/0x39c [i915] PGD 114724067 PUD 1145bd067 PMD 0 Oops: [#1] SMP Pi

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Refactor panel fitting on the LVDS.

On Sat, 17 Jul 2010 13:38:44 +0100, Chris Wilson wrote: > +static inline u32 panel_fitter_scaling(u32 source, u32 target) > +{ > + /* > + * Floating point operation is not supported. So the FACTOR > + * is defined, which can avoid the floating point computation > + * when calcu

[Intel-gfx] [PATCH 2/2] drm/i915: Refactor panel fitting on the LVDS.

Move the common routines into separate functions to not only increase readability, but also throwaway surplus code. In doing so, we review the calculation of the aspect preserving scaling and avoid the use of fixed-point until we need to calculate the accurate scale factor. 1 files changed, 128 i

[Intel-gfx] [PATCH 1/2] drm/i915: Remove the redundant check for a fixed_panel_mode

We already checked just a couple of lines above that we have found a fixed_panel_mode for the LVDS, so remove the surplus check. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_lvds.c | 32 +++- 1 files changed, 15 insertions(+), 17 deletions(-) diff --g

[Intel-gfx] [PATCH] drm/i915: Fix panel fitting regression since 734b4157

The crtc mode fixup is run after the encoders adjust the mode to fit on their output, so don't reset the mode! Fixes: Bug 29057 - display corruption under 800x600 on netbook (1024x600) with 'Full Aspect' scaling https://bugs.freedesktop.org/show_bug.cgi?id=29057 Signed-off-by: