Re: [Intel-gfx] [PATCH][v2 1/2] drm/i915: prepare for video codec ring buffer on Sandybridge

2010-09-15 Thread Xiang, Haihao
On Mon, 2010-09-13 at 17:52 +0800, Chris Wilson wrote: On Mon, 13 Sep 2010 15:17:05 +0800, Xiang, Haihao haihao.xi...@intel.com wrote: Some little changes: Add set_tail hook to struct intel_ring_buffer fix HAS_BSD with a device info flag Don't export the initialiser of

[Intel-gfx] [Inter-gfx][PATCH][v3 2/4] drm/i915: do not export the instances of struct intel_ring_buffer

2010-09-15 Thread Xiang, Haihao
Introduce intel_init_render_ring_buffer(), intel_init_bsd_ring_buffer for ring initialization. Signed-off-by: Xiang, Haihao haihao.xi...@intel.com Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_gem.c | 14 ++

[Intel-gfx] [Inter-gfx][PATCH][v3 3/4] drm/i915: add set_tail hook in struct intel_ring_buffer

2010-09-15 Thread Xiang, Haihao
This is prepared for video codec ring buffer on Sandybridge. It is needed to read/write more than one register to move the tail pointer of the video codec ring on Sandybridge. Signed-off-by: Xiang, Haihao haihao.xi...@intel.com Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk ---

[Intel-gfx] [Inter-gfx][PATCH][v3 4/4] drm/i915: add a new ring buffer on Sandybridge

2010-09-15 Thread Xiang, Haihao
This ring buffer is used for video decoding/encoding on Sandybridge. Signed-off-by: Xiang, Haihao haihao.xi...@intel.com Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_drv.c |2 + drivers/gpu/drm/i915/i915_irq.c | 15 +++-

Re: [Intel-gfx] [Inter-gfx][PATCH][v3 3/4] drm/i915: add set_tail hook in struct intel_ring_buffer

2010-09-15 Thread Zhenyu Wang
On 2010.09.16 10:43:12 +0800, Xiang, Haihao wrote: This is prepared for video codec ring buffer on Sandybridge. It is needed to read/write more than one register to move the tail pointer of the video codec ring on Sandybridge. Do we really need new 'set_tail'? Isn't advance_ring used for set

Re: [Intel-gfx] [Inter-gfx][PATCH][v3 3/4] drm/i915: add set_tail hook in struct intel_ring_buffer

2010-09-15 Thread Xiang, Haihao
On Thu, 2010-09-16 at 12:21 +0800, Zhenyu Wang wrote: On 2010.09.16 10:43:12 +0800, Xiang, Haihao wrote: This is prepared for video codec ring buffer on Sandybridge. It is needed to read/write more than one register to move the tail pointer of the video codec ring on Sandybridge. Do we

Re: [Intel-gfx] [Inter-gfx][PATCH][v3 3/4] drm/i915: add set_tail hook in struct intel_ring_buffer

2010-09-15 Thread Zhenyu Wang
On 2010.09.16 13:10:29 +0800, Xiang, Haihao wrote: Or can't that be done in init function by using advance_ring? advance_ring uses ring-tail to set TAIL register, i965_reset() also invokes ring-init() to re-init ring buffer, how to guarantee ring-tail is 0? BTW advance_ring can be implemented