Re: [Intel-gfx] [PATCH 0/10] fs shader debugging

2011-07-13 Thread Ben Widawsky
On Wed, Jul 13, 2011 at 01:51:42PM -0700, Ben Widawsky wrote: > > > Version 2 of the patch series is pretty much the same as version 1. 2 of the > patches have already been picked up by the kernel and mesa so they are > gone. > > The only major change is in mesa where I no longer load a binary b

[Intel-gfx] [PATCH 2/2] drm/i915: provide module parameter description

2011-07-13 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_drv.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index ef5cf03..ce045a8 100644 --- a/drivers/gpu/drm/i915/i915_dr

[Intel-gfx] [PATCH 1/2] drm/i915: add module parameter compiler hints

2011-07-13 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_drv.c | 24 drivers/gpu/drm/i915/i915_drv.h | 20 ++-- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index d

Re: [Intel-gfx] [PATCH 09/10] debugging: add important debug regs

2011-07-13 Thread Chris Wilson
On Wed, 13 Jul 2011 13:51:51 -0700, Ben Widawsky wrote: > Signed-off-by: Ben Widawsky > --- > lib/intel_reg.h |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/lib/intel_reg.h b/lib/intel_reg.h > index 48d8f66..ef9cb63 100644 > --- a/lib/intel_reg.h > +++ b/lib/i

Re: [Intel-gfx] [PATCH 08/10] intel-gpu-tools/forcewaked: simple forcewake app

2011-07-13 Thread Chris Wilson
On Wed, 13 Jul 2011 13:51:50 -0700, Ben Widawsky wrote: > This app is required for debug features which seem to (undocumented) > reset themselves if/when the GT goes to sleep. Can you make this run a command and exit normally, or if given no args simply pause()? i.e. forcewake intel_reg_read 0x2

Re: [Intel-gfx] [PATCH 07/10] intel-gpu-tools: register range handling for forcewake hooks

2011-07-13 Thread Chris Wilson
On Wed, 13 Jul 2011 13:51:49 -0700, Ben Widawsky wrote: Non-text part: multipart/mixed > We can deprecate the old code by using the non-safe flag in the new API. > The safe flag should allow the previous behavior to continue. > > The code also adds some range checking on register access. This cod

Re: [Intel-gfx] [Mesa-dev] [PATCH 04/10] i965: setup system routine

2011-07-13 Thread Chris Wilson
On Wed, 13 Jul 2011 13:51:46 -0700, Ben Widawsky wrote: > Upload the system routine as part of the invariant state if debugging. > > Remove SIP setting if not debugging to make it more friendly for others > that may be debugging shaders or media kernels. > > Signed-off-by: Ben Widawsky > --- >

Re: [Intel-gfx] [PATCH 01/10] intel: shared header for shader debugging

2011-07-13 Thread Chris Wilson
On Wed, 13 Jul 2011 13:51:43 -0700, Ben Widawsky wrote: > > Signed-off-by: Ben Widawsky > --- > intel/Makefile.am |3 ++- > intel/intel_debug.h | 44 > 2 files changed, 46 insertions(+), 1 deletions(-) > > diff --git a/intel/Makefile.am b/in

[Intel-gfx] [PATCH 09/10] debugging: add important debug regs

2011-07-13 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- lib/intel_reg.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/lib/intel_reg.h b/lib/intel_reg.h index 48d8f66..ef9cb63 100644 --- a/lib/intel_reg.h +++ b/lib/intel_reg.h @@ -3488,5 +3488,10 @@ typedef enum { #define TRANS_DP_HSYNC_A

[Intel-gfx] [PATCH 08/10] intel-gpu-tools/forcewaked: simple forcewake app

2011-07-13 Thread Ben Widawsky
This app is required for debug features which seem to (undocumented) reset themselves if/when the GT goes to sleep. Signed-off-by: Ben Widawsky --- tools/Makefile.am |1 + tools/forcewaked.c | 45 + 2 files changed, 46 insertions(+), 0 deletions

[Intel-gfx] [PATCH 07/10] intel-gpu-tools: register range handling for forcewake hooks

2011-07-13 Thread Ben Widawsky
We can deprecate the old code by using the non-safe flag in the new API. The safe flag should allow the previous behavior to continue. The code also adds some range checking on register access. This code is gives hooks to prevent tools from doing bad things. Signed-off-by: Ben Widawsky --- lib/

[Intel-gfx] [PATCH 06/10] i965: attach to a listening debugger

2011-07-13 Thread Ben Widawsky
Use unix domain sockets to connect to a debugger and send the information the debugger will use to properly handle debug events. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_wm_debug.c | 85 - 1 files changed, 82 insertions(+), 3 deletions(-) diff

[Intel-gfx] [PATCH 05/10] i965: emit breakpoints

2011-07-13 Thread Ben Widawsky
Provide a function to allow emitting breakpoints in the instruction oword. Use breakpoints when debugging. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_eu.c |6 ++ src/mesa/drivers/dri/i965/brw_eu.h |1 + src/mesa/drivers/dri/i965/brw_wm.c |3 +++ 3 files changed

[Intel-gfx] [PATCH 04/10] i965: setup system routine

2011-07-13 Thread Ben Widawsky
Upload the system routine as part of the invariant state if debugging. Remove SIP setting if not debugging to make it more friendly for others that may be debugging shaders or media kernels. Signed-off-by: Ben Widawsky --- src/mesa/drivers/dri/i965/brw_misc_state.c | 13 + 1 files

[Intel-gfx] [PATCH 03/10] i965: Reserve scratch space for debugger communication

2011-07-13 Thread Ben Widawsky
Since the debug system routine will share scratch space with threads doing register spilling, we must offset the registers to accommodate. This is more easily accomplished (and less bug prone) in Mesa. The debugger will only work with the new fragment shader backend. Signed-off-by: Ben Widawsky

[Intel-gfx] [PATCH 0/10] fs shader debugging

2011-07-13 Thread Ben Widawsky
Version 2 of the patch series is pretty much the same as version 1. 2 of the patches have already been picked up by the kernel and mesa so they are gone. The only major change is in mesa where I no longer load a binary blob from an environment variable, but instead compile the bytes directly in

[Intel-gfx] [PATCH 01/10] intel: shared header for shader debugging

2011-07-13 Thread Ben Widawsky
Signed-off-by: Ben Widawsky --- intel/Makefile.am |3 ++- intel/intel_debug.h | 44 2 files changed, 46 insertions(+), 1 deletions(-) diff --git a/intel/Makefile.am b/intel/Makefile.am index b6a9014..7a44aaf 100644 --- a/intel/Makefile.am +++

Re: [Intel-gfx] [PATCH] drm/i915/pch: Fix integer math bugs in panel fitting

2011-07-13 Thread Keith Packard
On Wed, 13 Jul 2011 16:32:32 -0400, Adam Jackson wrote: > + if (width & 1) > + width++; > + if (height & 1) > + height++; You'll want to stick a comment in here describin

[Intel-gfx] [PATCH] drm/i915/pch: Fix integer math bugs in panel fitting

2011-07-13 Thread Adam Jackson
Consider a 1600x900 panel, upscaling a 1360x768 mode, full-aspect. The old math would give you: scaled_width = 1600 * 768; /* 1228800 */ scaled_height = 1360 * 900; /* 1224000 */ if (scaled_width > scaled_height) { /* pillarbox, and true */ width = 1224000 /

Re: [Intel-gfx] [PATCH] drm/i915: Add quirk to disable SSC on Lenovo U160 LVDS

2011-07-13 Thread Chris Wilson
On Wed, 13 Jul 2011 13:09:28 -0700, "Keith Packard" wrote: Non-text part: multipart/signed > > We've tried several times to make this machine 'just work', but every > patch that does causes many other machines to fail. This adds a quirk > which special cases this hardware and forces ssc to be > d

[Intel-gfx] [PULL] drm-intel-next

2011-07-13 Thread Keith Packard
Here's most of the patches I'm hoping to land after 3.0: * FBC cleanups from Chris Wilson. Fixes 'missing' CPU writes to the front buffer. We've enabled FBC by default, if we find regressions again, we'll turn it off before the release. * DP and HDMI support for formats other than 8bpc f

[Intel-gfx] [PATCH] drm/i915: Add quirk to disable SSC on Lenovo U160 LVDS

2011-07-13 Thread Keith Packard
We've tried several times to make this machine 'just work', but every patch that does causes many other machines to fail. This adds a quirk which special cases this hardware and forces ssc to be disabled. There's no way to override this from the command line; that would be a significantly more inv

[Intel-gfx] [PATCH] [next] drm/i915/bios: Avoid temporary allocation whilst searching for downclock

2011-07-13 Thread Chris Wilson
Alan Cox reported a missing check on the kmalloc return value for the allocation of a temporary mode used for searching for the LVDS downlock frequency. This allocation is roughly 200 bytes, a little too large to friviously place on the stack. However, we can simply use the few bytes we need stored

Re: [Intel-gfx] [PATCH 1/2] drm/i915: add module parameter compiler hints

2011-07-13 Thread Keith Packard
On Wed, 6 Jul 2011 15:14:52 -0700, Ben Widawsky wrote: > > Signed-off-by: Ben Widawsky This patch series doesn't apply to -next anymore; care to clean it up so I can merge it in? (too many -fixes applied for 3.0, I fear) -- keith.pack...@intel.com pgp7clRhEsCGt.pgp Description: PGP signat

Re: [Intel-gfx] [PATCH 08/16] drm/i915/i2c: Convert from using GMBUS1 + reg_offset idiom to reg + 0

2011-07-13 Thread Chris Wilson
On Wed, 13 Jul 2011 11:33:22 -0700, Keith Packard wrote: Non-text part: multipart/signed > On Sat, 04 Jun 2011 00:09:29 +0100, Chris Wilson > wrote: > > > I need to address the broader concerns raised by Jean Delvare first. > > Once I have our i2c adapter to his liking, I can then get the code

Re: [Intel-gfx] [PULL] drm-intel-next

2011-07-13 Thread Keith Packard
On Wed, 13 Jul 2011 19:22:14 +0200, Wolfram Sang wrote: > Is this one intentionally not in or did it slip through? I thought I had replied to that -- it doesn't apply to either -fixes or -next at this point. I can try to fix it, but I'd prefer it if you'd figure out how things have changed and r

Re: [Intel-gfx] [PATCH 08/16] drm/i915/i2c: Convert from using GMBUS1 + reg_offset idiom to reg + 0

2011-07-13 Thread Keith Packard
On Sat, 04 Jun 2011 00:09:29 +0100, Chris Wilson wrote: > I need to address the broader concerns raised by Jean Delvare first. > Once I have our i2c adapter to his liking, I can then get the code to > yours. Are you still planning on cleaning up the i2c stuff at some point? -- keith.pack...@i

[Intel-gfx] [PATCH] intel-gpu-tools:testdisplay: add gamma test

2011-07-13 Thread Hai Lan
Signed-off-by: Hai Lan --- tests/testdisplay.c | 50 -- 1 files changed, 44 insertions(+), 6 deletions(-) diff --git a/tests/testdisplay.c b/tests/testdisplay.c index e8e3309..9ea4e7f 100644 --- a/tests/testdisplay.c +++ b/tests/testdisplay.c @@