Re: [Intel-gfx] [PATCH 1/3] drm/i915: remove bogus mutex_unlock from error-path

2013-02-12 Thread Ben Widawsky
On Tue, Feb 12, 2013 at 03:36:03PM +0100, Daniel Vetter wrote: > This has been lost in the locking rework for intel_alloc_context_page: > > commit 2c34b850ee1e9f86b41706149d0954eee58757a3 > Author: Ben Widawsky > Date: Sat Mar 19 18:14:26 2011 -0700 > > drm/i915: fix ilk rc6 teardown locki

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix PIPE_CONTROL DW/QW write through global GTT on IVB+

2013-02-12 Thread Ben Widawsky
On Tue, Feb 12, 2013 at 10:01:39PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The bit controlling whether PIPE_CONTROL DW/QW write targets > the global GTT or PPGTT moved moved from DW 2 bit 2 to > DW 1 bit 24 on IVB. > > TODO: need to test on IVB actually and make sur

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Print the pipe control page GTT address

2013-02-12 Thread Daniel Vetter
On Tue, Feb 12, 2013 at 10:01:38PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We already print the HWS addresses during init, so do the same for the > pipe control page. Reduces guesswork when looking at hex addresses > later. > > Signed-off-by: Ville Syrjälä Queued

[Intel-gfx] [PATCH 2/2] drm/i915: Fix PIPE_CONTROL DW/QW write through global GTT on IVB+

2013-02-12 Thread ville . syrjala
From: Ville Syrjälä The bit controlling whether PIPE_CONTROL DW/QW write targets the global GTT or PPGTT moved moved from DW 2 bit 2 to DW 1 bit 24 on IVB. TODO: need to test on IVB actually and make sure things don't explode. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 1/2] drm/i915: Print the pipe control page GTT address

2013-02-12 Thread ville . syrjala
From: Ville Syrjälä We already print the HWS addresses during init, so do the same for the pipe control page. Reduces guesswork when looking at hex addresses later. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_ringbuffer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/d

Re: [Intel-gfx] i915 PCH backlight vs. Dell XPS13

2013-02-12 Thread Kamal Mostafa
On Fri, Feb 8, 2013 at 8:36 PM, Kamal Mostafa wrote: > > Daniel's backlight fixes which landed in 3.6 did enable working > > backlight controls on the XPS13, but it appears that this commit from > > Paolo broke it again: > > a4f32fc drm/i915: don't forget the PCH backlight registers On Fr

Re: [Intel-gfx] [PATCH] drm/i915: move LVDS support check to output setup

2013-02-12 Thread Chris Wilson
On Tue, Feb 12, 2013 at 07:37:08PM +0200, Jani Nikula wrote: > On Tue, 12 Feb 2013, Chris Wilson wrote: > > On Tue, Feb 12, 2013 at 07:06:59PM +0200, Jani Nikula wrote: > >> Keep all the platform output selection in intel_output_setup(), and don't > >> scatter it around. > > > > I see this as doin

Re: [Intel-gfx] [PATCH] drm/i915: move LVDS support check to output setup

2013-02-12 Thread Jani Nikula
On Tue, 12 Feb 2013, Chris Wilson wrote: > On Tue, Feb 12, 2013 at 07:06:59PM +0200, Jani Nikula wrote: >> Keep all the platform output selection in intel_output_setup(), and don't >> scatter it around. > > I see this as doing the opposite. You are littering an already over > complicated routine w

Re: [Intel-gfx] [PATCH] drm/i915: move LVDS support check to output setup

2013-02-12 Thread Chris Wilson
On Tue, Feb 12, 2013 at 07:06:59PM +0200, Jani Nikula wrote: > Keep all the platform output selection in intel_output_setup(), and don't > scatter it around. I see this as doing the opposite. You are littering an already over complicated routine with LVDS specific information. > As a useful side

[Intel-gfx] [PATCH] drm/i915: move LVDS support check to output setup

2013-02-12 Thread Jani Nikula
Keep all the platform output selection in intel_output_setup(), and don't scatter it around. As a useful side effect, do not try to enable LVDS on HSW or VLV. Some checks are done in a slightly different order than before, and on some platforms VGA is now initialized before LVDS. Signed-off-by: J

[Intel-gfx] [PATCH 3/3] drm/i915: push struct_mutex locking down to ironlake_enable_rc6

2013-02-12 Thread Daniel Vetter
Originally dev->struct_mutex protected all kinds of things for rps/ips (debugfs access, driver state, ...). Nowadays we have dev_priv->rps.lock for this, so only the ilk ips code needs it really. Push the locking down. I haven't yet changed the cleanup side since there we lock large parts of the c

[Intel-gfx] [PATCH 2/3] drm/i915: cancel console_resume_work before destroying the fbdev

2013-02-12 Thread Daniel Vetter
Could lead to tears if the work indeed runs after we've destroyed the fbdev ... Totally unlikely to happen though in reality. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_dma.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_dma.c b/

[Intel-gfx] [PATCH 1/3] drm/i915: remove bogus mutex_unlock from error-path

2013-02-12 Thread Daniel Vetter
This has been lost in the locking rework for intel_alloc_context_page: commit 2c34b850ee1e9f86b41706149d0954eee58757a3 Author: Ben Widawsky Date: Sat Mar 19 18:14:26 2011 -0700 drm/i915: fix ilk rc6 teardown locking Cc: Ben Widawsky Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 0/3] some locking clarifications

2013-02-12 Thread Daniel Vetter
Hi all, Three patches for little things I've recently noticed. The long-term aim behind the last one is to slowly reduce the scope of struct_mutex and clarify what's actually protected by it. Comments highly welcome. Cheers, Daniel Daniel Vetter (3): drm/i915: remove bogus mutex_unlock from e

[Intel-gfx] [PATCH i-g-t] tests: Forbid to run the blit tests with count of 1

2013-02-12 Thread Damien Lespiau
From: Damien Lespiau Invoking say, sudo ./tests/gem_render_linear_blits 1 does not make a lot of sense as we're creating a single bo. The test does not yell at you and passes, even if the rendercopy function does not do anything. This makes it quite harmful when trying to debug rendercopy wit

[Intel-gfx] [PATCH] drm/i915: Introduce mapping of user pages into video memory (userptr) ioctl

2013-02-12 Thread Chris Wilson
By exporting the ability to map user address and inserting PTEs representing their backing pages into the GTT, we can exploit UMA in order to utilize normal application data as a texture source or even as a render target (depending upon the capabilities of the chipset). This has a number of uses, w

Re: [Intel-gfx] [PATCH 2/2] drm/i915: clean up panel fitter handling in lvds

2013-02-12 Thread Daniel Vetter
On Fri, Feb 08, 2013 at 04:35:38PM +0200, Mika Kuoppala wrote: > commit c1d1f5aeda2033d96e872f416388653f05d4c16d > Author: Mika Kuoppala > Date: Tue Feb 5 17:26:52 2013 +0200 > > drm/i915: disable shared panel fitter for pipe > > moved panel fit disabling to be crtc property. Thus > the ne

Re: [Intel-gfx] [PATCH] drm/i915: unify HDMI/DP hpd definitions

2013-02-12 Thread Daniel Vetter
On Thu, Feb 07, 2013 at 11:15:26AM -0200, Paulo Zanoni wrote: > 2013/2/7 Daniel Vetter : > > They're physically the same pins and also the same bits, duplicating > > only confuses the reader. This also makes it a bit obvious that we > > have quite some code duplication going on here. Squashing that

Re: [Intel-gfx] [PATCH] drm/i915: detect wrong MCH watermark values

2013-02-12 Thread Daniel Vetter
On Sat, Feb 09, 2013 at 12:24:02PM -0800, Ben Widawsky wrote: > On Sat, Feb 09, 2013 at 09:03:42PM +0100, Daniel Vetter wrote: > > Some early bios versions seem to ship with the wrong tuning values for > > the MCH, possible resulting in pipe underruns under load. Especially > > on DP outputs this c

Re: [Intel-gfx] [PATCH v2] drm/i915/ctx: Remove bad invariant

2013-02-12 Thread Daniel Vetter
On Mon, Feb 11, 2013 at 01:31:27PM -0800, Ben Widawsky wrote: > It's not that the assertion is incorrect, but rather that we can call > do_destroy early in loading, and we will falsely BUG(). > > Since contexts have been in for a while now, and in the internal APIs > are pretty stable, it should b