Re: [Intel-gfx] [Alsa-user] intel-hda: sound via HDMI only when using interlaced modes

2013-10-10 Thread Jani Nikula
On Wed, 09 Oct 2013, Jasper Smet josb...@gmail.com wrote: As promissed i added the params to the kernel boot and here's the dmesg output with debugging enabled: http://sprunge.us/iEQR Similar dmesg for when you connect directly to the tv (and audio works) might prove useful. Is your

Re: [Intel-gfx] [Alsa-user] intel-hda: sound via HDMI only when using interlaced modes

2013-10-10 Thread Jasper Smet
I managed do this quickly before i got off to work: Dmesg output with directly connected to the tv: http://sprunge.us/EhJD Neither the VSX-928 nor the TV (passtrough) pick up sound when connected to the AV receiver. I noticed that when i set the resolution to 1080i@30 sound works on the

Re: [Intel-gfx] [PATCH] drm/i915: Export the eLLC size from KMD via IOCTL

2013-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2013 at 03:11:40AM +, Guo, Yejun wrote: Hi Daniel, For example, the close source UMD driver also requires this information. For upstream a userspace blob as consumer isn't good enough, Dave Airlie has clearly established this precendence in a bunch of loud emails. So I

Re: [Intel-gfx] [Alsa-user] intel-hda: sound via HDMI only when using interlaced modes

2013-10-10 Thread Jani Nikula
On Thu, 10 Oct 2013, Jasper Smet josb...@gmail.com wrote: I managed do this quickly before i got off to work: Dmesg output with directly connected to the tv: http://sprunge.us/EhJD Neither the VSX-928 nor the TV (passtrough) pick up sound when connected to the AV receiver. I noticed that

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Populate primary_disabled in intel_modeset_readout_hw_state()

2013-10-10 Thread Ville Syrjälä
On Wed, Oct 09, 2013 at 05:24:57PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Make sure our primary_disabled matches our expectations after driver init. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70270 Tested-by: Paulo Zanoni

Re: [Intel-gfx] [Alsa-user] intel-hda: sound via HDMI only when using interlaced modes

2013-10-10 Thread Jani Nikula
On Thu, 10 Oct 2013, Jani Nikula jani.nik...@linux.intel.com wrote: On Thu, 10 Oct 2013, Jasper Smet josb...@gmail.com wrote: I managed do this quickly before i got off to work: Dmesg output with directly connected to the tv: http://sprunge.us/EhJD Neither the VSX-928 nor the TV (passtrough)

Re: [Intel-gfx] [Alsa-user] intel-hda: sound via HDMI only when using interlaced modes

2013-10-10 Thread Jasper Smet
Ok, for the distro (OpenElec) i'm using i'll need to to re-compile the kernel with the CONFIG_DRM_LOAD_EDID_FIRMWARE=y option so i'll try to set up a build env later this day and hope for the best :-) On Thu, Oct 10, 2013 at 10:27 AM, Jani Nikula jani.nik...@linux.intel.com wrote: On Thu, 10 Oct

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rename primary_disabled to primary_enabled

2013-10-10 Thread Jani Nikula
On Wed, 09 Oct 2013, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Let's try to avoid these confusing negated booleans. Thanks for such a positive patch! For the series, Reviewed-by: Jani Nikula jani.nik...@intel.com Signed-off-by: Ville Syrjälä

Re: [Intel-gfx] [Alsa-user] intel-hda: sound via HDMI only when using interlaced modes

2013-10-10 Thread Jani Nikula
On Thu, 10 Oct 2013, Jasper Smet josb...@gmail.com wrote: Ok, for the distro (OpenElec) i'm using i'll need to to re-compile the kernel with the CONFIG_DRM_LOAD_EDID_FIRMWARE=y option so i'll try to set up a build env later this day and hope for the best :-) Heh, good luck! In the mean time,

Re: [Intel-gfx] [Alsa-user] intel-hda: sound via HDMI only when using interlaced modes

2013-10-10 Thread Jasper Smet
That will be this evening as i'm at work now :'( On Thu, Oct 10, 2013 at 10:38 AM, Jani Nikula jani.nik...@linux.intel.com wrote: On Thu, 10 Oct 2013, Jasper Smet josb...@gmail.com wrote: Ok, for the distro (OpenElec) i'm using i'll need to to re-compile the kernel with the

[Intel-gfx] [PATCH] drm/i915: Cancel outstanding pc8 work when shutting down the device

2013-10-10 Thread Chris Wilson
As part of the device quiesceing we need to disable all active timers and delayed workers so that they do not execute after the module is unloaded. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Paulo Zanoni paulo.r.zan...@intel.com Cc: Rodrigo Vivi rodrigo.v...@gmail.com ---

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use unsigned long for obj-user_pin_count

2013-10-10 Thread Ville Syrjälä
On Wed, Oct 09, 2013 at 09:23:53PM +0200, Daniel Vetter wrote: At least on linux sizeof(long) == sizeof(void*) and the thinking is that you can grab about as many references as there's memory. Well, there can be more memory than there is address space. Unchecked counters always leave me a bit

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Rename primary_disabled to primary_enabled

2013-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2013 at 11:35:24AM +0300, Jani Nikula wrote: On Wed, 09 Oct 2013, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Let's try to avoid these confusing negated booleans. Thanks for such a positive patch! For the series, Reviewed-by:

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Use unsigned long for obj-user_pin_count

2013-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2013 at 10:56 AM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Wed, Oct 09, 2013 at 09:23:53PM +0200, Daniel Vetter wrote: At least on linux sizeof(long) == sizeof(void*) and the thinking is that you can grab about as many references as there's memory. Well, there can

[Intel-gfx] [PATCH] drm/i915: Capture the initial error-state when kicking stuck rings

2013-10-10 Thread Chris Wilson
We lost the ability to capture the first error for a stuck ring in the recent hangcheck robustification. Whilst both error states are interesting (why does the GPU not recover is also essential to debug), our primary goal is to fix the initial hang and so we need to capture the first error state

Re: [Intel-gfx] [PATCH] drm/i915: Capture the initial error-state when kicking stuck rings

2013-10-10 Thread Mika Kuoppala
Chris Wilson ch...@chris-wilson.co.uk writes: We lost the ability to capture the first error for a stuck ring in the recent hangcheck robustification. Whilst both error states are interesting (why does the GPU not recover is also essential to debug), our primary goal is to fix the initial

Re: [Intel-gfx] [PATCH] drm/i915: Capture the initial error-state when kicking stuck rings

2013-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2013 at 12:41:15PM +0300, Mika Kuoppala wrote: Chris Wilson ch...@chris-wilson.co.uk writes: We lost the ability to capture the first error for a stuck ring in the recent hangcheck robustification. Whilst both error states are interesting (why does the GPU not recover is

[Intel-gfx] [PATCH 1/2] drm/i915/hsw: Add I915_EXEC_RESOURCE_STREAMER flag (v3)

2013-10-10 Thread Abdiel Janulgue
Ensures that the batch buffer is executed by the resource streamer. v3: - Make sure batch is only submitted on render ring and Haswell (Daniel) - Separate EXEC and DISPATCH flags (Chris) - Update __I915_EXEC_UNKNOWN_FLAGS (Kenneth) Signed-off-by: Abdiel Janulgue

Re: [Intel-gfx] [PATCH 2/4] drm/i915: prevent tiling changes on framebuffer backing storage

2013-10-10 Thread Ville Syrjälä
On Thu, Oct 10, 2013 at 12:09:48AM +0200, Daniel Vetter wrote: On Thu, Oct 10, 2013 at 12:02:17AM +0200, Daniel Vetter wrote: On Wed, Oct 09, 2013 at 10:29:39PM +0100, Chris Wilson wrote: On Wed, Oct 09, 2013 at 09:23:52PM +0200, Daniel Vetter wrote: Assuming that all framebuffer related

[Intel-gfx] [PATCH 2/2] drm/i915/hsw: Enable resource streamer bit on MI_BATCH_BUFFER_START (v3)

2013-10-10 Thread Abdiel Janulgue
v3: Use the I915_DISPATCH_RS flag to determine if batchbuffer needs resource streamer bit. Cc: Chris Wilson ch...@chris-wilson.co.uk Cc: Daniel Vetter dan...@ffwll.ch Cc: Ben Widawsky b...@bwidawsk.net Signed-off-by: Abdiel Janulgue abdiel.janul...@linux.intel.com ---

Re: [Intel-gfx] [PATCH 2/2] drm/i915/hsw: Enable resource streamer bit on MI_BATCH_BUFFER_START (v3)

2013-10-10 Thread Chris Wilson
On Thu, Oct 10, 2013 at 02:03:00PM +0300, Abdiel Janulgue wrote: v3: Use the I915_DISPATCH_RS flag to determine if batchbuffer needs resource streamer bit. Cc: Chris Wilson ch...@chris-wilson.co.uk Cc: Daniel Vetter dan...@ffwll.ch Cc: Ben Widawsky b...@bwidawsk.net Signed-off-by:

[Intel-gfx] [PATCH i-g-t] testdisplay: Allow getopt to print error messages

2013-10-10 Thread Thomas Wood
By not assigning opterr, getopt will print its own error message that includes information about whether an option is unknown or just requires an additional argument. Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/testdisplay.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915: Use unsigned long for obj-user_pin_count

2013-10-10 Thread Daniel Vetter
At least on linux sizeof(long) == sizeof(void*) and the thinking is that you can grab about as many references as there's memory. Doesn't really matter, just a bit of OCD since the fixed size data type in a pure in-kernel datastructure look off. v2: Ville asked for an overflow check since no one

Re: [Intel-gfx] [PATCH 0/4] framebuffer_init checks

2013-10-10 Thread Ville Syrjälä
On Wed, Oct 09, 2013 at 09:23:50PM +0200, Daniel Vetter wrote: Hi all, That little patch turned into a bit more, and on top of it there's now also a new testcase in igt: kms_addfb. It checks for most of the evil stuff you can feed to addfb. For the series: Reviewed-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH] drm/i915: Use unsigned long for obj-user_pin_count

2013-10-10 Thread Chris Wilson
On Thu, Oct 10, 2013 at 01:29:37PM +0200, Daniel Vetter wrote: At least on linux sizeof(long) == sizeof(void*) and the thinking is that you can grab about as many references as there's memory. Doesn't really matter, just a bit of OCD since the fixed size data type in a pure in-kernel

Re: [Intel-gfx] [PATCH] drm/i915: Finish enabling rps before use by sysfs or debugfs

2013-10-10 Thread Daniel Vetter
On Tue, Sep 17, 2013 at 06:05:27PM +0200, Daniel Vetter wrote: On Tue, Sep 17, 2013 at 12:12 AM, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Sep 16, 2013 at 02:56:43PM -0700, Tom.O'rou...@intel.com wrote: From: Tom O'Rourke Tom.O'rou...@intel.com Enabling rps (turbo setup) was put in a

[Intel-gfx] [PATCH] drm/i915: tell the user KMS is required for gen6+

2013-10-10 Thread Jani Nikula
Educate the users why i915 won't load on gen6+ and nomodeset. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=61671 Signed-off-by: Jani Nikula jani.nik...@intel.com --- drivers/gpu/drm/i915/i915_dma.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH] drm/i915: Use unsigned long for obj-user_pin_count

2013-10-10 Thread Daniel Vetter
At least on linux sizeof(long) == sizeof(void*) and the thinking is that you can grab about as many references as there's memory. Doesn't really matter, just a bit of OCD since the fixed size data type in a pure in-kernel datastructure look off. v2: Ville asked for an overflow check since no one

Re: [Intel-gfx] [PATCH v4 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

2013-10-10 Thread Rafael J. Wysocki
On Thursday, October 10, 2013 09:02:55 AM Aaron Lu wrote: On 10/10/2013 08:29 AM, Rafael J. Wysocki wrote: On Tuesday, October 08, 2013 02:40:00 PM Aaron Lu wrote: According to Matthew Garrett, Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI

Re: [Intel-gfx] [PATCH] drm/i915: Use unsigned long for obj-user_pin_count

2013-10-10 Thread Chris Wilson
On Thu, Oct 10, 2013 at 02:46:37PM +0200, Daniel Vetter wrote: At least on linux sizeof(long) == sizeof(void*) and the thinking is that you can grab about as many references as there's memory. Doesn't really matter, just a bit of OCD since the fixed size data type in a pure in-kernel

[Intel-gfx] [PATCH 2/2] drm/i915: Do not enable package C8 on unsupported hardware

2013-10-10 Thread Chris Wilson
If the hardware does not support package C8, then do not even schedule work to enable it. Thereby we can eliminate a bunch of dangerous work. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/i915/i915_drv.h |1 +

[Intel-gfx] [PATCH 1/2] drm/i915: Hold pc8 lock around toggling pc8.gpu_idle

2013-10-10 Thread Chris Wilson
We need to hold the pc8 lock around toggling the value of gpu_idle. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/i915/intel_display.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH] drm: add support for additional stereo 3D modes

2013-10-10 Thread Thomas Wood
Parse the 3D_Structure_ALL and 3D_MASK fields of the HDMI Vendor Specific Data Block to expose more stereo 3D modes. Signed-off-by: Thomas Wood thomas.w...@intel.com --- drivers/gpu/drm/drm_edid.c | 93 ++ 1 file changed, 85 insertions(+), 8

Re: [Intel-gfx] [PATCH] drm/i915: tell the user KMS is required for gen6+

2013-10-10 Thread Ville Syrjälä
On Thu, Oct 10, 2013 at 03:25:37PM +0300, Jani Nikula wrote: Educate the users why i915 won't load on gen6+ and nomodeset. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=61671 Signed-off-by: Jani Nikula jani.nik...@intel.com Yes, much better than the agp wtf error people get

[Intel-gfx] Macmini6, 1 with i915 2:2.20.0-0ubuntu0~precise1 Hard Freezing and drm_ioctl Debug Message Help

2013-10-10 Thread Preston Connors
I am having an issue where my Macmini6,1 is hard freezing (no keyboard control, have to power off and power back on using the power button) when attempting to display a random video at random times but always freezing when the video should be displayed by VLC during the start of the video. I am

[Intel-gfx] linux-next: manual merge of the drm-intel tree

2013-10-10 Thread Mark Brown
Today's linux-next merge of the drm-intel tree got additional conflicts in drivers/gpu/drm/i915/intel_drv.h as a result of interactions between 6aba5b6cf098 (drm/i915/dp: get rid of intel_dp-link_configuration) and various commits from Paulo Zanoni staticising functions. I've fixed up by changing

Re: [Intel-gfx] [PATCH] drm/i915: tell the user KMS is required for gen6+

2013-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2013 at 05:28:54PM +0300, Ville Syrjälä wrote: On Thu, Oct 10, 2013 at 03:25:37PM +0300, Jani Nikula wrote: Educate the users why i915 won't load on gen6+ and nomodeset. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=61671 Signed-off-by: Jani Nikula

[Intel-gfx] [PATCH] drm/i915: Fix pipe off timeout handling for pre-gen4

2013-10-10 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com The current pre-gen4 pipe off code might break out of the loop due to the timeout, but then the fail to print the warning. Fix the issue by making sure we pair up the correct time comparison functions. It would be enough to change just the final

Re: [Intel-gfx] [PATCH 4/4] drm/i915: skip useless vblank wait on Haswell audio sequence

2013-10-10 Thread Paulo Zanoni
2013/9/22 Lin, Mengdong mengdong@intel.com: Hi Daniel and Paulo, I think we need a confirmation from HW owner whether vblank wait can be skipped in audio enabling and disabling. I'll ping HW owner and involve you. The original code just follows b-spec but there is no explanation why.

Re: [Intel-gfx] [PATCH 4/4] drm/i915: skip useless vblank wait on Haswell audio sequence

2013-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2013 at 8:33 PM, Paulo Zanoni przan...@gmail.com wrote: 2013/9/22 Lin, Mengdong mengdong@intel.com: Hi Daniel and Paulo, I think we need a confirmation from HW owner whether vblank wait can be skipped in audio enabling and disabling. I'll ping HW owner and involve you.

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Hold pc8 lock around toggling pc8.gpu_idle

2013-10-10 Thread Paulo Zanoni
2013/10/10 Chris Wilson ch...@chris-wilson.co.uk: We need to hold the pc8 lock around toggling the value of gpu_idle. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Paulo Zanoni paulo.r.zan...@intel.com Should we Cc:stable ? Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com I

Re: [Intel-gfx] [PATCH] drm/i915: Cancel outstanding pc8 work when shutting down the device

2013-10-10 Thread Paulo Zanoni
2013/10/10 Chris Wilson ch...@chris-wilson.co.uk: As part of the device quiesceing we need to disable all active timers and delayed workers so that they do not execute after the module is unloaded. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Paulo Zanoni paulo.r.zan...@intel.com

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Do not enable package C8 on unsupported hardware

2013-10-10 Thread Paulo Zanoni
2013/10/10 Chris Wilson ch...@chris-wilson.co.uk: If the hardware does not support package C8, then do not even schedule work to enable it. Thereby we can eliminate a bunch of dangerous work. As I already explained, this should not be a problem since non-Haswell platforms don't have a way to

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Do not enable package C8 on unsupported hardware

2013-10-10 Thread Chris Wilson
On Thu, Oct 10, 2013 at 05:17:31PM -0300, Paulo Zanoni wrote: 2013/10/10 Chris Wilson ch...@chris-wilson.co.uk: If the hardware does not support package C8, then do not even schedule work to enable it. Thereby we can eliminate a bunch of dangerous work. As I already explained, this should

Re: [Intel-gfx] [PATCH] drm/i915: Fix pipe off timeout handling for pre-gen4

2013-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2013 at 08:32:23PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com The current pre-gen4 pipe off code might break out of the loop due to the timeout, but then the fail to print the warning. Fix the issue by making sure we pair

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Hold pc8 lock around toggling pc8.gpu_idle

2013-10-10 Thread Chris Wilson
On Thu, Oct 10, 2013 at 05:04:27PM -0300, Paulo Zanoni wrote: 2013/10/10 Chris Wilson ch...@chris-wilson.co.uk: We need to hold the pc8 lock around toggling the value of gpu_idle. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Paulo Zanoni paulo.r.zan...@intel.com Should we

Re: [Intel-gfx] [PATCH] drm/i915: Cancel outstanding pc8 work when shutting down the device

2013-10-10 Thread Chris Wilson
On Thu, Oct 10, 2013 at 05:21:37PM -0300, Paulo Zanoni wrote: 2013/10/10 Chris Wilson ch...@chris-wilson.co.uk: As part of the device quiesceing we need to disable all active timers and delayed workers so that they do not execute after the module is unloaded. Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Fix pipe off timeout handling for pre-gen4

2013-10-10 Thread Chris Wilson
On Thu, Oct 10, 2013 at 08:32:23PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com The current pre-gen4 pipe off code might break out of the loop due to the timeout, but then the fail to print the warning. Fix the issue by making sure we pair

[Intel-gfx] [PATCH] drm/i915: Avoid tweaking RPS before it is enabled

2013-10-10 Thread Chris Wilson
As we delay the initial RPS enabling (upon boot and after resume), there is a chance that we may start to render and trigger RPS boosts before we set up the punit. Any changes we make could result in inconsistent hardware state, with a danger of causing undefined behaviour. However, as the

Re: [Intel-gfx] [PATCH] drm/i915: Avoid tweaking RPS before it is enabled

2013-10-10 Thread Jesse Barnes
On Thu, 10 Oct 2013 21:58:50 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: As we delay the initial RPS enabling (upon boot and after resume), there is a chance that we may start to render and trigger RPS boosts before we set up the punit. Any changes we make could result in inconsistent

Re: [Intel-gfx] [PATCH] drm/i915: Fix pipe off timeout handling for pre-gen4

2013-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2013 at 09:42:44PM +0100, Chris Wilson wrote: On Thu, Oct 10, 2013 at 08:32:23PM +0300, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com The current pre-gen4 pipe off code might break out of the loop due to the timeout, but then the

Re: [Intel-gfx] [PATCH] drm/i915: Avoid tweaking RPS before it is enabled

2013-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2013 at 02:06:02PM -0700, Jesse Barnes wrote: On Thu, 10 Oct 2013 21:58:50 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: As we delay the initial RPS enabling (upon boot and after resume), there is a chance that we may start to render and trigger RPS boosts before we

Re: [Intel-gfx] [PATCH v2 01/16] drm/i915: Add intel_pipe_wm and prepare for watermark pre-compute

2013-10-10 Thread Paulo Zanoni
2013/10/9 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com Introduce a new struct intel_pipe_wm which contains all the watermarks for a single pipe. Use it to unify the LP0 and LP1+ watermark computations so that we can just iterate through the watermark

Re: [Intel-gfx] [PATCH 02/16] drm/i915: Don't re-compute pipe watermarks except for the affected pipe

2013-10-10 Thread Paulo Zanoni
2013/10/9 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com No point in re-computing the watermarks for all pipes, when only one pipe has changed. The watermarks stored under intel_crtc.wm.active are still valid for the other pipes. We just need to redo the

Re: [Intel-gfx] [PATCH 03/16] drm/i915: Move LP1+ watermark merging out from hsw_compute_wm_results()

2013-10-10 Thread Paulo Zanoni
2013/10/9 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com I want to convert hsw_find_best_result() to use intel_pipe_wm, so we need to move the merging to happen outside hsw_compute_wm_results(). Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com

Re: [Intel-gfx] [PATCH 04/16] drm/i915: Use intel_pipe_wm in hsw_find_best_results

2013-10-10 Thread Paulo Zanoni
2013/10/9 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com Let's try to keep using the intermediate intel_pipe_wm representation for as long as possible. It avoids subtle knowledge about the internals of the hardware registers when trying to choose the best

Re: [Intel-gfx] [PATCH 05/16] drm/i915: Move some computations out from hsw_compute_wm_parameters()

2013-10-10 Thread Paulo Zanoni
2013/10/9 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com Move the watermark max computations into haswell_update_wm(). This allows keeping the 1/2 vs. 5/6 split code in one place, and avoid having to pass around so many things. We also save a bit of stack

Re: [Intel-gfx] [PATCH 06/16] drm/i915: Don't compute 5/6 DDB split w/ zero active pipes

2013-10-10 Thread Paulo Zanoni
2013/10/9 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com When there are zero active pipes, all the watermarks should be zero also. No point in wasting time w/ computing the 5/6 split watermark config. Signed-off-by: Ville Syrjälä

Re: [Intel-gfx] [PATCH 07/16] drm/i915: Refactor wm_lp to level calculation

2013-10-10 Thread Paulo Zanoni
2013/10/9 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com On HSW the LP1,LP2,LP3 levels are either 1,2,3 or 1,3,4. We make the conversion from LPn to to the level at one point current. Later we're going to do it in a few places, so move it to a separate

Re: [Intel-gfx] [PATCH 08/16] drm/i915: Kill fbc_wm_enabled from intel_wm_config

2013-10-10 Thread Paulo Zanoni
2013/10/9 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com The fbc_wm_enabled member in intel_wm_config is useless for the time being. The original idea for it was that we'd pre-compute it and so that the WM merging process could know whether it needs to worry

Re: [Intel-gfx] [PATCH v4 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

2013-10-10 Thread Aaron Lu
On 10/10/2013 08:59 PM, Rafael J. Wysocki wrote: On Thursday, October 10, 2013 09:02:55 AM Aaron Lu wrote: On 10/10/2013 08:29 AM, Rafael J. Wysocki wrote: On Tuesday, October 08, 2013 02:40:00 PM Aaron Lu wrote: According to Matthew Garrett, Windows 8 leaves backlight control up to

[Intel-gfx] [PATCH intel-gpu-tools] configure: Don't bail if libdrm_nouveau isn't available.

2013-10-10 Thread Matt Turner
We were seriously *requiring* libdrm_nouveau unless explicitly disabled? --- configure.ac | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index f65942f..43740f9 100644 --- a/configure.ac +++ b/configure.ac @@ -92,8 +92,11 @@

Re: [Intel-gfx] [PATCH intel-gpu-tools] configure: Don't bail if libdrm_nouveau isn't available.

2013-10-10 Thread Ben Widawsky
On Thu, Oct 10, 2013 at 08:56:45PM -0700, Matt Turner wrote: We were seriously *requiring* libdrm_nouveau unless explicitly disabled? Acked-by: Ben Widawsky b...@bwidawsk.net --- configure.ac | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/configure.ac

Re: [Intel-gfx] [PATCH] drm/i915: Kconfig option to disable the legacy fbdev support

2013-10-10 Thread Lee, Chon Ming
On 10/09 09:18, Daniel Vetter wrote: Boots Just Fine (tm)! The only glitch seems to be that at least on Fedora the boot splash gets confused and doesn't display much at all. And since there's no ugly console flickering anymore in between, the flicker while switching between X servers (VT