Re: [Intel-gfx] [PATCH] drm/i915: Mention when we enable the Ironlake iommu workarounds

2013-12-30 Thread Ben Widawsky
On Mon, Dec 30, 2013 at 12:16:15PM +, Chris Wilson wrote: > The iommu and gfx on Ironlake do not like each other and require a > big hammer to prevent hard machine hangs. In > > commit 5c0422878fcdc279ae9a8e8b66972a15b5efb67f > Author: Ben Widawsky > Date: Mon Oct 17 15:51:55 2011 -0700 >

Re: [Intel-gfx] [PATCH] drm/i915: set ctx->initialized only after RCS

2013-12-30 Thread Ben Widawsky
On Sun, Dec 29, 2013 at 09:59:26AM +, Chris Wilson wrote: > On Sat, Dec 28, 2013 at 01:31:49PM -0800, Ben Widawsky wrote: > > The initialized flag is used to specify a context has been initialized > > and it's context is safe to load, ie. the 3d state is setup properly. > > With full PPGTT, we

Re: [Intel-gfx] [PATCH] shader-debugger: Use in tree gen4asm

2013-12-30 Thread Ben Widawsky
Should be fixed now. Sorry about that. On Mon, Dec 30, 2013 at 10:57:29AM -0200, Paulo Zanoni wrote: > 2013/12/21 Ben Widawsky : > > Reported-by: Patrick McMunn > > Signed-off-by: Ben Widawsky > > I see this got merged. Now when I run autogen.sh I get: > ./configure: line 20866: GEN4ASM: com

Re: [Intel-gfx] [PATCH 1/6] igt_kms: don't leak the mmap used for cairo

2013-12-30 Thread Chris Wilson
On Mon, Dec 30, 2013 at 03:53:10PM -0200, Paulo Zanoni wrote: > 2013/12/30 Chris Wilson : > > On Mon, Dec 30, 2013 at 01:56:48PM -0200, Paulo Zanoni wrote: > >> From: Paulo Zanoni > >> > >> When we call kmstest_get_cairo_ctx() and create a context, we do a > >> gem_mmap. The problem is that we los

Re: [Intel-gfx] [PATCH 1/6] igt_kms: don't leak the mmap used for cairo

2013-12-30 Thread Paulo Zanoni
2013/12/30 Chris Wilson : > On Mon, Dec 30, 2013 at 01:56:48PM -0200, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> When we call kmstest_get_cairo_ctx() and create a context, we do a >> gem_mmap. The problem is that we lose the mmap pointer, so we leak it. >> This patch stores the pointer and fr

Re: [Intel-gfx] [PATCH 1/6] igt_kms: don't leak the mmap used for cairo

2013-12-30 Thread Chris Wilson
On Mon, Dec 30, 2013 at 01:56:48PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > When we call kmstest_get_cairo_ctx() and create a context, we do a > gem_mmap. The problem is that we lose the mmap pointer, so we leak it. > This patch stores the pointer and frees it at kmstest_remove_fb. >

[Intel-gfx] [PATCH 5/6] tests/kms_flip: don't leak the connector_config struct

2013-12-30 Thread Paulo Zanoni
From: Paulo Zanoni ... in case we can't find a compatible mode. We already have config[0], we can't return without freeing it first. Caught by Valgrind. Signed-off-by: Paulo Zanoni --- tests/kms_flip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/kms_flip.c b/t

[Intel-gfx] [PATCH 4/6] tests/kms_flip: don't leak the CRTC

2013-12-30 Thread Paulo Zanoni
From: Paulo Zanoni The kms_flip program calls kmstest_get_connector_config, which returns a struct containing some allocated variables, including a pointer to the CRTC. The problem is that we copy the values returned by this structure to the test_output struct, but we ignore the CRTC pointer. So

[Intel-gfx] [PATCH 6/6] tests/kms_flip: free the test_output struct when counting modes

2013-12-30 Thread Paulo Zanoni
From: Paulo Zanoni Looks like we have to do a lot of work just to count the number of modes... Caught by Valgrind. Signed-off-by: Paulo Zanoni --- tests/kms_flip.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index

[Intel-gfx] [PATCH 2/6] drmtest: don't leak memory when parsing the arguments

2013-12-30 Thread Paulo Zanoni
From: Paulo Zanoni Found this while investigating memory leaks on kms_flip. Detected by Valgrind. Signed-off-by: Paulo Zanoni --- lib/drmtest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/drmtest.c b/lib/drmtest.c index 3d79a4d..7275b7f 100644 --- a/lib/drmtest.c +++ b/lib/drmtes

[Intel-gfx] [PATCH 3/6] tests/kms_flip: don't leak the connector when setting DPMS

2013-12-30 Thread Paulo Zanoni
From: Paulo Zanoni Caught by Valgrind. Signed-off-by: Paulo Zanoni --- tests/kms_flip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index eaa42b5..80f4d76 100644 --- a/tests/kms_flip.c +++ b/tests/kms_flip.c @@ -295,6 +295,8 @@ static void dpms_off

[Intel-gfx] [PATCH 1/6] igt_kms: don't leak the mmap used for cairo

2013-12-30 Thread Paulo Zanoni
From: Paulo Zanoni When we call kmstest_get_cairo_ctx() and create a context, we do a gem_mmap. The problem is that we lose the mmap pointer, so we leak it. This patch stores the pointer and frees it at kmstest_remove_fb. Huge test suites like kms_flip do this operation thousands of times, which

Re: [Intel-gfx] i915: [drm] stuck on render ring

2013-12-30 Thread Chris Wilson
On Mon, Dec 30, 2013 at 05:00:55PM +0200, Punk Rider wrote: >Hello Chris >Thanks for the fast response. >I'm currently running 3.12.6 kernel and Mesa 9.2.1 >Which Mesa release do you recommend installing for testing ? � >10.0.1 or 9.2.5? Both are regarded as stable, but 9.2.5 s

Re: [Intel-gfx] i915: [drm] stuck on render ring

2013-12-30 Thread Punk Rider
Hello Chris Thanks for the fast response. I'm currently running 3.12.6 kernel and Mesa 9.2.1 Which Mesa release do you recommend installing for testing ? 10.0.1 or 9.2.5? Regards Victor 2013/12/30 Chris Wilson > On Mon, Dec 30, 2013 at 04:47:28PM +0200, Punk Rider wrote: > >While i was w

Re: [Intel-gfx] i915: [drm] stuck on render ring

2013-12-30 Thread Chris Wilson
On Mon, Dec 30, 2013 at 04:47:28PM +0200, Punk Rider wrote: >While i was watching some online movie my kernel stuck(everything froze). >After a while system recovered and i saw these messages on dmesg: >[93395.591457] [drm] stuck on render ring >[93395.591463] [drm] capturing error

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Return -ENONENT on default ctx destroy

2013-12-30 Thread Chris Wilson
On Tue, Dec 24, 2013 at 04:02:54PM -0800, Ben Widawsky wrote: > This was an accidental "ABI" change introduced during PPGTT: > > commit 0eea67eb26000657079b7fc41079097942339452 > Author: Ben Widawsky > Date: Fri Dec 6 14:11:19 2013 -0800 > > drm/i915: Create a per file_priv default context

Re: [Intel-gfx] [PATCH] shader-debugger: Use in tree gen4asm

2013-12-30 Thread Paulo Zanoni
2013/12/21 Ben Widawsky : > Reported-by: Patrick McMunn > Signed-off-by: Ben Widawsky I see this got merged. Now when I run autogen.sh I get: ./configure: line 20866: GEN4ASM: command not found But the autogen command finishes successfully: Intel GPU tools • Tests: Build tests

[Intel-gfx] [PATCH] drm/i915: Mention when we enable the Ironlake iommu workarounds

2013-12-30 Thread Chris Wilson
The iommu and gfx on Ironlake do not like each other and require a big hammer to prevent hard machine hangs. In commit 5c0422878fcdc279ae9a8e8b66972a15b5efb67f Author: Ben Widawsky Date: Mon Oct 17 15:51:55 2011 -0700 drm/i915: ILK + VT-d workaround we added the workaround, but never emit

[Intel-gfx] [ANNOUNCE] xf86-video-intel 2.99.907

2013-12-30 Thread Chris Wilson
Snapshot 2.99.907 (2013-12-30) == The highlight here is that things seem to be quietening down on the bug reporting front. All is not quiet as you will see below, and maybe it is just the holiday season that is approaching*, but there has been a remarkable falloff in bug

Re: [Intel-gfx] [PATCH] Revert "drm/i915: assume all GM45 Acer laptops use inverted backlight PWM"

2013-12-30 Thread Jani Nikula
Ben, please pick this up for -fixes during Daniel's absense. BR, Jani. On Sat, 28 Dec 2013, Alexander van Heukelum wrote: > My Acer 8510TZ stops displaying anything when X starts with Linus' current > tree. I bisected it down to commit ee1452d74584. > > This patch reverts commit ee1452d74584.