[Intel-gfx] [PATCH] drm/i915/ppgtt: Defer request freeing on reset

2013-12-31 Thread Ben Widawsky
We need to defer the free request until the object/vma is capable of being freed - or else we have a problem when we try to destroy the context. The exact same issue is described and fixed here: commit e20780439b26ba95aeb29d3e27cd8cc32bc82a4c Author: Ben Widawsky Date: Fri Dec 6 14:11:22 2013

[Intel-gfx] [PATCH] [v2] drm/i915/ppgtt: Never return a NULL context

2013-12-31 Thread Ben Widawsky
It makes all the code which calls into this function way too confusing. v2: Fix destroy IOCTL as well Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=72903 Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_gem_context.c | 12 +--- 1 file changed, 9 insertions(+), 3 deleti

[Intel-gfx] [PATCH 2/2] drm/i915: Avoid dereference past end of page array in gen8_ppgtt_insert_entries()

2013-12-31 Thread Chris Wilson
The bug from gen6_ppgtt_insert_entries() was replicated into gen8_ppgtt_insert_entries(). This applies the fix for the OOPS from the previous patch to the gen8 routine. Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: Ben Widawsky --- drivers/gpu/drm/i915/i915_gem_gtt.c | 18 +

[Intel-gfx] [PATCH 1/2] drm/i915: Avoid dereference past end of page array in gen6_ppgtt_insert_entries()

2013-12-31 Thread Chris Wilson
[ 89.237347] BUG: unable to handle kernel paging request at 880096326000 [ 89.237369] IP: [] gen6_ppgtt_insert_entries+0x117/0x170 [ 89.237382] PGD 2272067 PUD 25df0e067 PMD 25de5c067 PTE 800096326060 [ 89.237394] Oops: [#1] SMP DEBUG_PAGEALLOC [ 89.237404] CPU: 1 PID: 1981 C

Re: [Intel-gfx] [PATCH 1/6] igt_kms: don't leak the mmap used for cairo

2013-12-31 Thread Chris Wilson
On Mon, Dec 30, 2013 at 06:16:20PM +, Chris Wilson wrote: > On Mon, Dec 30, 2013 at 03:53:10PM -0200, Paulo Zanoni wrote: > > 2013/12/30 Chris Wilson : > > > On Mon, Dec 30, 2013 at 01:56:48PM -0200, Paulo Zanoni wrote: > > >> From: Paulo Zanoni > > >> > > >> When we call kmstest_get_cairo_ctx

Re: [Intel-gfx] [PATCH] drm/i915: set ctx->initialized only after RCS

2013-12-31 Thread Chris Wilson
On Mon, Dec 30, 2013 at 01:34:46PM -0800, Ben Widawsky wrote: > On Sun, Dec 29, 2013 at 09:59:26AM +, Chris Wilson wrote: > > On Sat, Dec 28, 2013 at 01:31:49PM -0800, Ben Widawsky wrote: > > > The initialized flag is used to specify a context has been initialized > > > and it's context is safe

Re: [Intel-gfx] i915: [drm] stuck on render ring

2013-12-31 Thread Punk Rider
I compiled and installed Mesa 9.2.5 and xf86-video-intel-2.99.907 I've tested them with some heavy-duty CAD apps and until now they work like a charm. The old problems are gone as far as i can see . I will test it further and let you know. Very nice work , Chris , thank you very much. Too bad