Re: [Intel-gfx] [PATCH 1/5] drm/i915: Place the Global GTT VM first in the list of VM

2014-01-25 Thread Kenneth Graunke
On 01/24/2014 06:17 PM, Ben Widawsky wrote: From: Chris Wilson ch...@chris-wilson.co.uk This is useful for debugging as we then know that the first entry is always the global GTT, and all later entries the per-process GTT VM. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk

[Intel-gfx] [PATCH] i915: remove pm_qos request on error

2014-01-25 Thread Stanislaw Gruszka
Not removing pm qos request and free memory for it can cause crash, when some other driver use pm qos. For example, this oops: BUG: unable to handle kernel paging request at fff8 IP: [81307a6b] plist_add+0x5b/0xd0 Call Trace: [810acf25]

Re: [Intel-gfx] [PATCH] i915: remove pm_qos request on error

2014-01-25 Thread Daniel Vetter
On Sat, Jan 25, 2014 at 10:13:37AM +0100, Stanislaw Gruszka wrote: Not removing pm qos request and free memory for it can cause crash, when some other driver use pm qos. For example, this oops: BUG: unable to handle kernel paging request at fff8 IP: [81307a6b]

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Print captured bo for all VM in error state

2014-01-25 Thread Daniel Vetter
On Fri, Jan 24, 2014 at 12:13:44PM -0800, Ben Widawsky wrote: ping Merged the first patch to topic/ppgtt, but punted on the 2nd - I think with Mika's improvement to the guilty batch detection we should be able to fix this better. Or what's the consensus here? Aside: I didn't spot your r-b

Re: [Intel-gfx] [PATCH] drm/i915: debugfs: Add support for probing DP sink CRC.

2014-01-25 Thread Daniel Vetter
On Fri, Jan 24, 2014 at 03:43:58PM +, Damien Lespiau wrote: On Fri, Jan 24, 2014 at 01:36:17PM -0200, Rodrigo Vivi wrote: This debugfs interface will allow intel-gpu-tools test case to verify if screen has been updated properly on cases like PSR. v2: Accepted all Daniel's

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Make underruns DRM_ERROR

2014-01-25 Thread Daniel Vetter
On Fri, Jan 24, 2014 at 04:42:55PM -0200, Paulo Zanoni wrote: 2014/1/17 ville.syrj...@linux.intel.com: From: Ville Syrjälä ville.syrj...@linux.intel.com I want to see these without having full debugs enabled. You missed gen8_irq_handler(). With that fixed: Reviewed-by: Paulo Zanoni

Re: [Intel-gfx] [PATCH 4/4 v2] pm_rps: Require that cur reaches min at idle

2014-01-25 Thread Daniel Vetter
On Thu, Jan 23, 2014 at 03:54:50PM -0600, jeff.mc...@intel.com wrote: From: Jeff McGee jeff.mc...@intel.com The current frequency should reach the minimum frequency within a reasonable time during idle. v2: Not using forcewake for this particular subtest per Daniel's suggestion.

Re: [Intel-gfx] [PATCH 05/10] drm/i915: Use 1/2 compression ratio limit for 16bpp on FBC2

2014-01-25 Thread Daniel Vetter
On Thu, Jan 23, 2014 at 04:49:12PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com Hm, running the fbc tests with a 16bpp fb would be neat ... -Daniel ---

Re: [Intel-gfx] [PATCH 00/10] drm/i915: Some less complex FBC fixes

2014-01-25 Thread Daniel Vetter
On Thu, Jan 23, 2014 at 07:47:59PM +, Chris Wilson wrote: On Thu, Jan 23, 2014 at 04:49:07PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Since fixing the FBC locking is a bigger task that will take a while, I decided to pull all the

Re: [Intel-gfx] [PATCH] drm/i915: Redoing the PSR setup on resume

2014-01-25 Thread Daniel Vetter
On Fri, Jan 24, 2014 at 12:50:17AM +0530, Ramalingam C wrote: Due to switch between console and graphics modes multiple psr_enable call will be made. On such occasions, to avoid repeated psr_setup, a flag called psr_setup_done is used. On suspend-resume, panel goes for a power cycle. Hence

Re: [Intel-gfx] [PATCH 1/2] drm: dp helper: Add DP test sink CRC definition.

2014-01-25 Thread Daniel Vetter
On Tue, Jan 14, 2014 at 04:21:49PM -0200, Rodrigo Vivi wrote: This address will be used to verify panel CRC for test and validation purposes. Signed-off-by: Rodrigo Vivi rodrigo.v...@gmail.com checkpatch noticed some whitespace fail in here (spaces before tabs). I've fixed it up. -Daniel

Re: [Intel-gfx] [PATCH] drm/i915: Always pin the default context

2014-01-25 Thread Daniel Vetter
On Thu, Jan 23, 2014 at 07:40:02PM +, Chris Wilson wrote: Through a twisty and circuituous path it is possible to currently trick the code into creating a default context and forgetting to pin it immediately into the GGTT. (This requires a system using contexts without an aliasing ppgtt,

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Round up object allocations

2014-01-25 Thread Daniel Vetter
On Thu, Jan 23, 2014 at 07:21:10PM -0800, Ben Widawsky wrote: DRM gets very mad when you request an object which occupies a partial page. As a DRM driver, i915 never really wants to anger DRM, and would always just want the rounding done for us. Signed-off-by: Ben Widawsky b...@bwidawsk.net

Re: [Intel-gfx] [PATCH v2] drm/i915: fix dp/sdvo i2c cleanup

2014-01-25 Thread Daniel Vetter
On Fri, Jan 24, 2014 at 02:47:33PM +0200, Imre Deak wrote: Atm we try to remove the connector's i2c sysfs entry too late in the encoder's destroy callback. By that time the kobject used as the parent for all connector sysfs entries is already removed when we do an early removal of all

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Create a USES_PPGTT macro

2014-01-25 Thread Daniel Vetter
On Fri, Jan 24, 2014 at 06:17:43PM -0800, Ben Widawsky wrote: There are cases where we want to know if there is a full, or aliased ppgtt. Having to always to the || is annoying. This shorthand will keep the code a bit cleaner/easier to read. Signed-off-by: Ben Widawsky b...@bwidawsk.net ---

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Place the Global GTT VM first in the list of VM

2014-01-25 Thread Daniel Vetter
On Sat, Jan 25, 2014 at 12:32:33AM -0800, Kenneth Graunke wrote: On 01/24/2014 06:17 PM, Ben Widawsky wrote: From: Chris Wilson ch...@chris-wilson.co.uk This is useful for debugging as we then know that the first entry is always the global GTT, and all later entries the per-process GTT

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Place the Global GTT VM first in the list of VM

2014-01-25 Thread Kenneth Graunke
On 01/25/2014 12:48 PM, Daniel Vetter wrote: On Sat, Jan 25, 2014 at 12:32:33AM -0800, Kenneth Graunke wrote: On 01/24/2014 06:17 PM, Ben Widawsky wrote: From: Chris Wilson ch...@chris-wilson.co.uk This is useful for debugging as we then know that the first entry is always the global GTT,

Re: [Intel-gfx] [PATCH v2] drm/i915: fix dp/sdvo i2c cleanup

2014-01-25 Thread Imre Deak
On Sat, 2014-01-25 at 21:37 +0100, Daniel Vetter wrote: On Fri, Jan 24, 2014 at 02:47:33PM +0200, Imre Deak wrote: Atm we try to remove the connector's i2c sysfs entry too late in the encoder's destroy callback. By that time the kobject used as the parent for all connector sysfs entries is

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Place the Global GTT VM first in the list of VM

2014-01-25 Thread Ben Widawsky
On Sat, Jan 25, 2014 at 01:31:29PM -0800, Kenneth Graunke wrote: On 01/25/2014 12:48 PM, Daniel Vetter wrote: On Sat, Jan 25, 2014 at 12:32:33AM -0800, Kenneth Graunke wrote: On 01/24/2014 06:17 PM, Ben Widawsky wrote: From: Chris Wilson ch...@chris-wilson.co.uk This is useful for

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Create a USES_PPGTT macro

2014-01-25 Thread Ben Widawsky
On Sat, Jan 25, 2014 at 09:41:22PM +0100, Daniel Vetter wrote: On Fri, Jan 24, 2014 at 06:17:43PM -0800, Ben Widawsky wrote: There are cases where we want to know if there is a full, or aliased ppgtt. Having to always to the || is annoying. This shorthand will keep the code a bit

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Round up object allocations

2014-01-25 Thread Ben Widawsky
On Sat, Jan 25, 2014 at 09:28:24PM +0100, Daniel Vetter wrote: On Thu, Jan 23, 2014 at 07:21:10PM -0800, Ben Widawsky wrote: DRM gets very mad when you request an object which occupies a partial page. As a DRM driver, i915 never really wants to anger DRM, and would always just want the